* bug#4471: menu-bar menu is undefined @ 2009-09-17 21:19 ` Juri Linkov 2009-09-18 3:02 ` Stefan Monnier 2009-10-25 0:50 ` bug#4471: marked as done (menu-bar menu is undefined) Emacs bug Tracking System 0 siblings, 2 replies; 3+ messages in thread From: Juri Linkov @ 2009-09-17 21:19 UTC (permalink / raw) To: bug-gnu-emacs Some menu-bar's menus fail to open in non-toolkit X builds. For instance, when I click on the "Buffer-Menu" menu-bar's item, it signals the error: <menu-bar> <Buffer-menu-mode> <nil> is undefined However, with the following patch it displays the menu correctly: Index: lisp/buff-menu.el =================================================================== RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v retrieving revision 1.125 diff -u -r1.125 buff-menu.el --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 @@ -119,7 +119,7 @@ (defvar Buffer-menu-mode-map (let ((map (make-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "Buffer-Menu"))) (suppress-keymap map t) (define-key map "v" 'Buffer-menu-select) (define-key map "2" 'Buffer-menu-2-window) If this is the right way to define menus, I could do the same for other menus as well, e.g. Index: lisp/add-log.el =================================================================== RCS file: /sources/emacs/emacs/lisp/add-log.el,v retrieving revision 1.230 diff -u -r1.230 add-log.el --- lisp/add-log.el 1 Sep 2009 07:24:18 -0000 1.230 +++ lisp/add-log.el 17 Sep 2009 21:16:23 -0000 @@ -551,7 +551,7 @@ (defvar change-log-mode-map (let ((map (make-sparse-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "ChangeLog"))) (define-key map [?\C-c ?\C-p] 'add-log-edit-prev-comment) (define-key map [?\C-c ?\C-n] 'add-log-edit-next-comment) (define-key map [?\C-c ?\C-f] 'change-log-find-file) and some other menus that have no menu names. -- Juri Linkov http://www.jurta.org/emacs/ ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#4471: menu-bar menu is undefined 2009-09-17 21:19 ` bug#4471: menu-bar menu is undefined Juri Linkov @ 2009-09-18 3:02 ` Stefan Monnier 2009-10-25 0:50 ` bug#4471: marked as done (menu-bar menu is undefined) Emacs bug Tracking System 1 sibling, 0 replies; 3+ messages in thread From: Stefan Monnier @ 2009-09-18 3:02 UTC (permalink / raw) To: Juri Linkov; +Cc: 4471 > Some menu-bar's menus fail to open in non-toolkit X builds. > For instance, when I click on the "Buffer-Menu" menu-bar's item, > it signals the error: > <menu-bar> <Buffer-menu-mode> <nil> is undefined > However, with the following patch it displays the menu correctly: > Index: lisp/buff-menu.el > =================================================================== > RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v > retrieving revision 1.125 > diff -u -r1.125 buff-menu.el > --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 > +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 > @@ -119,7 +119,7 @@ > (defvar Buffer-menu-mode-map > (let ((map (make-keymap)) > - (menu-map (make-sparse-keymap))) > + (menu-map (make-sparse-keymap "Buffer-Menu"))) > (suppress-keymap map t) > (define-key map "v" 'Buffer-menu-select) > (define-key map "2" 'Buffer-menu-2-window) IIUC this is a correct way to fix it, indeed. OTOH it would be better to make the non-toolkit code accept the same keymaps as accepted by the toolkit code. Stefan ^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#4471: marked as done (menu-bar menu is undefined) 2009-09-17 21:19 ` bug#4471: menu-bar menu is undefined Juri Linkov 2009-09-18 3:02 ` Stefan Monnier @ 2009-10-25 0:50 ` Emacs bug Tracking System 1 sibling, 0 replies; 3+ messages in thread From: Emacs bug Tracking System @ 2009-10-25 0:50 UTC (permalink / raw) To: Chong Yidong [-- Attachment #1: Type: text/plain, Size: 852 bytes --] Your message dated Sat, 24 Oct 2009 20:41:02 -0400 with message-id <87pr8ccnkx.fsf@stupidchicken.com> and subject line Re: bug#4471: menu-bar menu is undefined has caused the Emacs bug report #4471, regarding menu-bar menu is undefined to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 4471: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4471 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 3739 bytes --] From: Juri Linkov <juri@jurta.org> To: bug-gnu-emacs@gnu.org Subject: menu-bar menu is undefined Date: Fri, 18 Sep 2009 00:19:47 +0300 Message-ID: <87bpl96zgs.fsf@mail.jurta.org> Some menu-bar's menus fail to open in non-toolkit X builds. For instance, when I click on the "Buffer-Menu" menu-bar's item, it signals the error: <menu-bar> <Buffer-menu-mode> <nil> is undefined However, with the following patch it displays the menu correctly: Index: lisp/buff-menu.el =================================================================== RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v retrieving revision 1.125 diff -u -r1.125 buff-menu.el --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 @@ -119,7 +119,7 @@ (defvar Buffer-menu-mode-map (let ((map (make-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "Buffer-Menu"))) (suppress-keymap map t) (define-key map "v" 'Buffer-menu-select) (define-key map "2" 'Buffer-menu-2-window) If this is the right way to define menus, I could do the same for other menus as well, e.g. Index: lisp/add-log.el =================================================================== RCS file: /sources/emacs/emacs/lisp/add-log.el,v retrieving revision 1.230 diff -u -r1.230 add-log.el --- lisp/add-log.el 1 Sep 2009 07:24:18 -0000 1.230 +++ lisp/add-log.el 17 Sep 2009 21:16:23 -0000 @@ -551,7 +551,7 @@ (defvar change-log-mode-map (let ((map (make-sparse-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "ChangeLog"))) (define-key map [?\C-c ?\C-p] 'add-log-edit-prev-comment) (define-key map [?\C-c ?\C-n] 'add-log-edit-next-comment) (define-key map [?\C-c ?\C-f] 'change-log-find-file) and some other menus that have no menu names. -- Juri Linkov http://www.jurta.org/emacs/ [-- Attachment #3: Type: message/rfc822, Size: 2057 bytes --] From: Chong Yidong <cyd@stupidchicken.com> To: Stefan Monnier <monnier@iro.umontreal.ca> Cc: Juri Linkov <juri@jurta.org>, 4471-done@emacsbugs.donarmstrong.com Subject: Re: bug#4471: menu-bar menu is undefined Date: Sat, 24 Oct 2009 20:41:02 -0400 Message-ID: <87pr8ccnkx.fsf@stupidchicken.com> > > (defvar Buffer-menu-mode-map > > (let ((map (make-keymap)) > > - (menu-map (make-sparse-keymap))) > > + (menu-map (make-sparse-keymap "Buffer-Menu"))) > > (suppress-keymap map t) > > (define-key map "v" 'Buffer-menu-select) > > (define-key map "2" 'Buffer-menu-2-window) > > IIUC this is a correct way to fix it, indeed. > OTOH it would be better to make the non-toolkit code accept the same > keymaps as accepted by the toolkit code. I've checked in a change to keyboard.c, allowing the non-toolkit code to handle keymaps with no prompt strings. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-25 0:50 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <87pr8ccnkx.fsf@stupidchicken.com> 2009-09-17 21:19 ` bug#4471: menu-bar menu is undefined Juri Linkov 2009-09-18 3:02 ` Stefan Monnier 2009-10-25 0:50 ` bug#4471: marked as done (menu-bar menu is undefined) Emacs bug Tracking System
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.