From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4471: marked as done (menu-bar menu is undefined) Date: Sun, 25 Oct 2009 00:50:05 +0000 Message-ID: References: <87pr8ccnkx.fsf@stupidchicken.com> <87bpl96zgs.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1256431805-14969-0" X-Trace: ger.gmane.org 1256432854 28649 80.91.229.12 (25 Oct 2009 01:07:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 25 Oct 2009 01:07:34 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 25 02:07:27 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N1rZu-0001vR-Ov for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Oct 2009 02:07:27 +0100 Original-Received: from localhost ([127.0.0.1]:34595 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1rZu-0006YT-2S for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Oct 2009 21:07:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N1rZp-0006Y6-E8 for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2009 21:07:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N1rZk-0006Xe-Tp for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2009 21:07:20 -0400 Original-Received: from [199.232.76.173] (port=57832 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1rZk-0006Xb-O4 for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2009 21:07:16 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50818) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N1rZk-0001Nu-45 for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2009 21:07:16 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9P17D99018191; Sat, 24 Oct 2009 18:07:14 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n9P0o5h3015040; Sat, 24 Oct 2009 17:50:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4471 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32226 Archived-At: This is a multi-part message in MIME format... ------------=_1256431805-14969-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 24 Oct 2009 20:41:02 -0400 with message-id <87pr8ccnkx.fsf@stupidchicken.com> and subject line Re: bug#4471: menu-bar menu is undefined has caused the Emacs bug report #4471, regarding menu-bar menu is undefined to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4471: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4471 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1256431805-14969-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 17 Sep 2009 21:23:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8HLN1p4002854 for ; Thu, 17 Sep 2009 14:23:03 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoORQ-0004Ix-T8 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:23:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoORM-0004IU-Aj for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:23:00 -0400 Received: from [199.232.76.173] (port=33679 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoORM-0004IR-5P for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:22:56 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4]:45777 helo=mx2.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MoORL-000766-Rc for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 17:22:56 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (82.131.28.98.cable.starman.ee [82.131.28.98]) by mx2.starman.ee (Postfix) with ESMTP id DD6443F4119 for ; Fri, 18 Sep 2009 00:22:48 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: menu-bar menu is undefined Organization: JURTA Date: Fri, 18 Sep 2009 00:19:47 +0300 Message-ID: <87bpl96zgs.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Some menu-bar's menus fail to open in non-toolkit X builds. For instance, when I click on the "Buffer-Menu" menu-bar's item, it signals the error: is undefined However, with the following patch it displays the menu correctly: Index: lisp/buff-menu.el =================================================================== RCS file: /sources/emacs/emacs/lisp/buff-menu.el,v retrieving revision 1.125 diff -u -r1.125 buff-menu.el --- lisp/buff-menu.el 15 Jan 2009 16:46:09 -0000 1.125 +++ lisp/buff-menu.el 17 Sep 2009 21:15:37 -0000 @@ -119,7 +119,7 @@ (defvar Buffer-menu-mode-map (let ((map (make-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "Buffer-Menu"))) (suppress-keymap map t) (define-key map "v" 'Buffer-menu-select) (define-key map "2" 'Buffer-menu-2-window) If this is the right way to define menus, I could do the same for other menus as well, e.g. Index: lisp/add-log.el =================================================================== RCS file: /sources/emacs/emacs/lisp/add-log.el,v retrieving revision 1.230 diff -u -r1.230 add-log.el --- lisp/add-log.el 1 Sep 2009 07:24:18 -0000 1.230 +++ lisp/add-log.el 17 Sep 2009 21:16:23 -0000 @@ -551,7 +551,7 @@ (defvar change-log-mode-map (let ((map (make-sparse-keymap)) - (menu-map (make-sparse-keymap))) + (menu-map (make-sparse-keymap "ChangeLog"))) (define-key map [?\C-c ?\C-p] 'add-log-edit-prev-comment) (define-key map [?\C-c ?\C-n] 'add-log-edit-next-comment) (define-key map [?\C-c ?\C-f] 'change-log-find-file) and some other menus that have no menu names. -- Juri Linkov http://www.jurta.org/emacs/ ------------=_1256431805-14969-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4471-done) by emacsbugs.donarmstrong.com; 25 Oct 2009 00:41:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pantheon-po39.its.yale.edu (pantheon-po39.its.yale.edu [130.132.50.100]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9P0f9hU014266 for <4471-done@emacsbugs.donarmstrong.com>; Sat, 24 Oct 2009 17:41:10 -0700 Received: from furry (adsl-99-89-90-109.dsl.wlfrct.sbcglobal.net [99.89.90.109]) (authenticated bits=0) by pantheon-po39.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id n9P0f3cV030857 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 24 Oct 2009 20:41:03 -0400 Received: by furry (Postfix, from userid 1000) id 9C663C070; Sat, 24 Oct 2009 20:41:02 -0400 (EDT) From: Chong Yidong To: Stefan Monnier Cc: Juri Linkov , 4471-done@emacsbugs.donarmstrong.com Subject: Re: bug#4471: menu-bar menu is undefined Date: Sat, 24 Oct 2009 20:41:02 -0400 Message-ID: <87pr8ccnkx.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) > > (defvar Buffer-menu-mode-map > > (let ((map (make-keymap)) > > - (menu-map (make-sparse-keymap))) > > + (menu-map (make-sparse-keymap "Buffer-Menu"))) > > (suppress-keymap map t) > > (define-key map "v" 'Buffer-menu-select) > > (define-key map "2" 'Buffer-menu-2-window) > > IIUC this is a correct way to fix it, indeed. > OTOH it would be better to make the non-toolkit code accept the same > keymaps as accepted by the toolkit code. I've checked in a change to keyboard.c, allowing the non-toolkit code to handle keymaps with no prompt strings. ------------=_1256431805-14969-0--