bug#447: last-nonmenu-event and sub-menus

bug#447: last-nonmenu-event and sub-menus

[Glenn Morris]

last-nonmenu-event returns a bad value when submenus are involved.
This applies to 22.2 and the current CVS. As an example:

emacs -Q

;; Evaluate this code:

(defun bar ()
  (interactive)
  (message "%s :: %s" last-nonmenu-event
     (posn-window (event-start last-nonmenu-event)))
  (sit-for 5))

(global-set-key
 [down-mouse-2]
 '(menu-item "foo"
             (keymap "foo"
                     (bar menu-item "bar" bar)
                     (submenu menu-item "submenu"
                              (keymap "submenu" (bar menu-item "bar" bar))))))

C-x 2
Put "scratch" in one window, "messages" in the other.
Select "messages" window.
Move mouse over "scratch", but do not select it.
Press mouse-2, and select the "bar" menu-item.


When called from the top-level menu, `bar' correctly returns:

(down-mouse-2 (#<window 3 on *scratch*> 534 (251 . 101) 2649593899 nil
534 (27 . 6) nil (8 . 11) (9 . 15))) :: #<window 3 on *scratch*>


When called from the submenu, `bar' returns a bad result:

bar :: #<window 7 on *Messages*>

The window is wrong, etc.

bug#447: marked as done (last-nonmenu-event and sub-menus)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]


Your message dated Mon, 12 Jan 2009 10:58:44 +0100
with message-id <496B1454.4020409@gmx.at>
and subject line Re: last-nonmenu-event and sub-menus
has caused the Emacs bug report #447,
regarding last-nonmenu-event and sub-menus
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
447: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=447
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3070 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: bug-gnu-emacs@gnu.org
Subject: last-nonmenu-event and sub-menus
Date: Wed, 18 Jun 2008 19:06:54 -0400
Message-ID: <i9wskme41d.fsf@fencepost.gnu.org>


last-nonmenu-event returns a bad value when submenus are involved.
This applies to 22.2 and the current CVS. As an example:

emacs -Q

;; Evaluate this code:

(defun bar ()
  (interactive)
  (message "%s :: %s" last-nonmenu-event
     (posn-window (event-start last-nonmenu-event)))
  (sit-for 5))

(global-set-key
 [down-mouse-2]
 '(menu-item "foo"
             (keymap "foo"
                     (bar menu-item "bar" bar)
                     (submenu menu-item "submenu"
                              (keymap "submenu" (bar menu-item "bar" bar))))))

C-x 2
Put "scratch" in one window, "messages" in the other.
Select "messages" window.
Move mouse over "scratch", but do not select it.
Press mouse-2, and select the "bar" menu-item.


When called from the top-level menu, `bar' correctly returns:

(down-mouse-2 (#<window 3 on *scratch*> 534 (251 . 101) 2649593899 nil
534 (27 . 6) nil (8 . 11) (9 . 15))) :: #<window 3 on *scratch*>


When called from the submenu, `bar' returns a bad result:

bar :: #<window 7 on *Messages*>

The window is wrong, etc.




[-- Attachment #3: Type: message/rfc822, Size: 1625 bytes --]

From: martin rudalics <rudalics@gmx.at>
To: 447-done@emacsbugs.donarmstrong.com
Cc: Glenn Morris <rgm@gnu.org>
Subject: Re: last-nonmenu-event and sub-menus
Date: Mon, 12 Jan 2009 10:58:44 +0100
Message-ID: <496B1454.4020409@gmx.at>

Fixed as

	* keyboard.c (read_char): Fix case where last_nonmenu_event
	returned a bad value with submenus.  (Bug#447)

martin