bug#4461: undefined reference to `x_get_resource_string'

bug#4461: undefined reference to `x_get_resource_string'

[Juri Linkov]

Without these lines in frame.c:

-char *
-x_get_resource_string (attribute, class)
-     char *attribute, *class;
-{
-  char *name_key;
-  char *class_key;
-  struct frame *sf = SELECTED_FRAME ();
-
-  /* Allocate space for the components, the dots which separate them,
-     and the final '\0'.  */
-  name_key = (char *) alloca (SBYTES (Vinvocation_name)
-			      + strlen (attribute) + 2);
-  class_key = (char *) alloca ((sizeof (EMACS_CLASS) - 1)
-			       + strlen (class) + 2);
-
-  sprintf (name_key, "%s.%s", SDATA (Vinvocation_name), attribute);
-  sprintf (class_key, "%s.%s", EMACS_CLASS, class);
-
-  return x_get_string_resource (FRAME_X_DISPLAY_INFO (sf)->xrdb,
-				name_key, class_key);
-}

compilation fails:

../oldXMenu/libXMenu11.a(Create.o): In function `XMenuCreate':
../oldXMenu/Create.c:244: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:250: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:256: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:263: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:269: undefined reference to `x_get_resource_string'
../oldXMenu/libXMenu11.a(Create.o):../oldXMenu/Create.c:293: more undefined references to `x_get_resource_string' follow
collect2: ld returned 1 exit status
make[1]: *** [temacs] Error 1

in non-toolkit GNU Emacs 23.1.50 (x86_64-pc-linux-gnu) configured as:

  What operating system and machine description files should Emacs use?
        `s/gnu-linux.h' and `m/amdx86-64.h'
  What compiler should emacs be built with?               gcc -g3 -O0 -Wno-pointer-sign -fno-inline -fno-crossjumping
  What window system should Emacs use?                    x11
  What toolkit should Emacs use?                          none
  Where do we find X Windows header files?                Standard dirs
  Where do we find X Windows libraries?                   Standard dirs
  Does Emacs use -lXaw3d?                                 no
  Does Emacs use -lXpm?                                   yes
  Does Emacs use -ljpeg?                                  yes
  Does Emacs use -ltiff?                                  yes
  Does Emacs use a gif library?                           yes -lgif
  Does Emacs use -lpng?                                   yes
  Does Emacs use -lrsvg-2?                                yes
  Does Emacs use -lgpm?                                   yes
  Does Emacs use -ldbus?                                  yes
  Does Emacs use -lfreetype?                              yes
  Does Emacs use -lm17n-flt?                              no
  Does Emacs use -lotf?                                   no
  Does Emacs use -lxft?                                   yes
  Does Emacs use toolkit scroll bars?                     no

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#4461: undefined reference to `x_get_resource_string'

[Stefan Monnier]

Thanks for catching it.  Sorry about my over-eagerness to remove code.
Is it fixed now?


        Stefan

bug#4461: marked as done (undefined reference to `x_get_resource_string')

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

Your message dated Fri, 18 Sep 2009 00:19:41 +0300
with message-id <87r5u58ei2.fsf@mail.jurta.org>
and subject line Re: bug#4461: undefined reference to `x_get_resource_string'
has caused the Emacs bug report #4461,
regarding undefined reference to `x_get_resource_string'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4461: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4461
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4886 bytes --]

From: Juri Linkov <juri@jurta.org>
To: bug-gnu-emacs@gnu.org
Subject: undefined reference to `x_get_resource_string'
Date: Thu, 17 Sep 2009 18:19:46 +0300
Message-ID: <87tyz1d63x.fsf@mail.jurta.org>

Without these lines in frame.c:

-char *
-x_get_resource_string (attribute, class)
-     char *attribute, *class;
-{
-  char *name_key;
-  char *class_key;
-  struct frame *sf = SELECTED_FRAME ();
-
-  /* Allocate space for the components, the dots which separate them,
-     and the final '\0'.  */
-  name_key = (char *) alloca (SBYTES (Vinvocation_name)
-			      + strlen (attribute) + 2);
-  class_key = (char *) alloca ((sizeof (EMACS_CLASS) - 1)
-			       + strlen (class) + 2);
-
-  sprintf (name_key, "%s.%s", SDATA (Vinvocation_name), attribute);
-  sprintf (class_key, "%s.%s", EMACS_CLASS, class);
-
-  return x_get_string_resource (FRAME_X_DISPLAY_INFO (sf)->xrdb,
-				name_key, class_key);
-}

compilation fails:

../oldXMenu/libXMenu11.a(Create.o): In function `XMenuCreate':
../oldXMenu/Create.c:244: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:250: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:256: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:263: undefined reference to `x_get_resource_string'
../oldXMenu/Create.c:269: undefined reference to `x_get_resource_string'
../oldXMenu/libXMenu11.a(Create.o):../oldXMenu/Create.c:293: more undefined references to `x_get_resource_string' follow
collect2: ld returned 1 exit status
make[1]: *** [temacs] Error 1

in non-toolkit GNU Emacs 23.1.50 (x86_64-pc-linux-gnu) configured as:

  What operating system and machine description files should Emacs use?
        `s/gnu-linux.h' and `m/amdx86-64.h'
  What compiler should emacs be built with?               gcc -g3 -O0 -Wno-pointer-sign -fno-inline -fno-crossjumping
  What window system should Emacs use?                    x11
  What toolkit should Emacs use?                          none
  Where do we find X Windows header files?                Standard dirs
  Where do we find X Windows libraries?                   Standard dirs
  Does Emacs use -lXaw3d?                                 no
  Does Emacs use -lXpm?                                   yes
  Does Emacs use -ljpeg?                                  yes
  Does Emacs use -ltiff?                                  yes
  Does Emacs use a gif library?                           yes -lgif
  Does Emacs use -lpng?                                   yes
  Does Emacs use -lrsvg-2?                                yes
  Does Emacs use -lgpm?                                   yes
  Does Emacs use -ldbus?                                  yes
  Does Emacs use -lfreetype?                              yes
  Does Emacs use -lm17n-flt?                              no
  Does Emacs use -lotf?                                   no
  Does Emacs use -lxft?                                   yes
  Does Emacs use toolkit scroll bars?                     no

-- 
Juri Linkov
http://www.jurta.org/emacs/



[-- Attachment #3: Type: message/rfc822, Size: 1683 bytes --]

From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 4461-done@emacsbugs.donarmstrong.com
Subject: Re: bug#4461: undefined reference to `x_get_resource_string'
Date: Fri, 18 Sep 2009 00:19:41 +0300
Message-ID: <87r5u58ei2.fsf@mail.jurta.org>

> Thanks for catching it.  Sorry about my over-eagerness to remove code.
> Is it fixed now?

Thanks, it's fixed now.

-- 
Juri Linkov
http://www.jurta.org/emacs/