From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4435: marked as done (move OTHER_FILES definition from cpp to autoconf (only affects NS)) Date: Thu, 17 Sep 2009 06:25:11 +0000 Message-ID: References: <200909170615.n8H6FaUi020695@godzilla.ics.uci.edu> <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1253168711-16189-0" X-Trace: ger.gmane.org 1253168915 7869 80.91.229.12 (17 Sep 2009 06:28:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Sep 2009 06:28:35 +0000 (UTC) To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 17 08:28:28 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MoATj-0004uc-Fs for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 08:28:27 +0200 Original-Received: from localhost ([127.0.0.1]:43953 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoATi-0001wO-SW for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Sep 2009 02:28:26 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MoAST-0001TK-5y for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 02:27:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MoASP-0001Rk-Et for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 02:27:08 -0400 Original-Received: from [199.232.76.173] (port=41163 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MoASO-0001Rf-J8 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 02:27:04 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47283) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MoASN-0004kR-SM for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2009 02:27:04 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8H6R1qD016491; Wed, 16 Sep 2009 23:27:01 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8H6PBEB016265; Wed, 16 Sep 2009 23:25:11 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4435 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31160 Archived-At: This is a multi-part message in MIME format... ------------=_1253168711-16189-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 16 Sep 2009 23:15:36 -0700 (PDT) with message-id <200909170615.n8H6FaUi020695@godzilla.ics.uci.edu> and subject line Re: bug#4435: move OTHER_FILES definition from cpp to auto= conf (only affects NS) has caused the Emacs bug report #4435, regarding move OTHER_FILES definition from cpp to autoconf (only affects NS) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4435: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4435 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1253168711-16189-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 19:31:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,FOURLA,MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EJVYw8030249 for ; Mon, 14 Sep 2009 12:31:36 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnHGw-0006hq-FO for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnHGs-0006gi-Vs for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:34 -0400 Received: from [199.232.76.173] (port=52345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnHGs-0006gf-Ny for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:30 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:47426) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MnHGs-00061f-3d for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:30 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8EJTq6D009712 for ; Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8EJTqap023924; Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Date: Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Message-Id: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: move OTHER_FILES definition from cpp to autoconf (only affects NS) X-Debbugs-No-Ack: yes Lines: 69 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8EJTq6D009712 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) This patch moves OTHER_FILES definition from cpp to autoconf, it only affects NS. [configure and src/config.in need to regenerated] OK to check in? Index: configure.in =================================================================== RCS file: /cvsroot/emacs/emacs/configure.in,v retrieving revision 1.607 diff -u -3 -p -u -p -r1.607 configure.in --- configure.in 23 Aug 2009 02:15:00 -0000 1.607 +++ configure.in 14 Sep 2009 18:46:36 -0000 @@ -2188,6 +2201,7 @@ if test "${HAVE_NS}" = "yes"; then fi # We also have mouse menus. HAVE_MENUS=yes + OTHER_FILES=ns-app fi @@ -2598,6 +2612,7 @@ AC_SUBST(GNUSTEP_SYSTEM_HEADERS) AC_SUBST(GNUSTEP_SYSTEM_LIBRARIES) AC_SUBST(GNU_OBJC_CFLAGS) AC_SUBST(LIB_SRC_EXTRA_INSTALLABLES) +AC_SUBST(OTHER_FILES) AC_DEFINE_UNQUOTED(EMACS_CONFIGURATION, "${canonical}", [Define to the canonical Emacs configuration name.]) @@ -2744,7 +2759,6 @@ AH_BOTTOM([ side does this in s/darwin.h and we cannot parallel this exactly since GNUstep is multi-OS. */ #ifdef HAVE_NS -#define OTHER_FILES ns-app # ifdef NS_IMPL_GNUSTEP /* See also .m.o rule in Makefile.in */ /* FIXME: are all these flags really needed? Document here why. */ Index: Makefile.in =================================================================== RCS file: /cvsroot/emacs/emacs/src/Makefile.in,v retrieving revision 1.446 diff -u -3 -p -u -p -r1.446 Makefile.in --- Makefile.in 26 Aug 2009 08:28:25 -0000 1.446 +++ Makefile.in 14 Sep 2009 19:27:36 -0000 @@ -886,9 +886,3 @@ LIBES = $(LOADLIBES) $(LIBS) $(LIBX) $(L @FREETYPE_LIBS@ @FONTCONFIG_LIBS@ @LIBOTF_LIBS@ @M17N_FLT_LIBS@ \ $(GNULIB_VAR) LIB_MATH LIB_STANDARD $(GNULIB_VAR) -/* Enable recompilation of certain other files depending on system type. */ - -#ifndef OTHER_FILES -#define OTHER_FILES -#endif - @@ -898,11 +889,10 @@ - #ifdef HAVE_SHM RUN_TEMACS = `/bin/pwd`/temacs -nl #else RUN_TEMACS = `/bin/pwd`/temacs #endif -all: emacs${EXEEXT} OTHER_FILES +all: emacs${EXEEXT} @OTHER_FILES@ emacs${EXEEXT}: temacs${EXEEXT} ${etc}DOC ${lisp} ${SOME_MACHINE_LISP} #ifdef CANNOT_DUMP ------------=_1253168711-16189-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4435-done) by emacsbugs.donarmstrong.com; 17 Sep 2009 06:15:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8H6Fneb014910 for <4435-done@emacsbugs.donarmstrong.com>; Wed, 16 Sep 2009 23:15:50 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8H6FbUD002608; Wed, 16 Sep 2009 23:15:37 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8H6FaUi020695; Wed, 16 Sep 2009 23:15:36 -0700 (PDT) Date: Wed, 16 Sep 2009 23:15:36 -0700 (PDT) Message-Id: <200909170615.n8H6FaUi020695@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4435-done@emacsbugs.donarmstrong.com Subject: Re: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) References: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Mon, 14 Sep 2009 18:01:28 -0400") Lines: 10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8H6FbUD002608 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > This patch moves OTHER_FILES definition from cpp to autoconf, it only > > affects NS. [configure and src/config.in need to regenerated] > > > OK to check in? > > Yes, please, thank you. Thanks. Done. ------------=_1253168711-16189-0--