From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4393: marked as done (23.1; doc string of accessible-keymaps) Date: Fri, 11 Sep 2009 19:30:04 +0000 Message-ID: References: <5AEE0882D73D443C9293E91EDEB9C00B@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1252697404-11422-0" X-Trace: ger.gmane.org 1252698443 26340 80.91.229.12 (11 Sep 2009 19:47:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Sep 2009 19:47:23 +0000 (UTC) To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 11 21:47:16 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MmC5T-00073v-QG for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Sep 2009 21:47:16 +0200 Original-Received: from localhost ([127.0.0.1]:42904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmC5S-0006GS-MZ for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Sep 2009 15:47:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MmC5L-0006AZ-D5 for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 15:47:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MmC5G-00062s-Fz for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 15:47:07 -0400 Original-Received: from [199.232.76.173] (port=47217 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmC5G-00062p-9i for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 15:47:02 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43520) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MmC5F-0001DI-MV for bug-gnu-emacs@gnu.org; Fri, 11 Sep 2009 15:47:02 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8BJkx82014188; Fri, 11 Sep 2009 12:46:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8BJU4NN011443; Fri, 11 Sep 2009 12:30:04 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4393 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30970 Archived-At: This is a multi-part message in MIME format... ------------=_1252697404-11422-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 11 Sep 2009 15:21:35 -0400 with message-id and subject line Re: bug#4393: 23.1; doc string of accessible-keymaps has caused the Emacs bug report #4393, regarding 23.1; doc string of accessible-keymaps to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4393: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4393 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1252697404-11422-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 10 Sep 2009 23:31:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8ANVVJ7024590 for ; Thu, 10 Sep 2009 16:31:32 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mlt6x-0003i3-5o for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 19:31:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mlt6q-0003hX-CL for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 19:31:30 -0400 Received: from [199.232.76.173] (port=45083 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mlt6q-0003hU-8E for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 19:31:24 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:44623) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mlt6p-0002qY-P1 for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 19:31:24 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8ANUaqo000361 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 10 Sep 2009 23:30:37 GMT Received: from abhmt006.oracle.com (abhmt006.oracle.com [141.146.116.15]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n8ANVUml028333 for ; Thu, 10 Sep 2009 23:31:30 GMT Received: from dradamslap1 (/141.144.80.125) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 10 Sep 2009 16:31:16 -0700 From: "Drew Adams" To: Subject: 23.1; doc string of accessible-keymaps Date: Thu, 10 Sep 2009 16:31:14 -0700 Message-ID: <5AEE0882D73D443C9293E91EDEB9C00B@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Acoybsnmcb/jjwf1Qy+ebVp1187Cuw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt006.oracle.com [141.146.116.15] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4AA98C45.00EE:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q In *scratch* type this: (accessible-keymaps (current-global-map)) Put point after the sexp, and do `C-u C-x C-e'. You get the eval result inserted just after the sexp. The result has a mouse-face property (highlight). Put point at the beginning of the result (just after the initial sexp). Hit RET - the display of the result changes between full and abbreviated. An aside: it took me a while to figure out what was happening, and why RET didn't insert a newline here. (You can't use C-j to insert a newline in *scratch*, so I'm in the habit of hitting RET.) I wonder if something shouldn't be added to the doc for C-x C-e about this. There is nothing that prepares the user for the effect (highlighted sexp, hijacked mouse-2 behavior, so you can no longer yank into the sexp, hijacked RET behavior, so you cannot shorten lines, etc.). And there should be some explanation of how to turn OFF this wonderful highlighting and RET/mouse-2 behavior. Since it seems to be C-x C-e that has this effect, it is the doc of C-x C-e that should cover this. Anyway, on to the bug... Search for [f2] in the result sexp. You'll find this: ([f2] . t). That's one of the entries in the alist returned by `accessible-keymaps'. There are two other entries with cdr = t: ([24 11] . t) and ([24 54] . t). All the other entries have a keymap as cdr. However, the doc string of `accessible-keymaps' says this: "Returns a list of elements of the form (KEYS . MAP), where the sequence KEYS starting from keymap gets you to MAP." You'll note that it doesn't tell you what MAP is. But you could presume that MAP would be a keymap, since the doc string also says, "Find all keymaps accessible...". However, (keymapp t) returns nil; `t' is not a keymap. The doc needs to make clear what MAP is. In particular, it needs to explain that it is not necessarily a keymap. It should perhaps explain what `t' means as a value for MAP, or at least point you to the manual section that explains it (which section is it?). I searched the Elisp manual for some possibility of a keymap being just `t', but I didn't find anything related to this. The manual says clearly that a keymap is a cons whose car is `keymap' and whose cdr... `t' is not a cons with car `keymap'. The doc for `keymapp' says, similarly, that a keymap must be a cons with car `keymap'. So at a minimum there is a doc bug here (for `accessible-keymaps', at least). I wonder too if there isn't a code bug - is it correct for the MAP of an entry to be `t'? In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1252697404-11422-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4393-done) by emacsbugs.donarmstrong.com; 11 Sep 2009 19:21:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from tomts10-srv.bellnexxia.net (tomts10.bellnexxia.net [209.226.175.54]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8BJLaqX010183 for <4393-done@emacsbugs.donarmstrong.com>; Fri, 11 Sep 2009 12:21:38 -0700 Received: from toip7.srvr.bell.ca ([209.226.175.124]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20090911192136.YTVB12711.tomts10-srv.bellnexxia.net@toip7.srvr.bell.ca> for <4393-done@emacsbugs.donarmstrong.com>; Fri, 11 Sep 2009 15:21:36 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgwFAJw6qkpGN458/2dsb2JhbACBU9wLhBgF Received: from bas1-montreal42-1178046076.dsl.bell.ca (HELO ceviche.home) ([70.55.142.124]) by toip7.srvr.bell.ca with ESMTP; 11 Sep 2009 15:24:48 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 15084B40D4; Fri, 11 Sep 2009 15:21:36 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#4393: 23.1; doc string of accessible-keymaps Message-ID: References: <5AEE0882D73D443C9293E91EDEB9C00B@us.oracle.com> Date: Fri, 11 Sep 2009 15:21:35 -0400 In-Reply-To: (Drew Adams's message of "Fri, 11 Sep 2009 07:23:53 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii >> > (accessible-keymaps (current-global-map)) >> [...] >> > Search for [f2] in the result sexp. You'll find this: >> > ([f2] . t). That's one of the entries in the alist returned by >> > `accessible-keymaps'. >> > There are two other entries with cdr = t: ([24 11] . t) and >> > ([24 54] . t). All the other entries have a keymap as cdr. >> >> It turns out that these are prefixes bound to autoloaded keymaps that >> haven't yet been loaded (and they also happen to be the same keymap). >> `accessible-keymaps' does not autoload keymaps. I guess it should >> return ([f2] . 2C-command) and ([24 54] . 2C-command). > OK, so if I understand right, this is not a lack of explanation in the doc of > accessible-keymaps, but is a code bug that will be fixed. Actually, I believe I fixed it yesterday with the below, Stefan Index: src/keymap.c =================================================================== RCS file: /sources/emacs/emacs/src/keymap.c,v retrieving revision 1.384 retrieving revision 1.385 diff -u -r1.384 -r1.385 --- src/keymap.c 11 Sep 2009 00:59:05 -0000 1.384 +++ src/keymap.c 11 Sep 2009 02:14:07 -0000 1.385 @@ -292,7 +292,7 @@ goto autoload_retry; } else - return Qt; + return object; } } } ------------=_1252697404-11422-0--