From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4354: marked as done (23.0.60; delphi-mode: TAB should indent region in Transient Mark mode (with patch)) Date: Fri, 11 Sep 2009 02:50:04 +0000 Message-ID: References: <1252636926.4395.6.camel@hamlet.localdomain> <87pra4lngz.fsf@hamlet.localdomain> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1252637404-28322-0" X-Trace: ger.gmane.org 1252638441 14145 80.91.229.12 (11 Sep 2009 03:07:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 11 Sep 2009 03:07:21 +0000 (UTC) To: Simon South Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 11 05:07:14 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MlwTh-00053o-VO for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Sep 2009 05:07:14 +0200 Original-Received: from localhost ([127.0.0.1]:60072 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlwTh-0003dz-4u for geb-bug-gnu-emacs@m.gmane.org; Thu, 10 Sep 2009 23:07:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MlwTb-0003bh-9e for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 23:07:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MlwTW-0003UT-F4 for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 23:07:06 -0400 Original-Received: from [199.232.76.173] (port=49142 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MlwTW-0003UI-7Z for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 23:07:02 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46730) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MlwTV-0008Hj-Jn for bug-gnu-emacs@gnu.org; Thu, 10 Sep 2009 23:07:01 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8B36xOw032132; Thu, 10 Sep 2009 20:06:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8B2o4A4028346; Thu, 10 Sep 2009 19:50:04 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4354 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30944 Archived-At: This is a multi-part message in MIME format... ------------=_1252637404-28322-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 10 Sep 2009 22:42:06 -0400 with message-id <1252636926.4395.6.camel@hamlet.localdomain> and subject line Re: bug#4354: Acknowledgement (23.0.60; delphi-mode: TAB s= hould indent region in Transient Mark mode (with patch)) has caused the Emacs bug report #4354, regarding 23.0.60; delphi-mode: TAB should indent region in Transient Mark = mode (with patch) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4354: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4354 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1252637404-28322-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 6 Sep 2009 04:13:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n864Dh9T011309 for ; Sat, 5 Sep 2009 21:13:44 -0700 Received: from mx10.gnu.org ([199.232.76.166]:49648) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Mk98I-0001tq-If for emacs-pretest-bug@gnu.org; Sun, 06 Sep 2009 00:13:42 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Mk98G-000178-6z for emacs-pretest-bug@gnu.org; Sun, 06 Sep 2009 00:13:42 -0400 Received: from caiajhbdccah.dreamhost.com ([208.97.132.207]:54983 helo=postalmail-a6.g.dreamhost.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mk98F-00015s-GB for emacs-pretest-bug@gnu.org; Sun, 06 Sep 2009 00:13:39 -0400 Received: from hamlet.localdomain.slowcomputing.org (CPE0019b90fad23-CM00407b87aa6e.cpe.net.cable.rogers.com [99.238.107.135]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by postalmail-a6.g.dreamhost.com (Postfix) with ESMTP id 84283887A4 for ; Sat, 5 Sep 2009 21:13:36 -0700 (PDT) Date: Sun, 06 Sep 2009 00:13:32 -0400 Message-Id: <87pra4lngz.fsf@hamlet.localdomain> From: Simon South To: emacs-pretest-bug@gnu.org Subject: 23.0.60; delphi-mode: TAB should indent region in Transient Mark mode (with patch) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) The patch below makes delphi-mode indent the region when the TAB key is pressed, whenever Transient Mark mode is enabled and the region is active. (This became standard behaviour with Emacs 23.1 but wasn't automatically reflected by delphi-mode as it defines its own TAB-key binding.) I've tested this with different combinations of transient-mark-mode, delphi-tab-always-indents and delphi-newline-always-indents and it appears to work fine. Changes: (delphi-tab): Indent region when Transient Mark mode is enabled and region is active; otherwise indent or insert TAB as usual. (delphi-mode): Update description of TAB-key binding. Index: lisp/progmodes/delphi.el =================================================================== RCS file: /sources/emacs/emacs/lisp/progmodes/delphi.el,v retrieving revision 3.33 diff -c -r3.33 delphi.el *** lisp/progmodes/delphi.el 5 Jan 2009 03:23:27 -0000 3.33 --- lisp/progmodes/delphi.el 6 Sep 2009 03:33:09 -0000 *************** *** 1652,1665 **** (defun delphi-tab () ! "Indent the current line or insert a TAB, depending on the value of ! `delphi-tab-always-indents' and the current line position." (interactive) ! (if (or delphi-tab-always-indents ; We are always indenting ! ;; Or we are before the first non-space character on the line. ! (save-excursion (skip-chars-backward delphi-space-chars) (bolp))) ! (delphi-indent-line) ! (insert "\t"))) (defun delphi-is-directory (path) --- 1652,1674 ---- (defun delphi-tab () ! "Indent the region, when Transient Mark mode is enabled and the region is ! active. Otherwise, indent the current line or insert a TAB, depending on the ! value of `delphi-tab-always-indents' and the current line position." (interactive) ! (cond ((use-region-p) ! ;; If Transient Mark mode is enabled and the region is active, indent ! ;; the entire region. ! (indent-region (region-beginning) (region-end))) ! ((or delphi-tab-always-indents ! (save-excursion (skip-chars-backward delphi-space-chars) (bolp))) ! ;; Otherwise, if we are configured always to indent (regardless of the ! ;; point's position in the line) or we are before the first non-space ! ;; character on the line, indent the line. ! (delphi-indent-line)) ! (t ! ;; Otherwise, insert a tab character. ! (insert "\t")))) (defun delphi-is-directory (path) *************** *** 1935,1941 **** ;;;###autoload (defun delphi-mode (&optional skip-initial-parsing) "Major mode for editing Delphi code. \\ ! \\[delphi-tab]\t- Indents the current line for Delphi code. \\[delphi-find-unit]\t- Search for a Delphi source file. \\[delphi-fill-comment]\t- Fill the current comment. \\[delphi-new-comment-line]\t- If in a // comment, do a new comment line. --- 1944,1951 ---- ;;;###autoload (defun delphi-mode (&optional skip-initial-parsing) "Major mode for editing Delphi code. \\ ! \\[delphi-tab]\t- Indents the current line (or region, if Transient Mark mode ! \t is enabled and the region is active) of Delphi code. \\[delphi-find-unit]\t- Search for a Delphi source file. \\[delphi-fill-comment]\t- Fill the current comment. \\[delphi-new-comment-line]\t- If in a // comment, do a new comment line. ------------=_1252637404-28322-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4354-done) by emacsbugs.donarmstrong.com; 11 Sep 2009 02:42:10 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.5 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from postalmail-a6.g.dreamhost.com (caiajhbdcaib.dreamhost.com [208.97.132.81]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8B2g8IC026864 for <4354-done@emacsbugs.donarmstrong.com>; Thu, 10 Sep 2009 19:42:09 -0700 Received: from [192.168.1.101] (CPE0019b90fad23-CM00407b87aa6e.cpe.net.cable.rogers.com [99.238.107.135]) by postalmail-a6.g.dreamhost.com (Postfix) with ESMTP id 11EBE887B9 for <4354-done@emacsbugs.donarmstrong.com>; Thu, 10 Sep 2009 19:42:07 -0700 (PDT) Subject: Re: bug#4354: Acknowledgement (23.0.60; delphi-mode: TAB should indent region in Transient Mark mode (with patch)) From: Simon South To: 4354-done@emacsbugs.donarmstrong.com In-Reply-To: References: <87pra4lngz.fsf@hamlet.localdomain> Content-Type: text/plain Date: Thu, 10 Sep 2009 22:42:06 -0400 Message-Id: <1252636926.4395.6.camel@hamlet.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 Content-Transfer-Encoding: 7bit Checked in (revision 3.34). ------------=_1252637404-28322-0--