From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4308: marked as done (23.1.50; patch: fix `eshell-history-file-name') Date: Sun, 13 Sep 2009 02:25:04 +0000 Message-ID: References: <87pr9vbnao.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1252808704-6296-0" X-Trace: ger.gmane.org 1252808852 8952 80.91.229.12 (13 Sep 2009 02:27:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 13 Sep 2009 02:27:32 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Sep 13 04:27:25 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MmeoG-0004ME-JX for geb-bug-gnu-emacs@m.gmane.org; Sun, 13 Sep 2009 04:27:25 +0200 Original-Received: from localhost ([127.0.0.1]:56992 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MmeoF-00041b-Tn for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Sep 2009 22:27:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mmeo0-0003x5-2t for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2009 22:27:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mmenu-0003vs-M7 for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2009 22:27:06 -0400 Original-Received: from [199.232.76.173] (port=52947 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mmenu-0003vn-HU for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2009 22:27:02 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37736) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mment-0005HU-Vq for bug-gnu-emacs@gnu.org; Sat, 12 Sep 2009 22:27:02 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8D2QxQj006622; Sat, 12 Sep 2009 19:26:59 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8D2P4XM006325; Sat, 12 Sep 2009 19:25:04 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4308 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31029 Archived-At: This is a multi-part message in MIME format... ------------=_1252808704-6296-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 12 Sep 2009 22:17:51 -0400 with message-id <87pr9vbnao.fsf@cyd.mit.edu> and subject line Re: bug#4308: 23.1.50; patch: fix `eshell-history-file-nam= e' has caused the Emacs bug report #4308, regarding 23.1.50; patch: fix `eshell-history-file-name' to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4308: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4308 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1252808704-6296-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 1 Sep 2009 19:35:46 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81JZiYO001874 for ; Tue, 1 Sep 2009 12:35:46 -0700 Received: from mail.gnu.org ([199.232.76.166]:39032 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MiZ8q-0003KD-3h for emacs-pretest-bug@gnu.org; Tue, 01 Sep 2009 15:35:44 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MiZ5U-0007ph-8Z for emacs-pretest-bug@gnu.org; Tue, 01 Sep 2009 15:32:19 -0400 Received: from ppsw-1.csi.cam.ac.uk ([131.111.8.131]:42519) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MiZ5T-0007pP-Tx for emacs-pretest-bug@gnu.org; Tue, 01 Sep 2009 15:32:16 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from sl392.st-edmunds.cam.ac.uk ([131.111.223.202]:49463 helo=victoria.local) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MiZ5S-0002gX-3j (Exim 4.70) for emacs-pretest-bug@gnu.org (return-path ); Tue, 01 Sep 2009 20:32:14 +0100 From: Leo To: emacs-pretest-bug@gnu.org Subject: 23.1.50; patch: fix `eshell-history-file-name' Date: Tue, 01 Sep 2009 20:32:10 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: "Leo, Shidai Liu" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Please describe exactly what actions triggered the bug and the precise symptoms of the bug: The attached small patch makes eshell-history-file-name more robust. For example, I accidentally set eshell-directory-name to ~/.emacs.d/shell without a trailing / and the history was written to ~/.emacs.d/shellhistory. diff -u -L a/em-hist.el.gz -L b/em-hist.el.gz --- a/em-hist.el.gz +++ b/em-hist.el.gz @@ -86,7 +86,7 @@ :group 'eshell-hist) (defcustom eshell-history-file-name - (concat eshell-directory-name "history") + (expand-file-name "history" eshell-directory-name) "*If non-nil, name of the file to read/write input history. See also `eshell-read-history' and `eshell-write-history'. If it is nil, Eshell will use the value of HISTFILE." Diff finished. Tue Sep 1 20:27:29 2009 Leo ------------=_1252808704-6296-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4308-done) by emacsbugs.donarmstrong.com; 13 Sep 2009 02:16:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8D2GPx2005291 for <4308-done@emacsbugs.donarmstrong.com>; Sat, 12 Sep 2009 19:16:26 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 3C0C657E259; Sat, 12 Sep 2009 22:17:51 -0400 (EDT) From: Chong Yidong To: Leo Cc: 4308-done@emacsbugs.donarmstrong.com Subject: Re: bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Date: Sat, 12 Sep 2009 22:17:51 -0400 Message-ID: <87pr9vbnao.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > > The attached small patch makes eshell-history-file-name more > > robust. For > > example, I accidentally set eshell-directory-name to ~/.emacs.d/shell > > without a trailing / and the history was written to > > ~/.emacs.d/shellhistory. > Please also fix the following places: All fixed, thanks. ------------=_1252808704-6296-0--