From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4230: marked as done (23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate) Date: Mon, 05 Oct 2009 02:45:06 +0000 Message-ID: References: <87k4zamumt.fsf@red-bean.com> <95DE0F7C73CE4F63AAE1BEA19D46D5AA@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1254710706-18369-0" X-Trace: ger.gmane.org 1254710849 19881 80.91.229.12 (5 Oct 2009 02:47:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Oct 2009 02:47:29 +0000 (UTC) To: Karl Fogel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 05 04:47:23 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mudbe-0008RE-LO for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Oct 2009 04:47:23 +0200 Original-Received: from localhost ([127.0.0.1]:44368 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mudbe-00011Y-C2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Oct 2009 22:47:22 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MudbY-00010S-RU for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 22:47:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MudbT-00010G-7E for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 22:47:15 -0400 Original-Received: from [199.232.76.173] (port=52981 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MudbT-00010D-1r for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 22:47:11 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:45827) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MudbS-00065z-DR for bug-gnu-emacs@gnu.org; Sun, 04 Oct 2009 22:47:10 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n952l8HI018965; Sun, 4 Oct 2009 19:47:08 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n952j6mg018444; Sun, 4 Oct 2009 19:45:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4230 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31686 Archived-At: This is a multi-part message in MIME format... ------------=_1254710706-18369-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sun, 04 Oct 2009 22:39:38 -0400 with message-id <87k4zamumt.fsf@red-bean.com> and subject line Fixed "bookmark-handle-bookmark: bind `use-file-dialog' to= nil to relocate" has caused the Emacs bug report #4230, regarding 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to = relocate to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4230: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4230 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1254710706-18369-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 21 Aug 2009 22:45:34 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.5 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7LMjWLA009404 for ; Fri, 21 Aug 2009 15:45:33 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MecrT-0008MW-Ss for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:45:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MecrP-0008Li-F0 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:45:31 -0400 Received: from [199.232.76.173] (port=43246 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MecrP-0008Lb-6p for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:45:27 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:29562) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MecrO-0007jO-MF for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 18:45:26 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7LMin6Y002333 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Aug 2009 22:44:52 GMT Received: from abhmt007.oracle.com (abhmt007.oracle.com [141.146.116.16]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n7LMjKp4025925 for ; Fri, 21 Aug 2009 22:45:20 GMT Received: from dradamslap1 (/141.144.245.31) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 21 Aug 2009 15:45:19 -0700 From: "Drew Adams" To: Subject: 23.1; bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate Date: Fri, 21 Aug 2009 15:45:19 -0700 Message-ID: <95DE0F7C73CE4F63AAE1BEA19D46D5AA@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcoisQ84xykRKKCjS/SbkSnnoRMBXw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: abhmt007.oracle.com [141.146.116.16] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4A8F2380.00EA:SCFSTAT5015188,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) >From the definition of bookmark-handle-bookmark: (let ((file (bookmark-get-filename bookmark))) (when file ;Don't know how to relocate if there's no `file'. (setq file (expand-file-name file)) (ding) (if (y-or-n-p (concat (file-name-nondirectory file) " nonexistent. Relocate \"" bookmark "\"? ")) ... A bookmark can be to a directory or a file. AFAICT, at least on Windows, you cannot choose a directory using a file selection box - it insists on a file. Or perhaps there is another kind of file selection box that allows this, but it is not being used by Emacs. So `use-file-dialog' should be bound to nil around the call to `y-or-n-p'. I had a bookmark to a directory that needed to be relocated. I tried to jump to the bookmark by clicking it with the mouse in the list from `C-x r l'. Because I used the mouse, I got the file dialog box. I could not find a way to specify a new directory - choosing a directory just opens the dialog box to the files in the directory, waiting for you to pick one. In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600) of 2009-07-29 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4)' ------------=_1254710706-18369-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4230-close) by emacsbugs.donarmstrong.com; 5 Oct 2009 02:39:40 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sanpietro.red-bean.com (Debian-exim@sanpietro.red-bean.com [66.146.206.141]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n952dd1C017563 for <4230-close@emacsbugs.donarmstrong.com>; Sun, 4 Oct 2009 19:39:40 -0700 Received: from localhost ([127.0.0.1]:57342 helo=floss ident=kfogel) by sanpietro.red-bean.com with esmtp (Exim 4.69) (envelope-from ) id 1MudUA-0008Nc-R6 for 4230-close@emacsbugs.donarmstrong.com; Sun, 04 Oct 2009 21:39:38 -0500 From: Karl Fogel To: 4230-close@emacsbugs.donarmstrong.com Subject: Fixed "bookmark-handle-bookmark: bind `use-file-dialog' to nil to relocate" Reply-To: Karl Fogel Date: Sun, 04 Oct 2009 22:39:38 -0400 Message-ID: <87k4zamumt.fsf@red-bean.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii fixed -- Thanks for the report. Fix committed; please test this, as I do not have a Windows system myself to test it on. $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog /sources/emacs/emacs/lisp/bookmark.el,v <-- lisp/bookmark.el new revision: 1.130; previous revision: 1.129 /sources/emacs/emacs/lisp/ChangeLog,v <-- lisp/ChangeLog new revision: 1.16356; previous revision: 1.16355 Mailing notification to emacs-diffs@gnu.org... sent. $ ------------=_1254710706-18369-0--