* bug#4217: 23.1; probable mode-line bug @ 2009-08-20 22:30 ` Eli Barzilay 2009-08-25 3:08 ` Glenn Morris 2009-08-26 3:05 ` bug#4217: marked as done (23.1; probable mode-line bug) Emacs bug Tracking System 0 siblings, 2 replies; 6+ messages in thread From: Eli Barzilay @ 2009-08-20 22:30 UTC (permalink / raw) To: bug-gnu-emacs In this bit in "bindings.el" from the code that sets the modeline format: `(which-func-mode ("" which-func-format ,dashes)) `(global-mode-string (,dashes global-mode-string)) it looks like there is a typo, and the first line should also have the dashes before the format string. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4217: 23.1; probable mode-line bug 2009-08-20 22:30 ` bug#4217: 23.1; probable mode-line bug Eli Barzilay @ 2009-08-25 3:08 ` Glenn Morris 2009-08-25 3:47 ` Eli Barzilay 2009-08-26 3:05 ` bug#4217: marked as done (23.1; probable mode-line bug) Emacs bug Tracking System 1 sibling, 1 reply; 6+ messages in thread From: Glenn Morris @ 2009-08-25 3:08 UTC (permalink / raw) To: Eli Barzilay; +Cc: 4217 Eli Barzilay wrote: > In this bit in "bindings.el" from the code that sets the modeline > format: > > `(which-func-mode ("" which-func-format ,dashes)) > `(global-mode-string (,dashes global-mode-string)) > > it looks like there is a typo, and the first line should also have the > dashes before the format string. The following makes more sense to me. OK? *************** *** 356,362 **** (propertize " " 'help-echo help-echo) 'mode-line-modes `(which-func-mode ("" which-func-format ,dashes)) ! `(global-mode-string (,dashes global-mode-string)) (propertize "-%-" 'help-echo help-echo))) (standard-mode-line-modes (list --- 364,370 ---- (propertize " " 'help-echo help-echo) 'mode-line-modes `(which-func-mode ("" which-func-format ,dashes)) ! `(global-mode-string ("" global-mode-string ,dashes)) (propertize "-%-" 'help-echo help-echo))) (standard-mode-line-modes (list ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4217: 23.1; probable mode-line bug 2009-08-25 3:08 ` Glenn Morris @ 2009-08-25 3:47 ` Eli Barzilay 2009-08-25 17:08 ` Glenn Morris 0 siblings, 1 reply; 6+ messages in thread From: Eli Barzilay @ 2009-08-25 3:47 UTC (permalink / raw) To: Glenn Morris; +Cc: 4217 On Aug 24, Glenn Morris wrote: > Eli Barzilay wrote: > > > In this bit in "bindings.el" from the code that sets the modeline > > format: > > > > `(which-func-mode ("" which-func-format ,dashes)) > > `(global-mode-string (,dashes global-mode-string)) > > > > it looks like there is a typo, and the first line should also have the > > dashes before the format string. > > The following makes more sense to me. OK? I thought that having them at the front makes more sense -- due to the following "-%-". > *************** > *** 356,362 **** > (propertize " " 'help-echo help-echo) > 'mode-line-modes > `(which-func-mode ("" which-func-format ,dashes)) > ! `(global-mode-string (,dashes global-mode-string)) > (propertize "-%-" 'help-echo help-echo))) > (standard-mode-line-modes > (list > --- 364,370 ---- > (propertize " " 'help-echo help-echo) > 'mode-line-modes > `(which-func-mode ("" which-func-format ,dashes)) > ! `(global-mode-string ("" global-mode-string ,dashes)) > (propertize "-%-" 'help-echo help-echo))) > (standard-mode-line-modes > (list -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4217: 23.1; probable mode-line bug 2009-08-25 3:47 ` Eli Barzilay @ 2009-08-25 17:08 ` Glenn Morris 2009-08-25 17:29 ` Eli Barzilay 0 siblings, 1 reply; 6+ messages in thread From: Glenn Morris @ 2009-08-25 17:08 UTC (permalink / raw) To: Eli Barzilay; +Cc: 4217 Eli Barzilay wrote: > I thought that having them at the front makes more sense -- due to the > following "-%-". I assumed the actual problem you wanted to report was that in: emacs -Q -f which-func-mode --eval '(setq global-mode-string "foo")' lisp/startup.el there are 4 "-" characters between which-func's '[...]' and the global-mode-string. Since mode-line-modes already ends in "--", moving the dashes to the front of which-func will just shift the 4 "-" around rather than reducing them to 2. Although the "--" at the end of the global-mode-string entry are not necessary (being followed by -%-), I think it makes sense to have all the entries be the same, so that entries can be removed/added/reordered easily. ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4217: 23.1; probable mode-line bug 2009-08-25 17:08 ` Glenn Morris @ 2009-08-25 17:29 ` Eli Barzilay 0 siblings, 0 replies; 6+ messages in thread From: Eli Barzilay @ 2009-08-25 17:29 UTC (permalink / raw) To: Glenn Morris; +Cc: 4217 On Aug 25, Glenn Morris wrote: > Eli Barzilay wrote: > > > I thought that having them at the front makes more sense -- due to the > > following "-%-". > > I assumed the actual problem you wanted to report was that in: > > emacs -Q -f which-func-mode --eval '(setq global-mode-string "foo")' lisp/startup.el > > there are 4 "-" characters between which-func's '[...]' and the > global-mode-string. Yes, that's the result of the bad placement of dashes. > Since mode-line-modes already ends in "--", moving the dashes to the > front of which-func will just shift the 4 "-" around rather than > reducing them to 2. I missed this, mostly because I just looked at the code that *looked* like it has a problem. Anyway, in this case the obvious solution is to remove the last two dashes from `mode-line-modes'. This means that the relevant code: (propertize " " 'help-echo help-echo) 'mode-line-modes `(which-func-mode ("" which-func-format ,dashes)) `(global-mode-string (,dashes global-mode-string)) (propertize "-%-" 'help-echo help-echo) works fine in all cases. > Although the "--" at the end of the global-mode-string entry are not > necessary (being followed by -%-), I think it makes sense to have > all the entries be the same, so that entries can be > removed/added/reordered easily. Yes, having all entries be the same is definitely the answer -- but this should apply to everything except for the first or the last in the chain (depending on using the dashes before/after), and moving the dashes to the front and making `mode-line-modes' not end with dashes seems to me as a better choice. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! ^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#4217: marked as done (23.1; probable mode-line bug) 2009-08-20 22:30 ` bug#4217: 23.1; probable mode-line bug Eli Barzilay 2009-08-25 3:08 ` Glenn Morris @ 2009-08-26 3:05 ` Emacs bug Tracking System 1 sibling, 0 replies; 6+ messages in thread From: Emacs bug Tracking System @ 2009-08-26 3:05 UTC (permalink / raw) To: Glenn Morris [-- Attachment #1: Type: text/plain, Size: 856 bytes --] Your message dated Tue, 25 Aug 2009 22:59:34 -0400 with message-id <7py6p7uvop.fsf@fencepost.gnu.org> and subject line Re: bug#4217: 23.1; probable mode-line bug has caused the Emacs bug report #4217, regarding 23.1; probable mode-line bug to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) -- 4217: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4217 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems [-- Attachment #2: Type: message/rfc822, Size: 2557 bytes --] From: Eli Barzilay <eli@barzilay.org> To: bug-gnu-emacs@gnu.org Subject: 23.1; probable mode-line bug Date: Thu, 20 Aug 2009 18:30:55 -0400 Message-ID: <E1MeG9n-0002SM-1l@barzilay.org> In this bit in "bindings.el" from the code that sets the modeline format: `(which-func-mode ("" which-func-format ,dashes)) `(global-mode-string (,dashes global-mode-string)) it looks like there is a typo, and the first line should also have the dashes before the format string. -- ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay: http://barzilay.org/ Maze is Life! [-- Attachment #3: Type: message/rfc822, Size: 1909 bytes --] From: Glenn Morris <rgm@gnu.org> To: 4217-done@emacsbugs.donarmstrong.com Subject: Re: bug#4217: 23.1; probable mode-line bug Date: Tue, 25 Aug 2009 22:59:34 -0400 Message-ID: <7py6p7uvop.fsf@fencepost.gnu.org> >> Although the "--" at the end of the global-mode-string entry are not >> necessary (being followed by -%-), I think it makes sense to have >> all the entries be the same, so that entries can be >> removed/added/reordered easily. This still makes sense to me, so that's what I installed. The appearance of the end result is the same. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-08-26 3:05 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <7py6p7uvop.fsf@fencepost.gnu.org> 2009-08-20 22:30 ` bug#4217: 23.1; probable mode-line bug Eli Barzilay 2009-08-25 3:08 ` Glenn Morris 2009-08-25 3:47 ` Eli Barzilay 2009-08-25 17:08 ` Glenn Morris 2009-08-25 17:29 ` Eli Barzilay 2009-08-26 3:05 ` bug#4217: marked as done (23.1; probable mode-line bug) Emacs bug Tracking System
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.