From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4201: marked as done (23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)) Date: Fri, 21 Aug 2009 09:00:06 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1250845206-21766-2" X-Trace: ger.gmane.org 1250845723 10799 80.91.229.12 (21 Aug 2009 09:08:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Aug 2009 09:08:43 +0000 (UTC) To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 21 11:08:35 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeQ6s-0002QO-Kx for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2009 11:08:35 +0200 Original-Received: from localhost ([127.0.0.1]:37152 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeQ6s-0003KD-1q for geb-bug-gnu-emacs@m.gmane.org; Fri, 21 Aug 2009 05:08:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeQ5O-0002HP-0l for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 05:07:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeQ5J-0002EP-DI for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 05:07:01 -0400 Original-Received: from [199.232.76.173] (port=60553 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeQ5I-0002Dx-J1 for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 05:06:56 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43855) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MeQ5H-0005pT-Ne for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2009 05:06:56 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L96peS023719; Fri, 21 Aug 2009 02:06:52 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7L906lb021834; Fri, 21 Aug 2009 02:00:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4201 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30416 Archived-At: This is a multi-part message in MIME format... ------------=_1250845206-21766-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 21 Aug 2009 10:55:44 +0200 with message-id and subject line Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian= old-stable (dbus problem) has caused the Emacs bug report #4186, regarding 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus pro= blem) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4186: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4186 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1250845206-21766-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 19 Aug 2009 13:41:16 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.6 required=4.0 tests=AWL,IMPRONONCABLE_2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7JDfF6v012356 for ; Wed, 19 Aug 2009 06:41:16 -0700 Received: from mx10.gnu.org ([199.232.76.166]:35638) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MdlPe-0000Gc-MS for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:14 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MdlPc-0000em-C4 for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:14 -0400 Received: from mx2.imag.fr ([129.88.30.17]:50505 helo=rominette.imag.fr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MdlPa-0000dr-IB for emacs-pretest-bug@gnu.org; Wed, 19 Aug 2009 09:41:11 -0400 Received: from mail-veri.imag.fr (mail-veri.imag.fr [129.88.43.52]) by rominette.imag.fr (8.13.8/8.13.8) with ESMTP id n7JDdYhr006476 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Wed, 19 Aug 2009 15:39:34 +0200 Received: from bauges.imag.fr ([129.88.43.5]) by mail-veri.imag.fr with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA:32) (Exim 4.50) id 1MdlPR-0003vt-7D; Wed, 19 Aug 2009 15:41:01 +0200 Received: from moy by bauges.imag.fr with local (Exim 4.63) (envelope-from ) id 1MdlPR-00072W-5n; Wed, 19 Aug 2009 15:41:01 +0200 To: emacs-pretest-bug@gnu.org Subject: Re: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem) References: From: Matthieu Moy Date: Wed, 19 Aug 2009 15:41:01 +0200 In-Reply-To: (Matthieu Moy's message of "Wed\, 19 Aug 2009 14\:21\:05 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: Matthieu Moy X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2 (rominette.imag.fr [129.88.30.17]); Wed, 19 Aug 2009 15:39:34 +0200 (CEST) X-IMAG-MailScanner-Information: Please contact MI2S MIM for more information X-MailScanner-ID: n7JDdYhr006476 X-IMAG-MailScanner: Found to be clean X-IMAG-MailScanner-SpamCheck: X-IMAG-MailScanner-From: moy@imag.fr MailScanner-NULL-Check: 1251293976.91015@qUS2RIomKKohcMPpbcrb5Q X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Matthieu Moy writes: > Fine, I thought, my dbus is too old, I don't need it, I'll disable it. > But compiling with --without-dbus, it doesn't work either: > > Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc > Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el > Loading tramp... > > In toplevel form: > ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus > make[2]: *** [...] Error 1 This happens since this revision below (thanks to 'git bisect' ;-) ). Reverting it fixes the problem for me. I guess the important part was the (when (and (featurep 'dbusbind) (not (featurep 'dbus))) which got lost in the process. commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2 Author: Michael Albinus Date: Wed Aug 19 07:08:57 2009 +0000 * net/dbus.el (top): Apply `dbus-init-bus' for the :session bus only if it is running already. diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el index c1222a6..159fcb6 100644 --- a/lisp/net/dbus.el +++ b/lisp/net/dbus.el @@ -41,15 +41,6 @@ (defvar dbus-debug) (defvar dbus-registered-functions-table) -;; Initialize :system and :session buses. This adds their file -;; descriptors to input_wait_mask, in order to detect incoming -;; messages immediately. -;; We must avoid to call the function twice for a bus, because the -;; DBusWatch will be removed then. -(when (and (featurep 'dbusbind) (not (featurep 'dbus))) - (dbus-init-bus :system) - (dbus-init-bus :session)) - ;; Pacify byte compiler. (eval-when-compile (require 'cl)) @@ -841,6 +832,14 @@ name of the property, and its value. If there are no properties, (cons property (dbus-get-property bus service path interface property)) 'append))))) +;; Initialize :system and :session buses. This adds their file +;; descriptors to input_wait_mask, in order to detect incoming +;; messages immediately. +(dbus-ignore-errors + (dbus-init-bus :system) + (when (getenv "DBUS_SESSION_BUS_ADDRESS") + (dbus-init-bus :session))) + (provide 'dbus) ;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd -- Matthieu ------------=_1250845206-21766-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4186-done) by emacsbugs.donarmstrong.com; 21 Aug 2009 08:55:53 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.2 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mailrelay1.alcatel.de (mailrelay1.alcatel.de [194.113.59.95]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7L8tpmL021244 for <4186-done@emacsbugs.donarmstrong.com>; Fri, 21 Aug 2009 01:55:52 -0700 Received: from destgsu0048.stgl.sel.alcatel.de (destgsu0048.de.alcatel-lucent.com [149.204.242.4]) by mailrelay1.alcatel.de (8.13.8/8.13.8/ICT) with ESMTP id n7L8tjWV022693; Fri, 21 Aug 2009 10:55:45 +0200 Received: from slbhn1.alcatel.de (slbhn1.de.alcatel-lucent.com [149.204.90.35]) by destgsu0048.stgl.sel.alcatel.de (8.12.3/8.12.3) with ESMTP id n7L8tjY4022780; Fri, 21 Aug 2009 10:55:45 +0200 (MEST) From: Michael Albinus To: Matthieu Moy Cc: <4186-done@emacsbugs.donarmstrong.com> Subject: Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem) References: Date: Fri, 21 Aug 2009 10:55:44 +0200 In-Reply-To: (Matthieu Moy's message of "Fri, 21 Aug 2009 10:27:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Alcanet-virus-scanned: n7L8tjY4022780 at destgsu0048.stgl.sel.alcatel.de X-Scanned-By: MIMEDefang 2.57 on 149.204.45.72 Matthieu Moy writes: >> Both functions have been added in D-Bus 1.1.1. I've committed a fix, >> which checks the availability of these functions. > > [...] > >> Yes, I've reenabled the check for (featurep 'dbusbind) > > Great job, Emacs compiles both --with and --without-dbus now. OK, so I close the ticket. > Thanks a lot! Best regards, Michael. ------------=_1250845206-21766-2--