bug#4201: marked as done (23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem))

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Your message dated Fri, 21 Aug 2009 10:55:44 +0200
with message-id <nqws4xo8a7.fsf@alcatel-lucent.de>
and subject line Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
has caused the Emacs bug report #4186,
regarding 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4186: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4186
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5147 bytes --]

From: Matthieu Moy <Matthieu.Moy@imag.fr>
To: emacs-pretest-bug@gnu.org
Subject: Re: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Wed, 19 Aug 2009 15:41:01 +0200
Message-ID: <vpqr5v7ncpe.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> Fine, I thought, my dbus is too old, I don't need it, I'll disable it.
> But compiling with --without-dbus, it doesn't work either:
>
> Wrote /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-ftp.elc
> Compiling /net/bauges/local/moy/usr/src/emacs.git/lisp/net/tramp-gvfs.el
> Loading tramp...
>
> In toplevel form:
> ../../lisp/net/tramp-gvfs.el:101:1:Error: Symbol's function definition is void: dbus-init-bus
> make[2]: *** [...] Error 1

This happens since this revision below (thanks to 'git bisect' ;-) ).
Reverting it fixes the problem for me. I guess the important part was
the

  (when (and (featurep 'dbusbind) (not (featurep 'dbus)))

which got lost in the process.


commit f1a6beaaeea05ae21131f38ed5ff243046fb29f2
Author: Michael Albinus <michael.albinus@gmx.de>
Date:   Wed Aug 19 07:08:57 2009 +0000

    * net/dbus.el (top): Apply `dbus-init-bus' for the :session bus
    only if it is running already.

diff --git a/lisp/net/dbus.el b/lisp/net/dbus.el
index c1222a6..159fcb6 100644
--- a/lisp/net/dbus.el
+++ b/lisp/net/dbus.el
@@ -41,15 +41,6 @@
 (defvar dbus-debug)
 (defvar dbus-registered-functions-table)
 
-;; Initialize :system and :session buses.  This adds their file
-;; descriptors to input_wait_mask, in order to detect incoming
-;; messages immediately.
-;; We must avoid to call the function twice for a bus, because the
-;; DBusWatch will be removed then.
-(when (and (featurep 'dbusbind) (not (featurep 'dbus)))
-  (dbus-init-bus :system)
-  (dbus-init-bus :session))
-
 ;; Pacify byte compiler.
 (eval-when-compile
   (require 'cl))
@@ -841,6 +832,14 @@ name of the property, and its value.  If there are no properties,
 	 (cons property (dbus-get-property bus service path interface property))
 	 'append)))))
 
+;; Initialize :system and :session buses.  This adds their file
+;; descriptors to input_wait_mask, in order to detect incoming
+;; messages immediately.
+(dbus-ignore-errors
+  (dbus-init-bus :system)
+  (when (getenv "DBUS_SESSION_BUS_ADDRESS")
+    (dbus-init-bus :session)))
+
 (provide 'dbus)
 
 ;; arch-tag: a47caf84-9162-4811-90cc-5d388e37b9bd

-- 
Matthieu


[-- Attachment #3: Type: message/rfc822, Size: 2237 bytes --]

From: Michael Albinus <michael.albinus@gmx.de>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: <4186-done@emacsbugs.donarmstrong.com>
Subject: Re: bug#4186: 23.0.91; Can not compile CVS Emacs on Debian old-stable (dbus problem)
Date: Fri, 21 Aug 2009 10:55:44 +0200
Message-ID: <nqws4xo8a7.fsf@alcatel-lucent.de>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

>> Both functions have been added in D-Bus 1.1.1. I've committed a fix,
>> which checks the availability of these functions.
>
> [...]
>
>> Yes, I've reenabled the check for (featurep 'dbusbind)
>
> Great job, Emacs compiles both --with and --without-dbus now.

OK, so I close the ticket.

> Thanks a lot!

Best regards, Michael.