bug#420: Customize not saving faces whose values are hidden

bug#420: Customize not saving faces whose values are hidden

[Jan Rehders]

From: Jan Rehders <cmdkeen@gmx.de>
To: bug-gnu-emacs@gnu.org
Subject: customize faces not saving hidden faces
--text follows this line--

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing  
list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hello,

I have the following issue when customizing faces: On C-x,C-s  
customize will only save those faces whose values are currently shown.  
Faces which have been applied for the current session and then been  
hidden using the "Hide Face" widget will not be saved to .emacs

Reproduction:

1. M-x, customize-group, RET, font-lock-faces, RET
2. C-s, Show Face, C-b, RET (show the font lock comment face's value)
3. Change the "Foreground" field to "blue"
4. C-c,C-c, y, RET (call 'Custom-set)
5. C-x,C-s, yes, RET (call 'Custom-save)
    Check .emacs if changes have been saved (see step 9/10)
6. Change the "Foreground" field to "red"
7. C-c,C-c, y, RET (call 'Custom-set)
8. C-r, Hide Face, RET, RET (hide the font lock comment face's value)
9. C-x,C-s, yes, RET (call 'Custom-save)
10. Open your ~/.emacs and locate "custom-set-faces"
11. Have a look at font-lock-comment-face
    It's :foreground field will not have the value we just set

I would expect that faces will also be saved by `Custom-save' if their  
value is not displayed

Apart from this problem it would also be nice to be able to get a  
confirmation when closing a customize buffer if there are unsaved  
changes like with modified files. Otherwise those thoughtless people  
like me might forget to save from time to time.

keep up the great work,
Jan

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
     `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Applications/Tools/Emacs.app/Contents/Resources/etc/DEBUG for  
instructions.


In GNU Emacs 22.2.1 (i386-apple-darwin8.11.1, Carbon Version 1.6.0)
  of 2008-04-02 on seijiz.local
Windowing system distributor `Apple Inc.', version 10.5.2
configured using `configure  '--prefix=/Applications/Emacs.app/ 
Contents/Resources' '--with-carbon' '--without-x' '--libexecdir=/ 
Volumes/Emacs/Emacs.app/Contents/MacOS/libexec' 'CFLAGS=-Os -arch i386  
-arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk -DUSE_ATSUI - 
DUSE_MAC_TSM''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: nil
   locale-coding-system: iso-latin-1
   default-enable-multibyte-characters: t

Major mode: Zomp

Minor modes in effect:
   encoded-kbd-mode: t
   TeX-PDF-mode: t
   reveal-mode: t
   which-function-mode: t
   show-paren-mode: t
   partial-completion-mode: t
   global-hl-line-mode: t
   global-auto-revert-mode: t
   icomplete-mode: t
   desktop-save-mode: t
   cua-mode: t
   hl-sexp-mode: t
   eldoc-mode: t
   yas/minor-mode: t
   iswitchb-mode: t
   recentf-mode: t
   mac-print-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   unify-8859-on-encoding-mode: t
   utf-translate-cjk-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t
   hs-minor-mode: t

Recent input:
<A-return> C-n C-n C-n C-l A-3 C-` C-` C-` C-` C-o
. z o m p RET C-p C-l C-x d RET ) n n n n n n n n n
n n n n n n n p p p p p p p p p n n n n n n n n C-s
t e m p C-n C-p r f o o C-c C-c C-_ r C-g C-n C-p C-p
C-n r C-g C-g C-g <backspace> C-c C-c C-n C-p C-p C-n
r C-c <escape> C-n C-p C-p C-n C-n C-p C-p C-n C-l
C-n C-p C-p C-n C-l <kp-enter> s e t C-g C-n C-p C-p
C-n C-l r C-d C-d C-d C-c C-c C-n C-p r <C-return>
C-n f o o <backspace> <backspace> <backspace> <backspace>
x x x <return> <return> C-g C-c C-c C-p C-p C-n r <C-return>
C-n C-f C-f C-d C-c C-c q C-n C-p C-p C-n C-l <left>
r e p C-_ A-s C-a C-n <kp-enter> r e p o r t SPC e
m a c s SPC b u g RET

Recent messages:
Mark set
C-?:help M-p:pad M-o:open M-c:close M-b:blank M-s:string M-f:fill M- 
i:incr M-n:seq
if: Text is read-only
Press C-c C-c when finished or C-c ESC to abort changes
Mark set
C-?:help M-p:pad M-o:open M-c:close M-b:blank M-s:string M-f:fill M- 
i:incr M-n:seq
Undo...
Undo!
(No changes need to be saved)
Loading emacsbug...done

bug#420: marked as done (Customize not saving faces whose values are hidden)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]


Your message dated Mon, 18 Aug 2008 21:52:17 -0400
with message-id <87pro5zs8e.fsf@cyd.mit.edu>
and subject line Re: Customize not saving faces whose values are hidden
has caused the Emacs bug report #420,
regarding Customize not saving faces whose values are hidden
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
420: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=420
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6745 bytes --]

From: Jan Rehders <cmdkeen@gmx.de>
To: bug-gnu-emacs@gnu.org
Subject: Customize not saving faces whose values are hidden
Date: Sun, 15 Jun 2008 20:19:19 +0200
Message-ID: <ABECD650-FB37-4C5F-88CA-8EF04453795B@gmx.de>

From: Jan Rehders <cmdkeen@gmx.de>
To: bug-gnu-emacs@gnu.org
Subject: customize faces not saving hidden faces
--text follows this line--

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing  
list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

Hello,

I have the following issue when customizing faces: On C-x,C-s  
customize will only save those faces whose values are currently shown.  
Faces which have been applied for the current session and then been  
hidden using the "Hide Face" widget will not be saved to .emacs

Reproduction:

1. M-x, customize-group, RET, font-lock-faces, RET
2. C-s, Show Face, C-b, RET (show the font lock comment face's value)
3. Change the "Foreground" field to "blue"
4. C-c,C-c, y, RET (call 'Custom-set)
5. C-x,C-s, yes, RET (call 'Custom-save)
    Check .emacs if changes have been saved (see step 9/10)
6. Change the "Foreground" field to "red"
7. C-c,C-c, y, RET (call 'Custom-set)
8. C-r, Hide Face, RET, RET (hide the font lock comment face's value)
9. C-x,C-s, yes, RET (call 'Custom-save)
10. Open your ~/.emacs and locate "custom-set-faces"
11. Have a look at font-lock-comment-face
    It's :foreground field will not have the value we just set

I would expect that faces will also be saved by `Custom-save' if their  
value is not displayed

Apart from this problem it would also be nice to be able to get a  
confirmation when closing a customize buffer if there are unsaved  
changes like with modified files. Otherwise those thoughtless people  
like me might forget to save from time to time.

keep up the great work,
Jan

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
     `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/Applications/Tools/Emacs.app/Contents/Resources/etc/DEBUG for  
instructions.


In GNU Emacs 22.2.1 (i386-apple-darwin8.11.1, Carbon Version 1.6.0)
  of 2008-04-02 on seijiz.local
Windowing system distributor `Apple Inc.', version 10.5.2
configured using `configure  '--prefix=/Applications/Emacs.app/ 
Contents/Resources' '--with-carbon' '--without-x' '--libexecdir=/ 
Volumes/Emacs/Emacs.app/Contents/MacOS/libexec' 'CFLAGS=-Os -arch i386  
-arch ppc -isysroot /Developer/SDKs/MacOSX10.4u.sdk -DUSE_ATSUI - 
DUSE_MAC_TSM''

Important settings:
   value of $LC_ALL: nil
   value of $LC_COLLATE: nil
   value of $LC_CTYPE: nil
   value of $LC_MESSAGES: nil
   value of $LC_MONETARY: nil
   value of $LC_NUMERIC: nil
   value of $LC_TIME: nil
   value of $LANG: nil
   locale-coding-system: iso-latin-1
   default-enable-multibyte-characters: t

Major mode: Zomp

Minor modes in effect:
   encoded-kbd-mode: t
   TeX-PDF-mode: t
   reveal-mode: t
   which-function-mode: t
   show-paren-mode: t
   partial-completion-mode: t
   global-hl-line-mode: t
   global-auto-revert-mode: t
   icomplete-mode: t
   desktop-save-mode: t
   cua-mode: t
   hl-sexp-mode: t
   eldoc-mode: t
   yas/minor-mode: t
   iswitchb-mode: t
   recentf-mode: t
   mac-print-mode: t
   tooltip-mode: t
   mouse-wheel-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   unify-8859-on-encoding-mode: t
   utf-translate-cjk-mode: t
   auto-compression-mode: t
   column-number-mode: t
   line-number-mode: t
   transient-mark-mode: t
   hs-minor-mode: t

Recent input:
<A-return> C-n C-n C-n C-l A-3 C-` C-` C-` C-` C-o
. z o m p RET C-p C-l C-x d RET ) n n n n n n n n n
n n n n n n n p p p p p p p p p n n n n n n n n C-s
t e m p C-n C-p r f o o C-c C-c C-_ r C-g C-n C-p C-p
C-n r C-g C-g C-g <backspace> C-c C-c C-n C-p C-p C-n
r C-c <escape> C-n C-p C-p C-n C-n C-p C-p C-n C-l
C-n C-p C-p C-n C-l <kp-enter> s e t C-g C-n C-p C-p
C-n C-l r C-d C-d C-d C-c C-c C-n C-p r <C-return>
C-n f o o <backspace> <backspace> <backspace> <backspace>
x x x <return> <return> C-g C-c C-c C-p C-p C-n r <C-return>
C-n C-f C-f C-d C-c C-c q C-n C-p C-p C-n C-l <left>
r e p C-_ A-s C-a C-n <kp-enter> r e p o r t SPC e
m a c s SPC b u g RET

Recent messages:
Mark set
C-?:help M-p:pad M-o:open M-c:close M-b:blank M-s:string M-f:fill M- 
i:incr M-n:seq
if: Text is read-only
Press C-c C-c when finished or C-c ESC to abort changes
Mark set
C-?:help M-p:pad M-o:open M-c:close M-b:blank M-s:string M-f:fill M- 
i:incr M-n:seq
Undo...
Undo!
(No changes need to be saved)
Loading emacsbug...done





[-- Attachment #3: Type: message/rfc822, Size: 1462 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Jan Rehders <cmdkeen@gmx.de>
Cc: 420-done@emacsbugs.donarmstrong.com
Subject: Re: Customize not saving faces whose values are hidden
Date: Mon, 18 Aug 2008 21:52:17 -0400
Message-ID: <87pro5zs8e.fsf@cyd.mit.edu>

> I have the following issue when customizing faces: On C-x,C-s
> customize will only save those faces whose values are currently shown.
> Faces which have been applied for the current session and then been
> hidden using the "Hide Face" widget will not be saved to .emacs

The only sane way I know of to fix this is to prevent hiding of a widget
when it is unsaved (before, it was prevented if the widget was modified,
but not if it was set for the current session only).  I've changed CVS
accordingly.

Thanks.