From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#4176: marked as done (23.1; partial completions) Date: Thu, 20 Aug 2009 20:30:29 +0000 Message-ID: References: <19081.26994.931953.186612@winooski.ccs.neu.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1250800229-15985-0" X-Trace: ger.gmane.org 1250803979 14716 80.91.229.12 (20 Aug 2009 21:32:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 20 Aug 2009 21:32:59 +0000 (UTC) To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 20 23:32:51 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MeFFT-0005Jr-6K for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 23:32:44 +0200 Original-Received: from localhost ([127.0.0.1]:44484 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeFFS-0002JM-Id for geb-bug-gnu-emacs@m.gmane.org; Thu, 20 Aug 2009 17:32:42 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeFEj-0001ex-Bu for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:31:57 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeFEe-0001Ym-Fx for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:31:56 -0400 Original-Received: from [199.232.76.173] (port=50239 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeFEd-0001YM-QB for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:31:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:49225) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MeFEc-0002i3-28 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2009 17:31:50 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7KKkpqK019227; Thu, 20 Aug 2009 13:48:13 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7KKUT2f016121; Thu, 20 Aug 2009 13:30:29 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 4176 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30388 Archived-At: This is a multi-part message in MIME format... ------------=_1250800229-15985-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Tue, 18 Aug 2009 15:11:54 -0400 with message-id and subject line Re: bug#4176: 23.1; partial completions has caused the Emacs bug report #4176, regarding 23.1; partial completions to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 4176: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D4176 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1250800229-15985-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 17 Aug 2009 14:30:21 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.1 required=4.0 tests=AWL,FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7HEUI9e025577 for ; Mon, 17 Aug 2009 07:30:20 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Md3E2-0006vZ-FN for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 10:30:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Md3Dx-0006rd-CK for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 10:30:17 -0400 Received: from [199.232.76.173] (port=58470 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Md3Dx-0006rX-3G for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 10:30:13 -0400 Received: from winooski.ccs.neu.edu ([129.10.115.117]:46754 helo=barzilay.org) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Md3Dw-00013z-LN for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 10:30:12 -0400 Received: from eli by barzilay.org with local (Exim 4.66) (envelope-from ) id 1Md3Du-0000xA-W4 for bug-gnu-emacs@gnu.org; Mon, 17 Aug 2009 10:30:10 -0400 From: Eli Barzilay MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19081.26994.931953.186612@winooski.ccs.neu.edu> Date: Mon, 17 Aug 2009 10:30:10 -0400 To: bug-gnu-emacs@gnu.org Subject: 23.1; partial completions X-Mailer: VM 7.19 under Emacs 22.1.1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) With the default settings, enter C-h f select-window TAB and Emacs will tell you that this is the only completion. Trying this with `sele-wind TAB' does a partial completion to `select-window' and moves the cursor to the right place -- a second TAB pops up the completions (showing both functions) saying "complete but not unique" *but* moves the cursor to the end. It would be very nice if the cursor was always at the right place, and it would not say that this is the only completion. Doing (setq completion-styles '(partial-completion)) is fixes the message, but the cursor still moves to the end. Another related problem -- the doc string for `completion-styles' doesn't say anything about what's allowed (should mention `completion-styles-alist'). Also, the functions that are used in `completion-styles-alist' are not documented -- which leaves the user with no explanation at all about the available completion styles. In GNU Emacs 23.1.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.14) of 2009-08-01 on winooski.ccs.neu.edu Windowing system distributor `The X.Org Foundation', version 11.0.10300000 configured using `configure '--prefix=/home/eli/bin/local/emacs-dir'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: POSIX value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: whitespace-mode: t cua-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t temp-buffer-resize-mode: t line-number-mode: t transient-mark-mode: t Recent input: l e c t - w i l C-g C-g C-g ; C-x C-e C-h f s e l e c - w i n C-g ; C-x C-e C-h f s e l e - w i n d C-g C-g C-h f s e l - w i n C-g C-g ; C-x C-e C-h f s e l e c t - w i n d o C-g C-g C-h f s e l - w i n C-g C-g M-x r e p o r t - w i n e e m a - b u ------------=_1250800229-15985-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4176-done) by emacsbugs.donarmstrong.com; 18 Aug 2009 19:11:59 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.3 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from pruche.dit.umontreal.ca (pruche.dit.umontreal.ca [132.204.246.22]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7IJBv0U026363 for <4176-done@emacsbugs.donarmstrong.com>; Tue, 18 Aug 2009 12:11:58 -0700 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n7IJBsBX028458; Tue, 18 Aug 2009 15:11:54 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 6ECA53A0F6; Tue, 18 Aug 2009 15:11:54 -0400 (EDT) From: Stefan Monnier To: Eli Barzilay Subject: Re: bug#4176: 23.1; partial completions Message-ID: References: <19081.26994.931953.186612@winooski.ccs.neu.edu> Date: Tue, 18 Aug 2009 15:11:54 -0400 In-Reply-To: <19081.26994.931953.186612@winooski.ccs.neu.edu> (Eli Barzilay's message of "Mon, 17 Aug 2009 10:30:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3343=0 >>>>> "Eli" == Eli Barzilay writes: > With the default settings, enter > C-h f select-window TAB > and Emacs will tell you that this is the only completion. > Trying this with `sele-wind TAB' does a partial completion to > `select-window' and moves the cursor to the right place -- a > second TAB pops up the completions (showing both functions) saying > "complete but not unique" *but* moves the cursor to the end. Removing the second (goto-char (field-end)) in minibuffer-complete was indeed a correct solution, in the end. I've installed a sligtly different patch so that the point-motion is consolidated inside completion--do-completion. See below the patch I installed. > It would be very nice if the cursor was always at the right place, and > it would not say that this is the only completion. Doing > (setq completion-styles '(partial-completion)) > is fixes the message, but the cursor still moves to the end. The "sole completion" message is correct, given the default value of completion-styles. > Another related problem -- the doc string for `completion-styles' > doesn't say anything about what's allowed (should mention > `completion-styles-alist'). Thanks, it does mention it now. > Also, the functions that are used in `completion-styles-alist' are not > documented -- which leaves the user with no explanation at all about > the available completion styles. The functions are low-level, so the user shouldn't be expected to look at them and/or their docstrings to find out what the style does. The name of the style should hopefully be sufficient. Stefan --- minibuffer.el.~1.77.~ 2009-08-04 14:03:35.000000000 -0400 +++ minibuffer.el 2009-08-18 15:07:35.000000000 -0400 @@ -308,7 +308,8 @@ ALL-COMPLETIONS is the function that lists the completions.") (defcustom completion-styles '(basic partial-completion emacs22) - "List of completion styles to use." + "List of completion styles to use. +The available styles are listed in `completion-styles-alist'." :type `(repeat (choice ,@(mapcar (lambda (x) (list 'const (car x))) completion-styles-alist))) :group 'minibuffer @@ -388,7 +389,9 @@ (cond ((null comp) (ding) (minibuffer-message "No match") (minibuffer--bitset nil nil nil)) - ((eq t comp) (minibuffer--bitset nil nil t)) ;Exact and unique match. + ((eq t comp) + (goto-char (field-end)) + (minibuffer--bitset nil nil t)) ;Exact and unique match. (t ;; `completed' should be t if some completion was done, which doesn't ;; include simply changing the case of the entered string. However, @@ -462,11 +465,9 @@ (case (completion--do-completion) (#b000 nil) - (#b001 (goto-char (field-end)) - (minibuffer-message "Sole completion") + (#b001 (minibuffer-message "Sole completion") t) - (#b011 (goto-char (field-end)) - (minibuffer-message "Complete, but not unique") + (#b011 (minibuffer-message "Complete, but not unique") t) (t t))))) @@ -694,11 +695,9 @@ (interactive) (case (completion--do-completion 'completion--try-word-completion) (#b000 nil) - (#b001 (goto-char (field-end)) - (minibuffer-message "Sole completion") + (#b001 (minibuffer-message "Sole completion") t) - (#b011 (goto-char (field-end)) - (minibuffer-message "Complete, but not unique") + (#b011 (minibuffer-message "Complete, but not unique") t) (t t))) ------------=_1250800229-15985-0--