bug#4079: marked as done (23.1.50; compile.el comments for gnu pattern first line)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]


Your message dated Sun, 09 Aug 2009 22:46:22 -0400
with message-id <87vdkwwflt.fsf@cyd.mit.edu>
and subject line Re: 23.1.50; compile.el comments for gnu pattern first line
has caused the Emacs bug report #4079,
regarding 23.1.50; compile.el comments for gnu pattern first line
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4079: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4079
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3906 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 286 bytes --]

Answering a question left by Stefan ...

2009-08-08  Kevin Ryde  <user42@zip.com.au>

	* progmodes/compile.el (compilation-error-regexp-alist-alist): Add
	crib to `gnu' pattern on what the first line is for.  (The pattern is
	so hairy some verbosity can be tolerated in the comments!)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2.1.2: compile.el.gnu-comment.diff --]
[-- Type: text/x-diff, Size: 1166 bytes --]

*** compile.el	11 Jul 2009 07:12:48 +1000	1.495
--- compile.el	08 Aug 2009 11:12:37 +1000	
***************
*** 234,240 ****
       (2 (compilation-face '(3))))
  
      (gnu
!      ;; I have no idea what this first line is supposed to match, but it
       ;; makes things ambiguous with output such as "foo:344:50:blabla" since
       ;; the "foo" part can match this first line (in which case the file
       ;; name as "344").  To avoid this, the second line disallows filenames
--- 234,247 ----
       (2 (compilation-face '(3))))
  
      (gnu
!      ;; The first line matches the program name for
!      ;;     PROGRAM:SOURCE-FILE-NAME:LINENO: MESSAGE
!      ;; format as per gnu standards.info "Errors" for non-interactive
!      ;; programs other than compilers.  Eg. the "jade:" entry in
!      ;; compilation.txt
!      ;;     jade:dbcommon.dsl:133:17:E: missing argument for function call
!      ;;
!      ;; The first line
       ;; makes things ambiguous with output such as "foo:344:50:blabla" since
       ;; the "foo" part can match this first line (in which case the file
       ;; name as "344").  To avoid this, the second line disallows filenames

[-- Attachment #3: Type: message/rfc822, Size: 1091 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Kevin Ryde <user42@zip.com.au>
Cc: 4079-done@emacsbugs.donarmstrong.com
Subject: Re: 23.1.50; compile.el comments for gnu pattern first line
Date: Sun, 09 Aug 2009 22:46:22 -0400
Message-ID: <87vdkwwflt.fsf@cyd.mit.edu>

Thanks, I've updated the comment.