From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3971: marked as done (23.1.50; linum-mode kills right margin) Date: Tue, 22 Sep 2009 00:20:06 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1253578806-19997-0" X-Trace: ger.gmane.org 1253579246 6586 80.91.229.12 (22 Sep 2009 00:27:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Sep 2009 00:27:26 +0000 (UTC) To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 22 02:27:18 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MptDx-0000Hz-Dw for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Sep 2009 02:27:17 +0200 Original-Received: from localhost ([127.0.0.1]:38980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MptDw-0005MH-As for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Sep 2009 20:27:16 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MptDs-0005MC-Eu for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 20:27:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MptDn-0005Lg-0E for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 20:27:11 -0400 Original-Received: from [199.232.76.173] (port=50885 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MptDm-0005Ld-S1 for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 20:27:06 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:59953) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MptDm-0003pH-7v for bug-gnu-emacs@gnu.org; Mon, 21 Sep 2009 20:27:06 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8M0R2TD021106; Mon, 21 Sep 2009 17:27:03 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n8M0K6it020030; Mon, 21 Sep 2009 17:20:06 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3971 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31336 Archived-At: This is a multi-part message in MIME format... ------------=_1253578806-19997-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Tue, 22 Sep 2009 02:09:43 +0200 with message-id and subject line Re: bug#3971: 23.1.50; linum-mode kills right margin has caused the Emacs bug report #3971, regarding 23.1.50; linum-mode kills right margin to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3971: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3971 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1253578806-19997-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 30 Jul 2009 04:38:33 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.8 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6U4cS1N007257 for ; Wed, 29 Jul 2009 21:38:30 -0700 Received: from mx10.gnu.org ([199.232.76.166]:46098) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MWNPQ-0006ru-4K for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 00:38:28 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MWNPP-00022T-Ax for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 00:38:28 -0400 Received: from mail-yw0-f184.google.com ([209.85.211.184]:33132) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWNPO-000229-Ui for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 00:38:27 -0400 Received: by ywh14 with SMTP id 14so397658ywh.1 for ; Wed, 29 Jul 2009 21:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=F7b5y4jJcTLi2JLQAl7142ZDi5dbzkP38Z4oSL96AaQ=; b=RWB87u3yMB13JdFnKZesrOmgrihmklCltvEhap7m7Ec+DIWJ57qdEvoR7+ZB1TrrZx 13LBCatSbwwnf/Bwe1/T5elFh+SqUxu3mi3uURouxvXUlVp9fY+eG99ksPxr5Dn9RJ+l RkSbEaBRG4Jc5HkCoCEqJagMtBn52i8648hk4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=w0m+olgpL2YbeK91acJ4TJjRZOJ5Jmgv20y8MsbExUHCZE1XYoV06YzdcNA1e5I1Hw +K0OcNp8Hx7o95gGdDU+iOFg2p6HooeDpSX/Vwy23imwE8Z+ypYsIgDiB/Shqqn5+0k7 xGr2rA4IS1RbpAataWQgLtqueO1d7O3R6VslI= MIME-Version: 1.0 Received: by 10.100.172.16 with SMTP id u16mr954032ane.85.1248928706454; Wed, 29 Jul 2009 21:38:26 -0700 (PDT) Date: Thu, 30 Jul 2009 06:38:26 +0200 Message-ID: Subject: 23.1.50; linum-mode kills right margin From: Lennart Borgman To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) linum-mode kills the right margin. It should not touch it since it does not use it. The following patch fixes this: Index: linum.el =================================================================== RCS file: /sources/emacs/emacs/lisp/linum.el,v retrieving revision 1.11 diff -c -b -r1.11 linum.el *** linum.el 18 Jan 2009 01:45:38 -0000 1.11 --- linum.el 30 Jul 2009 04:35:10 -0000 *************** *** 108,114 **** (mapc #'delete-overlay linum-overlays) (setq linum-overlays nil) (dolist (w (get-buffer-window-list (current-buffer) nil t)) ! (set-window-margins w 0))) (defun linum-update-current () "Update line numbers for the current buffer." --- 108,114 ---- (mapc #'delete-overlay linum-overlays) (setq linum-overlays nil) (dolist (w (get-buffer-window-list (current-buffer) nil t)) ! (set-window-margins w 0 (cdr (window-margins w))))) (defun linum-update-current () "Update line numbers for the current buffer." *************** *** 163,169 **** (overlay-put ov 'linum-str str)))) (forward-line) (setq line (1+ line))) ! (set-window-margins win width))) (defun linum-after-change (beg end len) ;; update overlays on deletions, and after newlines are inserted --- 163,169 ---- (overlay-put ov 'linum-str str)))) (forward-line) (setq line (1+ line))) ! (set-window-margins win width (cdr (window-margins win))))) (defun linum-after-change (beg end len) ;; update overlays on deletions, and after newlines are inserted In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600) of 2009-06-30 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ------------=_1253578806-19997-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3971-done) by emacsbugs.donarmstrong.com; 22 Sep 2009 00:10:12 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,GMAIL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f207.google.com (mail-fx0-f207.google.com [209.85.220.207]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8M0AAfQ018562 for <3971-done@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 17:10:11 -0700 Received: by fxm3 with SMTP id 3so2548179fxm.44 for <3971-done@emacsbugs.donarmstrong.com>; Mon, 21 Sep 2009 17:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=L/XlwED4BzzVx431opB60fZlWSgkmlEdQ+4Wov+cQoM=; b=VMWfPPBTeQStoMaPUEzHZyKYeCIJCXt2Q0I80pOjeeMPGxHvC+BnTDqOin2UDe8ApX aDljMeDkc/8w9bAdGP4ai4pZ+gDXb6NljAEgRjTeTYENuuqv0A04lDtdWsohCG9uYg4W plY9YnYmFIz7t5ZhMn5bcY0pb9KhI9kkRuQrc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=SUawPpNXsECJhtdmTFOTq3uUjyfBdc80XzUgyjFqi8pbxc7L9EMZ4/2vwlz+lpVCjQ F9t7Cw+IgTI37N4CxkoWg0XbY9e7Wd+F20TAOQ7N8O3qcew+2hqNgMuvUpxygqV0NtGo 3f21X2HhHzQ7yozGPG91jyZBYvyoDAyOqVbis= MIME-Version: 1.0 Received: by 10.239.145.34 with SMTP id q34mr23216hba.124.1253578203102; Mon, 21 Sep 2009 17:10:03 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 22 Sep 2009 02:09:43 +0200 Message-ID: Subject: Re: bug#3971: 23.1.50; linum-mode kills right margin To: Lennart Borgman Cc: 3971-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=UTF-8 On Thu, Jul 30, 2009 at 07:24, Lennart Borgman wrote: > Or, maybe it is better to redefine set-window-margins so that a nil > argument for a margin means "don't touch"...? I think that would be cleaner, because 0 is already available to set a margin to "no margin". But that's an interface change, so for now I've installed your change, which fixes the bug. Juanma ------------=_1253578806-19997-0--