From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3964: marked as done (23.1.50; checkdoc more safe-local-variable) Date: Sat, 22 Aug 2009 23:10:07 +0000 Message-ID: References: <873a8frsxk.fsf@blah.blah> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1250982607-15408-0" X-Trace: ger.gmane.org 1250983648 30507 80.91.229.12 (22 Aug 2009 23:27:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 22 Aug 2009 23:27:28 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 23 01:27:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MezzS-0002Om-OX for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Aug 2009 01:27:19 +0200 Original-Received: from localhost ([127.0.0.1]:42202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MezzS-0004dX-2Q for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Aug 2009 19:27:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MezzF-0004aD-Cv for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2009 19:27:05 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MezzA-0004YF-9x for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2009 19:27:04 -0400 Original-Received: from [199.232.76.173] (port=57029 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mezz9-0004Y8-U2 for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2009 19:26:59 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42411) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mezz6-0001Jq-Pl; Sat, 22 Aug 2009 19:26:57 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7MNQpaD018231; Sat, 22 Aug 2009 16:26:52 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n7MNA7KF015450; Sat, 22 Aug 2009 16:10:07 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3964 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30488 Archived-At: This is a multi-part message in MIME format... ------------=_1250982607-15408-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 22 Aug 2009 19:02:41 -0400 with message-id and subject line Re: bug#3964: 23.1.50; checkdoc more safe-local-variable has caused the Emacs bug report #3964, regarding 23.1.50; checkdoc more safe-local-variable to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3964: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3964 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1250982607-15408-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 29 Jul 2009 23:06:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6TN6e3f000661 for ; Wed, 29 Jul 2009 16:06:44 -0700 Received: from mx10.gnu.org ([199.232.76.166]:52680) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MWIEF-0006qU-3T for emacs-pretest-bug@gnu.org; Wed, 29 Jul 2009 19:06:35 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MWIEA-0006W8-LM for emacs-pretest-bug@gnu.org; Wed, 29 Jul 2009 19:06:33 -0400 Received: from mailout2-10.pacific.net.au ([125.255.80.137]:34042 helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MWIE9-0006Uk-Rs for emacs-pretest-bug@gnu.org; Wed, 29 Jul 2009 19:06:30 -0400 Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.2.162]) by mailout2.pacific.net.au (Postfix) with ESMTP id 2812E183D51 for ; Thu, 30 Jul 2009 09:06:24 +1000 (EST) Received: from blah.blah (ppp2FA7.dyn.pacific.net.au [61.8.47.167]) by mailproxy1.pacific.net.au (Postfix) with ESMTP id 559AD8C30 for ; Thu, 30 Jul 2009 09:06:22 +1000 (EST) Received: from gg by blah.blah with local (Exim 4.69) (envelope-from ) id 1MWIDQ-0001jV-Sp for emacs-pretest-bug@gnu.org; Thu, 30 Jul 2009 09:05:44 +1000 From: Kevin Ryde To: emacs-pretest-bug@gnu.org Subject: 23.1.50; checkdoc more safe-local-variable Date: Thu, 30 Jul 2009 09:05:43 +1000 Message-ID: <873a8frsxk.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) --=-=-= I noticed a couple of checkdoc.el variables which could have safe-local-variable settings. I struck checkdoc-arguments-in-order-flag and checkdoc-symbol-words in bongo.el. The checkdoc-symbol-words docstring invites you to set it as a local variable, so it in particular ought to have something for what's safe. 2009-07-30 Kevin Ryde * emacs-lisp/checkdoc.el (checkdoc-force-history-flag, checkdoc-arguments-in-order-flag): Add safe-local-variable booleanp. (checkdoc-symbol-words): Add safe-local-variable for list of strings, clarify docstring that the value is strings not symbols. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=checkdoc.el.safe-lvar.diff *** checkdoc.el 23 Jul 2009 07:41:51 +1000 1.72 --- checkdoc.el 28 Jul 2009 14:29:14 +1000 *************** *** 223,228 **** --- 223,229 ---- This helps document the evolution of, and recent changes to, the package." :group 'checkdoc :type 'boolean) + ;;;###autoload(put 'checkdoc-force-history-flag 'safe-local-variable 'booleanp) (defcustom checkdoc-permit-comma-termination-flag nil "Non-nil means the first line of a docstring may end with a comma. *************** *** 270,275 **** --- 271,277 ---- made in the style guide relating to order." :group 'checkdoc :type 'boolean) + ;;;###autoload(put 'checkdoc-arguments-in-order-flag 'safe-local-variable 'booleanp) (defvar checkdoc-style-hooks nil "Hooks called after the standard style check is completed. *************** *** 307,317 **** with a universal argument.") (defcustom checkdoc-symbol-words nil ! "A list of symbols which also happen to make good words. ! These symbol-words are ignored when unquoted symbols are searched for. This should be set in an Emacs Lisp file's local variables." :group 'checkdoc :type '(repeat (symbol :tag "Word"))) (defvar checkdoc-proper-noun-list '("ispell" "xemacs" "emacs" "lisp") --- 309,327 ---- with a universal argument.") (defcustom checkdoc-symbol-words nil ! "A list of symbol names (strings) which also happen to make good words. ! These words are ignored when unquoted symbols are searched for. This should be set in an Emacs Lisp file's local variables." :group 'checkdoc :type '(repeat (symbol :tag "Word"))) + ;;;###autoload(put 'checkdoc-symbol-words 'safe-local-variable 'checkdoc-list-of-strings-p) + + ;;;###autoload + (defun checkdoc-list-of-strings-p (obj) + ;; this is a function so it might be shared by checkdoc-proper-noun-list + ;; and/or checkdoc-ispell-lisp-words in the future + (and (listp obj) + (not (memq nil (mapcar 'stringp obj))))) (defvar checkdoc-proper-noun-list '("ispell" "xemacs" "emacs" "lisp") --=-=-=-- ------------=_1250982607-15408-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3964-done) by emacsbugs.donarmstrong.com; 22 Aug 2009 23:02:43 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-7.9 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n7MN2gca013465 for <3964-done@emacsbugs.donarmstrong.com>; Sat, 22 Aug 2009 16:02:43 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1Mezbd-000151-Ig; Sat, 22 Aug 2009 19:02:41 -0400 From: Glenn Morris To: 3964-done@emacsbugs.donarmstrong.com Subject: Re: bug#3964: 23.1.50; checkdoc more safe-local-variable References: <873a8frsxk.fsf@blah.blah> X-Spook: Forte Rule Psix Watergate Serbian e-bomb NWO Medco X-Ran: i+P19l5ftuw)\0a{0SeImf~dIf.\5::C=*[#hM8]k$3dN?53XUn_CA>=C%#}h9!Pgn_0Z] X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 22 Aug 2009 19:02:41 -0400 In-Reply-To: <873a8frsxk.fsf@blah.blah> (Kevin Ryde's message of "Thu, 30 Jul 2009 09:05:43 +1000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Thank you; applied. ------------=_1250982607-15408-0--