From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3889: marked as done (23.1.50; [PATCH] Increase blink-matching-paren-distance) Date: Wed, 22 Jul 2009 02:40:05 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1248230405-3066-0" X-Trace: ger.gmane.org 1248231485 16645 80.91.229.12 (22 Jul 2009 02:58:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jul 2009 02:58:05 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 22 04:57:58 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MTS1i-0002r2-PI for geb-bug-gnu-emacs@m.gmane.org; Wed, 22 Jul 2009 04:57:57 +0200 Original-Received: from localhost ([127.0.0.1]:48001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTS1h-0001Q0-Cy for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Jul 2009 22:57:53 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MTS1b-0001MO-IK for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2009 22:57:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MTS1W-0001IB-LE for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2009 22:57:47 -0400 Original-Received: from [199.232.76.173] (port=57256 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MTS1W-0001Hu-Fy for bug-gnu-emacs@gnu.org; Tue, 21 Jul 2009 22:57:42 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37932) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MTS1P-00047L-HD; Tue, 21 Jul 2009 22:57:37 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6M2vTUU006059; Tue, 21 Jul 2009 19:57:29 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n6M2e54q003088; Tue, 21 Jul 2009 19:40:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3889 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29549 Archived-At: This is a multi-part message in MIME format... ------------=_1248230405-3066-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Tue, 21 Jul 2009 22:35:50 -0400 with message-id and subject line Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-par= en-distance has caused the Emacs bug report #3889, regarding 23.1.50; [PATCH] Increase blink-matching-paren-distance to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3889: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3889 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1248230405-3066-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 20 Jul 2009 20:49:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.3 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6KKnoIG018029 for ; Mon, 20 Jul 2009 13:49:52 -0700 Received: from mx10.gnu.org ([199.232.76.166]:59547) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MSzny-00010q-1T for emacs-pretest-bug@gnu.org; Mon, 20 Jul 2009 16:49:50 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MSznw-0006Vy-UM for emacs-pretest-bug@gnu.org; Mon, 20 Jul 2009 16:49:49 -0400 Received: from mail.digg.com ([64.191.203.36]:58350) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MSznw-0006Vg-Jc for emacs-pretest-bug@gnu.org; Mon, 20 Jul 2009 16:49:48 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.digg.com (Postfix) with ESMTP id CDC74A8538B for ; Mon, 20 Jul 2009 13:49:47 -0700 (PDT) X-Virus-Scanned: amavisd-new at d242.digg.internal Received: from mail.digg.com ([127.0.0.1]) by localhost (mail.digg.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VGRYbLkUbJof for ; Mon, 20 Jul 2009 13:49:47 -0700 (PDT) Received: from [10.2.16.50] (diggstage01.digg.com [64.191.203.34]) by mail.digg.com (Postfix) with ESMTP id 3E919A85129 for ; Mon, 20 Jul 2009 13:49:47 -0700 (PDT) Message-Id: From: Ian Eure To: emacs-pretest-bug@gnu.org Content-Type: multipart/mixed; boundary=Apple-Mail-3--767152792 Mime-Version: 1.0 (Apple Message framework v935.3) Subject: 23.1.50; [PATCH] Increase blink-matching-paren-distance Date: Mon, 20 Jul 2009 13:49:46 -0700 X-Mailer: Apple Mail (2.935.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) --Apple-Mail-3--767152792 Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit A user came into #emacs today complaining that his paren matching was not working with a large file, and that font-locking broke as a result. I found that this is controlled by blink-matching-paren-distance, which was increased to 25kb around 1997. Attached is a patch which doubles this to 50kb, as this should be fine for modern machines. I think that we should seriously consider setting the default to nil, but this seems like a more conservative approach to the matter. --Apple-Mail-3--767152792 Content-Disposition: attachment; filename=blink-matching-paren.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="blink-matching-paren.patch" Content-Transfer-Encoding: 7bit Index: simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.998 diff -u -u -r1.998 simple.el --- simple.el 19 Jul 2009 00:33:11 -0000 1.998 +++ simple.el 20 Jul 2009 20:45:21 -0000 @@ -5254,7 +5254,7 @@ :type 'boolean :group 'paren-blinking) -(defcustom blink-matching-paren-distance (* 25 1024) +(defcustom blink-matching-paren-distance (* 50 1024) "If non-nil, maximum distance to search backwards for matching open-paren. If nil, search stops at the beginning of the accessible portion of the buffer." :type '(choice (const nil) integer) --Apple-Mail-3--767152792 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit --Apple-Mail-3--767152792-- ------------=_1248230405-3066-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3889-done) by emacsbugs.donarmstrong.com; 22 Jul 2009 02:35:55 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-8.0 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n6M2ZpXT002639 for <3889-done@emacsbugs.donarmstrong.com>; Tue, 21 Jul 2009 19:35:52 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MTRgM-0004HX-Oe; Tue, 21 Jul 2009 22:35:50 -0400 From: Glenn Morris To: 3889-done@emacsbugs.donarmstrong.com Subject: Re: bug#3889: 23.1.50; [PATCH] Increase blink-matching-paren-distance References: X-Spook: FBI nitrate Marxist ASLET Mahmoud Ahmadinejad subversive X-Ran: ~c+CtB User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Stefan Monnier wrote: >> Attached is a patch which doubles this to 50kb, as this should be fine for >> modern machines. > > 100kB should be fine, indeed. So increased. ------------=_1248230405-3066-0--