bug#3770: archive-mode: recognize ZIP files with non-standard "PK00" header

bug#3770: archive-mode: recognize ZIP files with non-standard "PK00" header

[Peter Jolly]

Some ZIP files have the string "PK00" before the first PK^C^D header.
Apparently this is added by certain archivers when writing to removable
media.

archive-find-type does not currently recognize such files.  The rest of
archive-mode handles them correctly, so I believe they can be supported
with a trivial change: something like

diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el
index cc59d6e..174d205 100644
--- a/lisp/arc-mode.el
+++ b/lisp/arc-mode.el
@@ -716,7 +716,7 @@ archive.
   ;; The funny [] here make it unlikely that the .elc file will be treated
   ;; as an archive by other software.
   (let (case-fold-search)
-    (cond ((looking-at "[P]K\003\004") 'zip)
+    (cond ((looking-at "\\(PK00\\)?[P]K\003\004") 'zip)
 	  ((looking-at "..-l[hz][0-9ds]-") 'lzh)
 	  ((looking-at "....................[\334]\247\304\375") 'zoo)
 	  ((and (looking-at "\C-z")	; signature too simple, IMHO

bug#3770: marked as done (archive-mode: recognize ZIP files with non-standard "PK00" header)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]


Your message dated Sun, 12 Jul 2009 14:56:27 -0400
with message-id <87ab39wx0k.fsf@stupidchicken.com>
and subject line Re: archive-mode: recognize ZIP files with non-standard "PK00" header
has caused the Emacs bug report #3770,
regarding archive-mode: recognize ZIP files with non-standard "PK00" header
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3770: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3770
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2865 bytes --]

From: Peter Jolly <peter@jollys.org>
To: bug-gnu-emacs@gnu.org
Subject: archive-mode: recognize ZIP files with non-standard "PK00" header
Date: Mon, 06 Jul 2009 23:28:37 +0100
Message-ID: <87r5wt78fe.fsf@haeleth.net>

Some ZIP files have the string "PK00" before the first PK^C^D header.
Apparently this is added by certain archivers when writing to removable
media.

archive-find-type does not currently recognize such files.  The rest of
archive-mode handles them correctly, so I believe they can be supported
with a trivial change: something like

diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el
index cc59d6e..174d205 100644
--- a/lisp/arc-mode.el
+++ b/lisp/arc-mode.el
@@ -716,7 +716,7 @@ archive.
   ;; The funny [] here make it unlikely that the .elc file will be treated
   ;; as an archive by other software.
   (let (case-fold-search)
-    (cond ((looking-at "[P]K\003\004") 'zip)
+    (cond ((looking-at "\\(PK00\\)?[P]K\003\004") 'zip)
 	  ((looking-at "..-l[hz][0-9ds]-") 'lzh)
 	  ((looking-at "....................[\334]\247\304\375") 'zoo)
 	  ((and (looking-at "\C-z")	; signature too simple, IMHO



[-- Attachment #3: Type: message/rfc822, Size: 1676 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Peter Jolly <peter@jollys.org>
Cc: 3770-done@emacsbugs.donarmstrong.com
Subject: Re: archive-mode: recognize ZIP files with non-standard "PK00" header
Date: Sun, 12 Jul 2009 14:56:27 -0400
Message-ID: <87ab39wx0k.fsf@stupidchicken.com>

> Some ZIP files have the string "PK00" before the first PK^C^D header.
> Apparently this is added by certain archivers when writing to removable
> media.

Thanks.  I've checked in your patch into CVS trunk.