From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3542: marked as done (23.0.94; File access via UNC path slow again under Windows) Date: Thu, 09 Jul 2009 19:00:05 +0000 Message-ID: References: <834otlzo5w.fsf@gnu.org> <7dbe73ed0906120238vf2279fey30930332cf62606@mail.gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1247166005-25557-0" X-Trace: ger.gmane.org 1247167410 4478 80.91.229.12 (9 Jul 2009 19:23:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jul 2009 19:23:30 +0000 (UTC) To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 09 21:23:23 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MOzDE-0003uP-Tv for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jul 2009 21:23:22 +0200 Original-Received: from localhost ([127.0.0.1]:60315 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOzDE-0006Eu-6S for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jul 2009 15:23:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MOz7p-00038E-NJ for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2009 15:17:45 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MOz7l-00035S-NU for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2009 15:17:45 -0400 Original-Received: from [199.232.76.173] (port=41554 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MOz7l-00035J-H2 for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2009 15:17:41 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36198) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MOz7Z-0006uC-9p; Thu, 09 Jul 2009 15:17:29 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69JHQqw029349; Thu, 9 Jul 2009 12:17:27 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n69J05C9025574; Thu, 9 Jul 2009 12:00:05 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3542 X-Emacs-PR-Package: emacs,w32 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:29279 Archived-At: This is a multi-part message in MIME format... ------------=_1247166005-25557-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 09 Jul 2009 21:50:19 +0300 with message-id <834otlzo5w.fsf@gnu.org> and subject line Re: bug #3542 (23.0.94; File access via UNC path slow agai= n under Windows) has caused the Emacs bug report #3542, regarding 23.0.94; File access via UNC path slow again under Windows to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3542: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3542 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1247166005-25557-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 12 Jun 2009 09:39:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n5C9dOcs013818 for ; Fri, 12 Jun 2009 02:39:25 -0700 Received: from mail.gnu.org ([199.232.76.166]:37057 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MF3EI-0006uv-QP for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 05:39:23 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MF3EH-0003x0-QF for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 05:39:22 -0400 Received: from mail-ew0-f225.google.com ([209.85.219.225]:43642) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MF3EH-0003wU-CN for emacs-pretest-bug@gnu.org; Fri, 12 Jun 2009 05:39:21 -0400 Received: by ewy25 with SMTP id 25so1305463ewy.42 for ; Fri, 12 Jun 2009 02:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type:content-transfer-encoding; bh=SB6xV2LH7fYNoF0dwS1F8XMQS4xJr2gQql23DMVbgHk=; b=YqHWVA4V1BeAV95c4+gnvTwSROgMLL3QJ9EMiAPvUOuOPNIUBFGGj3d/rucGXyKHfi TDulCQOFAd/ghqwc2Tt16cRVdoAZyHXxzO4zlBNfuOREQGO5/D78adfIJjtRRNdqfgqw sz+NAHS9X6B/WtWXCK69WL42KS+XriLECPNEA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type :content-transfer-encoding; b=G9nY2jPhPCqD4ylR31Iw+9s2bt4WpM/sf8KbWuSPL5yQy19eUi3ixDWKaYB2GPGTNs 9gAZBRBfUpOjRbqTPMsYnN3ZbKDddfNHUgZ+c3t+PsP7bm3dRvJYUpKLIGtfwKIiaHPr 0X/mpTQ5mVNx6iqm77BojNMCwEsmwTNYDZ1ac= MIME-Version: 1.0 Received: by 10.216.51.82 with SMTP id a60mr1220961wec.108.1244799559102; Fri, 12 Jun 2009 02:39:19 -0700 (PDT) From: Mathias Dahl Date: Fri, 12 Jun 2009 11:38:59 +0200 Message-ID: <7dbe73ed0906120238vf2279fey30930332cf62606@mail.gmail.com> Subject: 23.0.94; File access via UNC path slow again under Windows To: emacs-pretest-bug@gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: 1. Start emacs with -Q 2. Open a directory or file by entering its UNC path (e.g. C-x C-f //server/share/folder/file.txt RET). 3. Notice it is very slow to get it to open. I reported this before Emacs 21 or 22 was released, and it was fixed then. In the latest two pretests the problem is now back. Working with UNC paths is now almost unusable - I have to wait several seconds to open a file or get a file listing in Dired. Thanks! /Mathias If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file e:/dat/dl/emacs-23.0.94/etc/DEBUG for instructions. In GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: SVE value of $XMODIFIERS: nil locale-coding-system: cp1252 default-enable-multibyte-characters: t Major mode: Dired by name Minor modes in effect: tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x C-f / / g b g f s 1 / a r 7 5 d o c m a n M-x v e r s Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. GNU Emacs 23.0.94.1 (i386-mingw-nt5.1.2600) of 2009-05-24 on SOFT-MJASON ------------=_1247166005-25557-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3542-done) by emacsbugs.donarmstrong.com; 9 Jul 2009 18:52:04 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.7 required=4.0 tests=AWL,FOURLA,GMAIL, IMPRONONCABLE_1,MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout5.012.net.il (mtaout5.012.net.il [84.95.2.13]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n69Ipw7S024608 for <3542-done@emacsbugs.donarmstrong.com>; Thu, 9 Jul 2009 11:51:59 -0700 Received: from conversion-daemon.i_mtaout5.012.net.il by i_mtaout5.012.net.il (HyperSendmail v2004.12) id <0KMJ00B002IPOK00@i_mtaout5.012.net.il> for 3542-done@emacsbugs.donarmstrong.com; Thu, 09 Jul 2009 21:50:18 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.249.41]) by i_mtaout5.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0KMJ00K9S2ZTYD50@i_mtaout5.012.net.il> for 3542-done@emacsbugs.donarmstrong.com; Thu, 09 Jul 2009 21:50:18 +0300 (IDT) Date: Thu, 09 Jul 2009 21:50:19 +0300 From: Eli Zaretskii Subject: Re: bug #3542 (23.0.94; File access via UNC path slow again under Windows) In-reply-to: <7dbe73ed0907051401o26903ca3t9a67060f3a3417ad@mail.gmail.com> X-012-Sender: halo1@inter.net.il To: 3542-done@emacsbugs.donarmstrong.com Reply-to: Eli Zaretskii Message-id: <834otlzo5w.fsf@gnu.org> References: <7dbe73ed0907051401o26903ca3t9a67060f3a3417ad@mail.gmail.com> > From: Mathias Dahl > Date: Sun, 5 Jul 2009 23:01:53 +0200 > > I understand that the release of 23.1 is not far away and I am a bit > worried that this bug won't be solved before that. Is there anything I > can do to help? I use a lot of UNC file names / paths in my work and > the current slowness is very annoying (both opening files and listing > them in Dired). As this was a problem in the past too it isn't > unreasonable to believe that the bug has reappeared by mistake when > fixing some other thing (could it be related to TRAMP?). > > I am willing to go bug hunting as long as it's in elisp-land and would > like to get some hints on where to start digging. > > For details see: > http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3542 > > Thanks! Fixed with this patch: 2009-07-09 Eli Zaretskii * w32.c (stat): Treat UNC file names as residing on remote drives. (Bug#3542) --- src/w32.c.orig 2009-06-21 10:38:18.000000000 +0300 +++ src/w32.c 2009-07-09 16:31:51.250000000 +0300 @@ -3154,11 +3154,13 @@ } } - /* GetDriveType needs the root directory of NAME's drive. */ - if (!(strlen (name) >= 2 && IS_DEVICE_SEP (name[1]))) - devtype = GetDriveType (NULL); /* use root of current diectory */ + if (IS_DIRECTORY_SEP (name[0]) && IS_DIRECTORY_SEP (name[1])) + devtype = DRIVE_REMOTE; /* assume UNC name is remote */ + else if (!(strlen (name) >= 2 && IS_DEVICE_SEP (name[1]))) + devtype = GetDriveType (NULL); /* use root of current drive */ else { + /* GetDriveType needs the root directory of NAME's drive. */ strncpy (drive_root, name, 3); drive_root[3] = '\0'; devtype = GetDriveType (drive_root); ------------=_1247166005-25557-0--