bug#3530: marked as done (Simultaneously both bold and dim (italic) face attributes for ttys)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]


Your message dated Sat, 27 Jun 2009 17:29:13 -0400
with message-id <87fxdlgyc6.fsf@stupidchicken.com>
and subject line Re: Simultaneously both bold and dim (italic) face attributes for ttys
has caused the Emacs bug report #3530,
regarding Simultaneously both bold and dim (italic) face attributes for ttys
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3530: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3530
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4556 bytes --]

From: Chuck Blake <cblake@pdos.csail.mit.edu>
To: bug-gnu-emacs@gnu.org
Subject: Simultaneously both bold and dim (italic) face attributes for ttys
Date: Wed, 10 Jun 2009 23:35:06 -0400
Message-ID: <20090611033506.GA11154@pdos.lcs.mit.edu>

Hey guys.  I am not subscribed to these lists so be sure to group
reply on any feedback to this.

--
The context/bug:
--

dim is really implied by italic conventions in the original face.
I have a tty that can do italics (rxvt).  I have my terminfo/termcap
setup specify that "dim" send the escape sequences for italic.
This works great -- bold maps to tty bold (actually a bold font)
and italic maps to tty italic (actually an italic font).

However, I cannot do both bold and italic at the same time.
make-face-bold-italic works fine and all that.  And the terminal
program itself supports a true bold-italic font.

XTerm also has simultaneous bold & italic actual fonts as well.

--
Proposed remedy:
--

I tracked down the problem to basically "if (bold) *else* if (dim)"
logic in src/term.c.  See the below patch.

There seems little or no reason to me why bold font and dim color
ought be mutually exclusive or why ttys would choke on that rather
than ignoring one or the other if they can't support it.

Blinking and underlining attributes are not treated that way, either.

Nor can I find any record in the CVS logs of this logic being 
related to any bug fix to support any fragile terminal.
At least according to cvs annotate, the logic in question has been
untouched since the re-write of term.c by 'gerd' back in the Summer
of 1999.

Perhaps they just "sounded" mutually exclusive and hence the "else".

In any case, if the user simply does not specify both bold and italic
on faces this patch changes nothing.  So, it seems pretty reasonable
to drop the else and allow simultaneous bold & italic.

Thanks!!
cb

--
The Patch
--

Index: term.c
===================================================================
RCS file: /sources/emacs/emacs/src/term.c,v
retrieving revision 1.242
diff -u -w -r1.242 term.c
--- term.c	30 Apr 2009 05:02:03 -0000	1.242
+++ term.c	11 Jun 2009 02:52:31 -0000
@@ -1974,7 +1974,7 @@
       if (MAY_USE_WITH_COLORS_P (tty, NC_BOLD))
 	OUTPUT1_IF (tty, tty->TS_enter_bold_mode);
     }
-  else if (face->tty_dim_p)
+  if (face->tty_dim_p)
     if (MAY_USE_WITH_COLORS_P (tty, NC_DIM))
       OUTPUT1_IF (tty, tty->TS_enter_dim_mode);
 



[-- Attachment #3: Type: message/rfc822, Size: 1810 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Chuck Blake <cblake@amsterdam.lcs.mit.edu>
Cc: 3530-done@emacsbugs.donarmstrong.com
Subject: Re: Simultaneously both bold and dim (italic) face attributes for ttys
Date: Sat, 27 Jun 2009 17:29:13 -0400
Message-ID: <87fxdlgyc6.fsf@stupidchicken.com>

> There seems little or no reason to me why bold font and dim color
> ought be mutually exclusive or why ttys would choke on that rather
> than ignoring one or the other if they can't support it.
>
> Blinking and underlining attributes are not treated that way, either.

I've checked your patch into the Emacs CVS trunk.  Thanks.