From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3474: marked as done (23.0.94; Emacs.app crashes during typing (with patch)) Date: Mon, 08 Jun 2009 15:00:04 +0000 Message-ID: References: <87d49eaibg.fsf@cyd.mit.edu> <416FFC32-AFAF-4A82-97AD-057D332C37C2@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1244473204-10495-0" X-Trace: ger.gmane.org 1244474795 31219 80.91.229.12 (8 Jun 2009 15:26:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 8 Jun 2009 15:26:35 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 08 17:26:33 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MDgk3-0002xi-Om for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jun 2009 17:26:32 +0200 Original-Received: from localhost ([127.0.0.1]:48885 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDgk3-0007Av-2R for geb-bug-gnu-emacs@m.gmane.org; Mon, 08 Jun 2009 11:26:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MDgbH-00016S-WF for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2009 11:17:28 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MDgbD-00012y-66 for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2009 11:17:27 -0400 Original-Received: from [199.232.76.173] (port=48670 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MDgbD-00012q-2T for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2009 11:17:23 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:47987) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MDgbB-000826-Pc for bug-gnu-emacs@gnu.org; Mon, 08 Jun 2009 11:17:22 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n58FHJqX014223; Mon, 8 Jun 2009 08:17:19 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n58F04bu010505; Mon, 8 Jun 2009 08:00:04 -0700 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3474 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:28557 Archived-At: This is a multi-part message in MIME format... ------------=_1244473204-10495-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 08 Jun 2009 10:52:51 -0400 with message-id <87d49eaibg.fsf@cyd.mit.edu> and subject line Re: 23.0.94; Emacs.app crashes during typing (with patch) has caused the Emacs bug report #3474, regarding 23.0.94; Emacs.app crashes during typing (with patch) to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3474: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3474 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1244473204-10495-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 5 Jun 2009 11:57:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.9 required=4.0 tests=AWL,MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n55BvpHv016744 for ; Fri, 5 Jun 2009 04:57:53 -0700 Received: from mail.gnu.org ([199.232.76.166]:52301 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1MCY3T-0004vD-3W for emacs-pretest-bug@gnu.org; Fri, 05 Jun 2009 07:57:51 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1MCY3S-0001kZ-Ev for emacs-pretest-bug@gnu.org; Fri, 05 Jun 2009 07:57:50 -0400 Received: from mail-bw0-f211.google.com ([209.85.218.211]:63637) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MCY3S-0001kH-3M for emacs-pretest-bug@gnu.org; Fri, 05 Jun 2009 07:57:50 -0400 Received: by bwz7 with SMTP id 7so83269bwz.42 for ; Fri, 05 Jun 2009 04:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:to:message-id :content-type:from:subject:date:x-mailer; bh=1BpKNqb3B4kA35jLMJbICa0yRsnYdQc0Ai57jCZgb4I=; b=F6TbcQoWYlEtS0ZIRD3yrqQJumq6WyE/mC4/93Yf9yTmUQpfe1g8g601P9Gn1vczT7 /zwAW89pxWTA0Fx1hJ8fEJSvoe1XUrJPGOdl3wIMz0sUupHPI/0qCW8xOblTQXktIu3h nUtBjTWQmEZU6s4fUs21XBD+FTq9ROL3uSwZM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:to:message-id:content-type:from:subject:date:x-mailer; b=A58UUd0F013Fakz1l0qx8xuQFtnOy2nb2rai7YuNoaO8g7rogFDLZoLFAHKpDlEiMF 4u7XxDxe8pGA43FVmvoOO0GkPm//igIYouLkU1j/i5xcQv1covD6yrsmLI72fULGe/rm axRqLr4zWftWg+Tp0aUhZlxLdR4YsP92Fr/yU= Received: by 10.103.213.19 with SMTP id p19mr1088780muq.91.1244203067686; Fri, 05 Jun 2009 04:57:47 -0700 (PDT) Received: from ?212.144.126.125? (dialin-212-144-126-125.pools.arcor-ip.net [212.144.126.125]) by mx.google.com with ESMTPS id 14sm42198muo.3.2009.06.05.04.57.41 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 05 Jun 2009 04:57:47 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v753.1) To: emacs-pretest-bug@gnu.org Message-Id: <416FFC32-AFAF-4A82-97AD-057D332C37C2@gmail.com> Content-Type: multipart/mixed; boundary=Apple-Mail-2--392120180 From: Wolfgang Lux Subject: 23.0.94; Emacs.app crashes during typing (with patch) Date: Fri, 5 Jun 2009 13:57:31 +0200 X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) --Apple-Mail-2--392120180 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I've encountered a few crashes in Emacs.app, which happened while typing when Emacs was a bit busy. It turns out that these crashes were due to an omitted null-pointer check at line 4165 of keyboard.c in function kbd_buffer_get_event(). The attached patch fixes this problem along with a second omitted null-pointer check in line 4323 of the same function. Wolfgang --Apple-Mail-2--392120180 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name=keyboard.patch Content-Disposition: attachment; filename=keyboard.patch --- src/keyboard.c.~1.1005.~ 2009-05-28 17:08:04.000000000 +0200 +++ src/keyboard.c 2009-06-02 13:39:39.000000000 +0200 @@ -4162,7 +4162,8 @@ else obj = Fcons (intern ("ns-unput-working-text"), Qnil); kbd_fetch_ptr = event + 1; - *used_mouse_menu = 1; + if (used_mouse_menu) + *used_mouse_menu = 1; } #endif @@ -4319,7 +4320,8 @@ #endif #ifdef HAVE_NS /* certain system events are non-key events */ - if (event->kind == NS_NONKEY_EVENT) + if (used_mouse_menu + && event->kind == NS_NONKEY_EVENT) *used_mouse_menu = 1; #endif --Apple-Mail-2--392120180-- ------------=_1244473204-10495-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3474-done) by emacsbugs.donarmstrong.com; 8 Jun 2009 14:52:52 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.3 required=4.0 tests=AWL,GMAIL,MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n58EqlmZ009583 for <3474-done@emacsbugs.donarmstrong.com>; Mon, 8 Jun 2009 07:52:48 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id B6A1557E24D; Mon, 8 Jun 2009 10:52:51 -0400 (EDT) From: Chong Yidong To: Adrian Robert Cc: 3474-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.94; Emacs.app crashes during typing (with patch) References: <87vdn7ogt2.fsf@cyd.mit.edu> Date: Mon, 08 Jun 2009 10:52:51 -0400 In-Reply-To: (Adrian Robert's message of "Mon, 8 Jun 2009 15:28:11 +0700") Message-ID: <87d49eaibg.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Adrian Robert writes: >> Adrian, could you review this patch? > > It looks OK to me, I'm checking it in. Other parts of that function > do similar null checks and don't behave specially if they can't set > it. Thanks. ------------=_1244473204-10495-0--