From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#3037: marked as done (23.0.92; rcirc picks incorrect connection settings) Date: Sat, 18 Apr 2009 03:50:03 +0000 Message-ID: References: <87eivqipxg.fsf@cyd.mit.edu> <8763h39t8c.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1240026603-28067-0" X-Trace: ger.gmane.org 1240027483 26487 80.91.229.12 (18 Apr 2009 04:04:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 18 Apr 2009 04:04:43 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 18 06:06:02 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lv1oT-0001x2-Jz for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2009 06:05:58 +0200 Original-Received: from localhost ([127.0.0.1]:54810 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lv1n4-0008N5-I2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 18 Apr 2009 00:04:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lv1mz-0008Ml-P7 for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 00:04:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lv1mv-0008KK-Of for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 00:04:25 -0400 Original-Received: from [199.232.76.173] (port=34187 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lv1mv-0008KD-2z for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 00:04:21 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:41143) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lv1mu-0004d2-8p for bug-gnu-emacs@gnu.org; Sat, 18 Apr 2009 00:04:20 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3I43poO031992; Fri, 17 Apr 2009 21:03:52 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3I3o3wM028092; Fri, 17 Apr 2009 20:50:03 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 3037 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27299 Archived-At: This is a multi-part message in MIME format... ------------=_1240026603-28067-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 17 Apr 2009 23:47:07 -0400 with message-id <87eivqipxg.fsf@cyd.mit.edu> and subject line Re: 23.0.92; rcirc picks incorrect connection settings has caused the Emacs bug report #3037, regarding 23.0.92; rcirc picks incorrect connection settings to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 3037: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D3037 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1240026603-28067-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 17 Apr 2009 21:31:29 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3HLVDUZ018864 for ; Fri, 17 Apr 2009 14:31:27 -0700 Received: from mail.gnu.org ([199.232.76.166]:39625 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LuqIl-0002wV-5j for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 11:48:27 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LuqIk-0002hp-2p for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 11:48:26 -0400 Received: from ey-out-1920.google.com ([74.125.78.148]:54445) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LuqIi-0002hF-Pb for emacs-pretest-bug@gnu.org; Fri, 17 Apr 2009 11:48:25 -0400 Received: by ey-out-1920.google.com with SMTP id 13so180130eye.24 for ; Fri, 17 Apr 2009 08:48:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:user-agent :face:date:message-id:mime-version:content-type; bh=tJI9e3zpnL+GxeUmz37nATax/fnPIJDZwLbVXDfvQAM=; b=rUZwmkuO/zCC8EQPKo/qfZE3tVHPYR9slomkvjkx5LTSe4s/Cme7OUDIt434QSUso/ +Mbso6VdGX+E8BSlwlT7ucl6HGN4crO0ho9kHUjq/VAIQ5j+67Dz1Y6AyOgzF/2HmPng jSog1KnFGeklB+djYQY0b8+XaGokYQicTmAK4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:user-agent:face:date:message-id:mime-version :content-type; b=Gbh+iHS7+phTS64BIO9cL8KqcX0mnCoZ8cm81Gy9KLrux2Q40KLKpqxb2MHJl5y61v zYqXelZ4viEF4IXBjRVHAM9tZ46YMu7q0lDtKD80j5VarU8pnqU0CGV3Wyemw+4ofmYo DfIVwK6L9kdYek6DW60SiDd8eZwGs0s5A3Yf4= Received: by 10.216.29.208 with SMTP id i58mr532670wea.85.1239983301716; Fri, 17 Apr 2009 08:48:21 -0700 (PDT) Received: from siav.hodique.info (AGrenoble-751-1-39-113.w92-150.abo.wanadoo.fr [92.150.242.113]) by mx.google.com with ESMTPS id p10sm81859gvf.4.2009.04.17.08.48.20 (version=SSLv3 cipher=RC4-MD5); Fri, 17 Apr 2009 08:48:21 -0700 (PDT) From: Yann Hodique To: emacs-pretest-bug@gnu.org Subject: 23.0.92; rcirc picks incorrect connection settings User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.92 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJ1BMVEUEBgMUFBEnIR07MStT QjlvWkyEbl2ccWaVe2mpi3qxj3bDoIz+//wlCgCYAAACWUlEQVQ4EQXBQXIVVRQA0HNvGPNvJ45J 98epQhIdK6ALsNyA63EPLsEtWFQ5FlLFVDodHVr8fh0dQj/PSQAAgAQAAEgAGG4mEKoSAKyGgerV WgIIxKBoWkgAh2GwRmwjqkuAyPNpsNYh0UQCVMXFNA3DVCNVPQFy+PH6qxfD0CJCaxKgIr97+er5 2u56VyUBhouxb49evZjqSNsiAdrBEu2/r6/H+6L3BITMQdX556+UEAmo0nvheP3DpFdPwOAqCvrZ TbBFAnHgMiCclRjGBOLhAmBzpM4T6Mfr8w3othGJc+J63AuwX+qn94kr8sgJQNNa4jSaWNdf30At 9w1JXhzHYoirT7fwpDNI8ubm6TlWw4r+184aSX/08urKsa+vpyv++eWPFT0Jj4JlOv4UXX/d17eU 5BNTa2MeLfppev6i2CT9dqcW8njb3np32+iSmpM2whft2cPoDJL2D2D/eHF/64mgKvFhsZvJsw/d ZdautpboP9+GxKd3z+JwcNK6hLkF+L0P9e+73lRI6F0H4qkvd7ZeCYzgG/PdaBW9WgLLwjzfXX7Y vL+rbosExb6vYluet7ulqd4TMLZFU/Xbx1NTm0ro3HN1mudhX060Q7WEmE5jrfk03ebdAlsl+LuW bpm+NY19URWHLSHGsbdZm4fH86nQVQLn+5ytnR2tc9O2h23NKtR0ue7z3v+cTwt1eaghI4ZhaDn1 u97Wpc2Ndt9aS8TAxXn/8P5Nv1uJDFUZnMba43pa53UN9H2vLjufPX/IiJtjnZYJojqp9zEek2c3 399MhRAR/gfpVBU4QWr2iwAAAABJRU5ErkJggg== Date: Fri, 17 Apr 2009 17:48:19 +0200 Message-ID: <8763h39t8c.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) When using `rcirc' with argument (prompt for connection parameters), the global default values for :port, :nick and :channels are proposed instead of the server-specific ones. Reason is that current code tries to get properties 'port, 'nick and 'channels, which is not correct. Following patch fixes this issue. Yann. diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index f63237f..1f31284 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -375,16 +375,16 @@ If ARG is non-nil, instead prompt for connection parameters." (server-plist (cdr (assoc-string server rcirc-server-alist))) (port (read-string "IRC Port: " (number-to-string - (or (plist-get server-plist 'port) + (or (plist-get server-plist :port) rcirc-default-port)))) (nick (read-string "IRC Nick: " - (or (plist-get server-plist 'nick) + (or (plist-get server-plist :nick) rcirc-default-nick))) (channels (split-string (read-string "IRC Channels: " (mapconcat 'identity (plist-get server-plist - 'channels) + :channels) " ")) "[, ]+" t))) (rcirc-connect server port nick rcirc-default-user-name -- "Once more the drama begins." -The Emperor Paul Muad'dib on his ascension to the Lion Throne ------------=_1240026603-28067-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 3037-done) by emacsbugs.donarmstrong.com; 18 Apr 2009 03:45:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3I3jGWB027869 for <3037-done@emacsbugs.donarmstrong.com>; Fri, 17 Apr 2009 20:45:17 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 1D01457E21C; Fri, 17 Apr 2009 23:47:07 -0400 (EDT) From: Chong Yidong To: Yann Hodique Cc: Ryan Yeske , 3037-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.92; rcirc picks incorrect connection settings Date: Fri, 17 Apr 2009 23:47:07 -0400 Message-ID: <87eivqipxg.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > When using `rcirc' with argument (prompt for connection parameters), the > global default values for :port, :nick and :channels are proposed > instead of the server-specific ones. > > Reason is that current code tries to get properties 'port, 'nick > and 'channels, which is not correct. > Following patch fixes this issue. I've checked in your patch. Thanks. ------------=_1240026603-28067-0--