From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2872: marked as done (diff from log-view not working for bzr) Date: Tue, 07 Apr 2009 01:55:04 +0000 Message-ID: References: <87k55x8c4o.fsf@cyd.mit.edu> <200904030209.n3329uQj012191@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1239069304-25886-0" X-Trace: ger.gmane.org 1239069927 2172 80.91.229.12 (7 Apr 2009 02:05:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 7 Apr 2009 02:05:27 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 07 04:06:45 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Lr0i5-0004Bb-0u for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Apr 2009 04:06:45 +0200 Original-Received: from localhost ([127.0.0.1]:49109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lr0gg-0005oX-Tc for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Apr 2009 22:05:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lr0fM-0005IK-Bh for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2009 22:03:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lr0fH-0005G0-BL for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2009 22:03:55 -0400 Original-Received: from [199.232.76.173] (port=47762 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lr0fH-0005Fu-5k for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2009 22:03:51 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40907) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Lr0fG-0008C4-Gy for bug-gnu-emacs@gnu.org; Mon, 06 Apr 2009 22:03:50 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3723m0i028470; Mon, 6 Apr 2009 19:03:48 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n371t4d1026047; Mon, 6 Apr 2009 18:55:05 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2872 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26950 Archived-At: This is a multi-part message in MIME format... ------------=_1239069304-25886-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 06 Apr 2009 21:51:19 -0400 with message-id <87k55x8c4o.fsf@cyd.mit.edu> and subject line Re: diff from log-view not working for bzr has caused the Emacs bug report #2872, regarding diff from log-view not working for bzr to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2872: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2872 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1239069304-25886-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 3 Apr 2009 02:11:56 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n332BrM1004153 for ; Thu, 2 Apr 2009 19:11:54 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LpYsq-0006xV-Tc for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LpYsl-0006xA-GM for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:51 -0400 Received: from [199.232.76.173] (port=40772 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LpYsl-0006x7-AP for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:47 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:51803) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1LpYsk-0005bn-Q5 for bug-gnu-emacs@gnu.org; Thu, 02 Apr 2009 22:11:47 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n3329vYo001028 for ; Thu, 2 Apr 2009 19:09:57 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n3329uQj012191; Thu, 2 Apr 2009 19:09:56 -0700 (PDT) Date: Thu, 2 Apr 2009 19:09:56 -0700 (PDT) Message-Id: <200904030209.n3329uQj012191@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: diff from log-view not working for bzr X-Debbugs-No-Ack: yes Lines: 30 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n3329vYo001028 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_BZ 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) Do a C-x v l on any file under bzr. Put the point on some random log entry and type d And empty *vc-diff* window will appear. The problem is that vc-bzr-diff gets called with the arguments REV1 == REV2. And that happens because of this code in log-view-diff: (log-view-msg-next) (setq to (log-view-current-tag)) [1] Given a log entry like this: ------------------------------------------------------------ revno: 295 `log-view-msg-next' puts the point at the beginning of the ---- line and `log-view-current-tag' returns the version of the _previous_ log entry. It happens because `log-view-current-tag' first does a (forward-line 1) --> point will be at "revno" after that. And then (re-search-backward log-view-message-re nil t) which will find the current log entry. So in conclusion code [1] fails to advance and find the next log entry. ------------=_1239069304-25886-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2872-done) by emacsbugs.donarmstrong.com; 7 Apr 2009 01:49:42 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n371ndl1024572 for <2872-done@emacsbugs.donarmstrong.com>; Mon, 6 Apr 2009 18:49:40 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 7521957E18A; Mon, 6 Apr 2009 21:51:19 -0400 (EDT) From: Chong Yidong To: Dan Nicolaescu Cc: 2872-done@emacsbugs.donarmstrong.com Subject: Re: diff from log-view not working for bzr Date: Mon, 06 Apr 2009 21:51:19 -0400 Message-ID: <87k55x8c4o.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > Do a C-x v l on any file under bzr. > > Put the point on some random log entry and type > d > And empty *vc-diff* window will appear. I've checked in a fix. ------------=_1239069304-25886-0--