From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: bug-gnu-emacs@gnu.org (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2747: marked as done ([PATCH] 23.0.91; multi-line tooltips don't work on nextstep) Date: Mon, 04 Jan 2010 06:26:01 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1262586361-23311-2" X-Trace: ger.gmane.org 1262587790 14346 80.91.229.12 (4 Jan 2010 06:49:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Jan 2010 06:49:50 +0000 (UTC) Cc: emacs-bug-tracker@debbugs.gnu.org To: David Reitter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 04 07:49:43 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NRgl4-0007kX-HB for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jan 2010 07:49:43 +0100 Original-Received: from localhost ([127.0.0.1]:42223 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRgl4-0001d4-UG for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Jan 2010 01:49:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NRgky-0001cg-5m for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2010 01:49:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NRgkt-0001bK-4E for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2010 01:49:35 -0500 Original-Received: from [199.232.76.173] (port=36461 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NRgki-0001YE-JC; Mon, 04 Jan 2010 01:49:20 -0500 Original-Received: from [140.186.70.43] (port=38064 helo=debbugs.gnu.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NRgkh-0004zW-O9; Mon, 04 Jan 2010 01:49:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NRgO9-000643-S5; Mon, 04 Jan 2010 01:26:01 -0500 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: closed 2747 X-Emacs-PR-Package: emacs,ns X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:33917 Archived-At: This is a multi-part message in MIME format... ------------=_1262586361-23311-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 4 Jan 2010 07:25:24 +0100 with message-id and subject line done has caused the Emacs bug report #2278, regarding [PATCH] 23.0.91; multi-line tooltips don't work on nextstep to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org immediately.) --=20 2278: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D2278 Emacs Bug Tracking System Contact bug-gnu-emacs@gnu.org with problems ------------=_1262586361-23311-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 22 Mar 2009 17:47:00 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2MHkvJf026608 for ; Sun, 22 Mar 2009 10:46:58 -0700 Received: from mx10.gnu.org ([199.232.76.166]:57582) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LlRlA-00014T-CA for emacs-pretest-bug@gnu.org; Sun, 22 Mar 2009 13:46:56 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LlRl8-0004s6-8z for emacs-pretest-bug@gnu.org; Sun, 22 Mar 2009 13:46:56 -0400 Received: from dd18200.kasserver.com ([85.13.138.168]:49931) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LlRl7-0004rq-MS for emacs-pretest-bug@gnu.org; Sun, 22 Mar 2009 13:46:53 -0400 Received: from thursday (unknown [78.52.32.58]) by dd18200.kasserver.com (Postfix) with ESMTP id B74C7182E2EB1 for ; Sun, 22 Mar 2009 18:46:55 +0100 (CET) From: Nikolaj Schumacher To: emacs-pretest-bug@gnu.org Subject: [PATCH] 23.0.91; multi-line tooltips don't work on nextstep User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (darwin) Date: Sun, 22 Mar 2009 18:46:51 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-03-22 on thursday Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns' '--with-x'' Only the first line multi-line tooltips like (tooltip-show "foo\nbar") appear on nextstep. The following patch seems to be a simple (perhaps too simple?) solution: diff --git a/src/nsmenu.m b/src/nsmenu.m index 9a97492..97d29e9 100644 --- a/src/nsmenu.m +++ b/src/nsmenu.m @@ -1398,10 +1398,7 @@ update_frame_tool_bar (FRAME_PTR f) NSColor *col = [NSColor colorWithCalibratedRed: 1.0 green: 1.0 blue: 0.792 alpha: 0.95]; NSFont *font = [NSFont toolTipsFontOfSize: 0]; - NSFont *sfont = [font screenFont]; - int height = [sfont ascender] - [sfont descender]; -/*[font boundingRectForFont].size.height; */ - NSRect r = NSMakeRect (0, 0, 100, height+6); + NSRect r = NSMakeRect (0, 0, 100, 100); textField = [[NSTextField alloc] initWithFrame: r]; [textField setFont: font]; @@ -1438,10 +1435,8 @@ update_frame_tool_bar (FRAME_PTR f) - (void) setText: (char *)text { NSString *str = [NSString stringWithUTF8String: text]; - NSRect r = [textField frame]; - r.size.width = [[[textField font] screenFont] widthOfString: str] + 8; - [textField setFrame: r]; [textField setStringValue: str]; + [textField sizeToFit]; } - (void) showAtX: (int)x Y: (int)y for: (int)seconds ------------=_1262586361-23311-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2278-done) by debbugs.gnu.org; 4 Jan 2010 06:25:49 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRgNw-00063o-VL for submit@debbugs.gnu.org; Mon, 04 Jan 2010 01:25:49 -0500 Received: from mail-ew0-f222.google.com ([209.85.219.222]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NRgNj-00063h-G0 for 2278-done@debbugs.gnu.org; Mon, 04 Jan 2010 01:25:48 -0500 Received: by ewy22 with SMTP id 22so16333453ewy.39 for <2278-done@debbugs.gnu.org>; Sun, 03 Jan 2010 22:25:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:content-type :content-transfer-encoding:subject:date:message-id:to:mime-version :x-mailer; bh=hUXA1ZyaRFuhlHNZNArD2vK+Ul77bbPoxgUkemA4DR8=; b=C6jMD7k0jZxM+z4It5ZyZT8yLvj/tPY3i5g7QOvSBX3f93zRqe9x4Ef1ZuUEwQis0t Qv7LjfJuvuiYqHReRvfInjTiLsb6ej+UDKR32HE4yGzHjy30WV5GgB8fJC0BA7lFgJbC n+5IMkbM+SfYm1KJTAmOkPvWthrQFcWxBAYm0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:content-type:content-transfer-encoding:subject:date:message-id :to:mime-version:x-mailer; b=Y4m6CeqD/iExVfqq2Y8qf3OE3uru5CItvhpPm1tzKDnqLmul9z7LgnPPBQOPo+9cqv Vl0KG2FUbBg3b1jz+3W2ZwyeU3ERp+QndVxF6nj72pYV+m+hWDZ7ib5Oz+w0PPsMESS0 T4sMnRZTAq9HS/KadUvqxEp6D2x1ELc2AeJqQ= Received: by 10.213.25.79 with SMTP id y15mr20940739ebb.24.1262586327382; Sun, 03 Jan 2010 22:25:27 -0800 (PST) Received: from ?192.168.0.182? ([72.14.240.162]) by mx.google.com with ESMTPS id 14sm12402069ewy.7.2010.01.03.22.25.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 03 Jan 2010 22:25:26 -0800 (PST) From: David Reitter Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: done Date: Mon, 4 Jan 2010 07:25:24 +0100 Message-Id: To: 2278-done@debbugs.gnu.org Mime-Version: 1.0 (Apple Message framework v1077) X-Mailer: Apple Mail (2.1077) X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 2278-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) patch was checked in 2009-06-14. ------------=_1262586361-23311-2--