all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: don@donarmstrong.com (Emacs bug Tracking System)
To: Glenn Morris <rgm@gnu.org>
Subject: bug#262: marked as done (23.0.60; vc-hg-annotate-command version  number bug + patch)
Date: Thu, 29 May 2008 15:40:07 -0700	[thread overview]
Message-ID: <handler.262.D262.12121003682733.ackdone@emacsbugs.donarmstrong.com> (raw)
In-Reply-To: m3prrm80dj.fsf@10-1-2-210.dhcp.pas.lab

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]


Your message dated Thu, 29 May 2008 18:30:58 -0400
with message-id <k97idclp3x.fsf@fencepost.gnu.org>
and subject line Re: bug#262: 23.0.60; vc-hg-annotate-command version number bug + patch
has caused the Emacs bug report #262,
regarding 23.0.60; vc-hg-annotate-command version number bug + patch
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
262: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=262
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5745 bytes --]

From: David Hull <david@snap.com>
From: David Hull <hull@snap.com>
To: emacs-pretest-bug@gnu.org
Cc: 
Subject: 23.0.60; vc-hg-annotate-command version number bug + patch
Date: Fri, 16 May 2008 13:22:48 -0700
Message-ID: <m3prrm80dj.fsf@10-1-2-210.dhcp.pas.lab>

There is a small problem in the function vc-hg-annotate-command that
causes the code that deletes up to the first line of the sources to
delete too far if the first line of sources starts with a space, such
as the following:

 0 Fri Apr 25 18:04:19 2008 -0700: #! /usr/bin/perl
 0 Fri Apr 25 18:04:19 2008 -0700: 
36 Tue May 13 17:55:19 2008 -0700: my @fields = @{$e->{field}};

This patch fixes the problem:

Index: vc-hg.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/vc-hg.el,v
retrieving revision 1.77
diff -u -r1.77 vc-hg.el
--- vc-hg.el    15 May 2008 17:38:47 -0000      1.77
+++ vc-hg.el    16 May 2008 19:49:59 -0000
@@ -288,8 +288,8 @@
                 (when revision (concat "-r" revision)))
   (with-current-buffer buffer
     (goto-char (point-min))
-    (re-search-forward "^[0-9]")
-    (delete-region (point-min) (1- (point)))))
+    (re-search-forward "^[ \t]*[0-9]")
+    (delete-region (point-min) (match-beginning 0))))
 
 
 ;; The format for one line output by "hg annotate -d -n" looks like this:

-- 
David Hull





[-- Attachment #3: Type: message/rfc822, Size: 1474 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: 262-done@emacsbugs.donarmstrong.com
Subject: Re: bug#262: 23.0.60; vc-hg-annotate-command version number bug + patch
Date: Thu, 29 May 2008 18:30:58 -0400
Message-ID: <k97idclp3x.fsf@fencepost.gnu.org>




      parent reply	other threads:[~2008-05-29 22:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <k97idclp3x.fsf@fencepost.gnu.org>
2008-05-16 20:22 ` 23.0.60; vc-hg-annotate-command version number bug + patch David Hull
2008-05-17 15:18   ` Dan Nicolaescu
2008-05-29 22:40   ` Emacs bug Tracking System [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=handler.262.D262.12121003682733.ackdone@emacsbugs.donarmstrong.com \
    --to=don@donarmstrong.com \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.