From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)
To: Glenn Morris <rgm@gnu.org>
Subject: bug#2533: marked as done (23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring)
Date: Thu, 05 Mar 2009 05:35:05 +0000 [thread overview]
Message-ID: <handler.2533.D2533.123623080213038.ackdone@emacsbugs.donarmstrong.com> (raw)
In-Reply-To: 200903020125.n221P3dY004861@zogzog.maillard.mobi
[-- Attachment #1: Type: text/plain, Size: 936 bytes --]
Your message dated Thu, 5 Mar 2009 00:26:32 -0500
with message-id <18863.25224.639908.749606@fencepost.gnu.org>
and subject line Re: bug#2533: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring
has caused the Emacs bug report #2533,
regarding 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
2533: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2533
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 6388 bytes --]
From: Xavier Maillard <xma@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring
Date: Mon, 2 Mar 2009 02:25:03 +0100
Message-ID: <200903020125.n221P3dY004861@zogzog.maillard.mobi>
When using keys 'a' or 'k' in a `rmail-summary' buffer, it is not
obvious user can type multiple labels as "comma-separated list of
labels". OTOH, it is clearly announced when user wants to
summarize by labels. The patch enclosed tries to clarify this.
Hope that'll help.
ChangeLog proposed:
2009-03-01 Xavier Maillard <xma@gnu.org>
* mail/rmailsum.el (rmail-summary-add-label)
(rmail-summary-kill-label): Fix docstrings. Indicate user can type
multiple comma-separted list of labels.
Patch:
diff --git a/lisp/mail/rmailsum.el b/lisp/mail/rmailsum.el
index 6940f3d..1ae0bd9 100644
--- a/lisp/mail/rmailsum.el
+++ b/lisp/mail/rmailsum.el
@@ -1542,7 +1542,8 @@ Interactively, empty argument means use same regexp used last time."
(defun rmail-summary-add-label (label)
"Add LABEL to labels associated with current Rmail message.
-Completion is performed over known labels when reading."
+Completion is performed over known labels when reading.
+LABEL may be a comma-separated list of labels."
(interactive (list (save-excursion
(set-buffer rmail-buffer)
(rmail-read-label "Add label"))))
@@ -1552,7 +1553,8 @@ Completion is performed over known labels when reading."
(defun rmail-summary-kill-label (label)
"Remove LABEL from labels associated with current Rmail message.
-Completion is performed over known labels when reading."
+Completion is performed over known labels when reading.
+LABEL may be a comma-separated list of labels."
(interactive (list (save-excursion
(set-buffer rmail-buffer)
(rmail-read-label "Kill label"))))
Recent input:
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <up> <up> <up> <up>
<up> <up> <up> <up> <up> <up> <up> <down> <down> <down>
<down> <down> <down> <up> C-x u C-x u C-SPC C-w C-SPC
C-a M-w C-x b <return> C-s C-s C-s C-s <return> <down>
<down> <down> <left> <left> <left> <left> <left> <left>
<left> <left> <left> <left> <left> <left> <left> <left>
<left> <left> <left> <left> <left> <left> <left> <left>
<left> <left> C-y <left> <left> <left> <left> <left>
<left> <left> <left> <left> <left> <left> <left> <left>
<left> <left> <left> <left> <left> <left> <left> <left>
<left> <left> <left> <left> <left> <left> <left> <left>
<left> <left> C-SPC <right> <right> <right> <right>
<right> <right> C-w <right> <right> <right> <right>
<right> <right> <right> <right> C-x b x m a - s u <tab>
<return> a ' t e s t <return> k g n u <tab> - e m <tab>
<return> k ' t e <tab> <return> k e <backspace> t e
s <tab> t SPC <backspace> <backspace> <backspace> <backspace>
t e s t <return> k <return> <up> <down> SPC C-x C-b
<up> <up> <return> C-x 1 <right> C-SPC <right> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> C-w <right> <right> <right> <right> <right>
<right> C-SPC <right> <right> <right> C-w <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> C-a C-SPC C-e <left> M-w <down>
<down> <down> <down> <down> <down> <down> <down> <down>
<down> <down> <up> C-e <return> C-y <down> <up> C-SPC
<down> <left> C-w C-x C-s C-x v = <switch-frame> C-x
1 <down> M-k C-x 1 C-x 1 <right> <left> C-x 0 C-x b
C-g C-x 1 C-x b <return> C-x 1 C-l / b <switch-frame>
C-x 5 0 M-x e m <backspace> <backspace> r e p o r t
- e m <tab> <return>
Recent messages:
Mark activated
Updating buffer list...
Mark set
Updating buffer list...done
Commands: m, u, t, RET, g, k, S, D, Q; q to quit; h for help
Mark set [5 times]
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/rmailsum.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/rmailsum.el
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/rmailsum.el...
call-interactively: Attempt to delete minibuffer or sole ordinary window
Quit
Xavier
--
http://www.gnu.org
http://www.april.org
http://www.lolica.org
[-- Attachment #3: Type: message/rfc822, Size: 1756 bytes --]
From: Glenn Morris <rgm@gnu.org>
To: 2533-done@emacsbugs.donarmstrong.com
Subject: Re: bug#2533: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring
Date: Thu, 5 Mar 2009 00:26:32 -0500
Message-ID: <18863.25224.639908.749606@fencepost.gnu.org>
tags 2533 notabug wontfix
stop
Glenn Morris wrote (on Thu, 5 Mar 2009 at 00:20 -0500):
> If you try to add mutiple labels without spaces after the comma, it
> won't work right.
And it certainly does not work in the kill case, unless you happen to
specify the labels in the same order as they appear.
It's just a coincidence that these commands may sometimes work for
multiple labels.
next prev parent reply other threads:[~2009-03-05 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <18863.25224.639908.749606@fencepost.gnu.org>
2009-03-02 1:25 ` bug#2533: 23.0.90; [PATCH] rmail: improve rmail-add/kill-label docstring Xavier Maillard
2009-03-05 5:20 ` Glenn Morris
2009-03-05 5:35 ` Emacs bug Tracking System [this message]
2009-03-05 5:35 ` Processed: " Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=handler.2533.D2533.123623080213038.ackdone@emacsbugs.donarmstrong.com \
--to=owner@emacsbugs.donarmstrong.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.