* bug#2478: 23.0.91; font antialiasing switch in nextstep broken
2009-02-26 8:29 ` bug#2478: 23.0.91; font antialiasing switch in nextstep broken Nikolaj Schumacher
@ 2009-02-26 15:26 ` Stefan Monnier
2009-03-05 3:48 ` Glenn Morris
2009-05-31 5:55 ` bug#2478: marked as done (23.0.91; font antialiasing switch in nextstep broken) Emacs bug Tracking System
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Monnier @ 2009-02-26 15:26 UTC (permalink / raw
To: Nikolaj Schumacher; +Cc: emacs-pretest-bug, 2478
> --- a/src/nsfont.m
> +++ b/src/nsfont.m
> @@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
> CGContextSetFont (gcontext, font->cgfont);
> CGContextSetFontSize (gcontext, font->size);
> - if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
> + if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
> CGContextSetShouldAntialias (gcontext, 0);
> else
> CGContextSetShouldAntialias (gcontext, 1);
If someone could try and compile the Emacs.app port
with -DUSE_LISP_UNION_TYPE, this bug (and probably several others) would
get caught during compilation.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* bug#2478: marked as done (23.0.91; font antialiasing switch in nextstep broken)
2009-02-26 8:29 ` bug#2478: 23.0.91; font antialiasing switch in nextstep broken Nikolaj Schumacher
2009-02-26 15:26 ` Stefan Monnier
2009-03-05 3:48 ` Glenn Morris
@ 2009-05-31 5:55 ` Emacs bug Tracking System
2 siblings, 0 replies; 4+ messages in thread
From: Emacs bug Tracking System @ 2009-05-31 5:55 UTC (permalink / raw
To: Adrian Robert
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
Your message dated Sun, 31 May 2009 12:49:28 +0700
with message-id <8EB23D91-883D-4FEF-9740-26C18FF8DAFD@gmail.com>
and subject line
has caused the Emacs bug report #2478,
regarding 23.0.91; font antialiasing switch in nextstep broken
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
2478: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2478
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 3130 bytes --]
From: Nikolaj Schumacher <me@nschum.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.91; font antialiasing switch in nextstep broken
Date: Thu, 26 Feb 2009 09:29:06 +0100
Message-ID: <m2r61l1u0d.fsf@nschum.de>
Hello,
switching font antialiasing in nextstep doesn't work. A fix is included.
regards,
Nikolaj Schumacher
In GNU Emacs 23.0.91.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
of 2009-02-26 on thursday
Windowing system distributor `Apple', version 10.3.949
configured using `configure '--with-ns' '--without-x' 'CC=gcc-4.2' 'CFLAGS=-arch i386 -O2''
diff --git a/src/nsfont.m b/src/nsfont.m
index 386637d..e2e537f 100644
--- a/src/nsfont.m
+++ b/src/nsfont.m
@@ -1053,7 +1053,7 @@ nsfont_draw (struct glyph_string *s, int from, int to, int
CGContextSetFont (gcontext, font->cgfont);
CGContextSetFontSize (gcontext, font->size);
- if (ns_antialias_text == NO || font->size <= ns_antialias_threshold)
+ if (ns_antialias_text == Qnil || font->size <= ns_antialias_threshold)
CGContextSetShouldAntialias (gcontext, 0);
else
CGContextSetShouldAntialias (gcontext, 1);
[-- Attachment #3: Type: message/rfc822, Size: 2465 bytes --]
From: Adrian Robert <adrian.b.robert@gmail.com>
To: 2478-done@emacsbugs.donarmstrong.com
Subject:
Date: Sun, 31 May 2009 12:49:28 +0700
Message-ID: <8EB23D91-883D-4FEF-9740-26C18FF8DAFD@gmail.com>
^ permalink raw reply related [flat|nested] 4+ messages in thread