From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2397: marked as done (23.0.90; grep no longer highlights the match) Date: Sat, 28 Feb 2009 17:50:03 +0000 Message-ID: References: <011f01c992e9$854a3cc0$c2b22382@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1235843403-3672-0" X-Trace: ger.gmane.org 1235844283 27260 80.91.229.12 (28 Feb 2009 18:04:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 28 Feb 2009 18:04:43 +0000 (UTC) To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 28 19:05:58 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LdTYn-0008VO-5p for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2009 19:05:38 +0100 Original-Received: from localhost ([127.0.0.1]:41609 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdTXS-0006Q7-BG for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Feb 2009 13:03:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LdTXN-0006Pr-5k for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2009 13:03:45 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LdTXM-0006Pe-HO for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2009 13:03:44 -0500 Original-Received: from [199.232.76.173] (port=44222 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LdTXM-0006PX-AG for bug-gnu-emacs@gnu.org; Sat, 28 Feb 2009 13:03:44 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:48367) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LdTXJ-00028Q-Ug; Sat, 28 Feb 2009 13:03:42 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1SI3cBY007554; Sat, 28 Feb 2009 10:03:38 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1SHo3Ou003714; Sat, 28 Feb 2009 09:50:03 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2397 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25857 Archived-At: This is a multi-part message in MIME format... ------------=_1235843403-3672-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Sat, 28 Feb 2009 19:42:33 +0200 with message-id and subject line Re: bug#2397: 23.0.90; grep no longer highlights the match has caused the Emacs bug report #2397, regarding 23.0.90; grep no longer highlights the match to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2397: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2397 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1235843403-3672-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 19 Feb 2009 23:26:45 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1JNQc4U008434 for ; Thu, 19 Feb 2009 15:26:39 -0800 Received: from mx10.gnu.org ([199.232.76.166]:51308) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LaIFp-0004cr-Dj for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 18:24:29 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LaIHs-0001rO-LB for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 18:26:37 -0500 Received: from rcsinet12.oracle.com ([148.87.113.124]:44619 helo=rgminet12.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LaIHs-0001rG-B0 for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 18:26:36 -0500 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1JNQW4Y011706 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Feb 2009 23:26:33 GMT Received: from acsmt700.oracle.com (acsmt700.oracle.com [141.146.40.70]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1JNQV1r017004 for ; Thu, 19 Feb 2009 23:26:33 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 19 Feb 2009 15:26:29 -0800 From: "Drew Adams" To: Subject: 23.0.90; grep no longer highlights the match Date: Thu, 19 Feb 2009 15:26:41 -0800 Message-ID: <011f01c992e9$854a3cc0$c2b22382@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 Thread-Index: AcmS6YTmtoP0BBShQVezwEtGCqmHgg== X-Source-IP: acsmt700.oracle.com [141.146.40.70] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A09020B.499DEAA7.02B1:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) emacs -Q load library cygwin-mount.el, then setup-cygwin.el: http://www.emacswiki.org/emacs/cygwin-mount.el http://www.emacswiki.org/emacs/setup-cygwin.el M-x grep -nH -e pattern *.el The text matching "pattern" is not highlighted. In Emacs 22 it is highlighted using face `match' (yellow background). In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600) of 2009-02-01 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)' ------------=_1235843403-3672-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2397-done) by emacsbugs.donarmstrong.com; 28 Feb 2009 17:43:48 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mtaout1.012.net.il (mtaout1.012.net.il [84.95.2.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1SHhhjq002289 for <2397-done@emacsbugs.donarmstrong.com>; Sat, 28 Feb 2009 09:43:45 -0800 Received: from conversion-daemon.i-mtaout1.012.net.il by i-mtaout1.012.net.il (HyperSendmail v2007.08) id <0KFS00M00DMK9700@i-mtaout1.012.net.il> for 2397-done@emacsbugs.donarmstrong.com; Sat, 28 Feb 2009 19:43:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.127.167.119]) by i-mtaout1.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KFS005G1EJU6FC0@i-mtaout1.012.net.il>; Sat, 28 Feb 2009 19:43:08 +0200 (IST) Date: Sat, 28 Feb 2009 19:42:33 +0200 From: Eli Zaretskii Subject: Re: bug#2397: 23.0.90; grep no longer highlights the match In-reply-to: <009a01c9961a$b2105260$0200a8c0@us.oracle.com> X-012-Sender: halo1@inter.net.il To: Drew Adams , 2397-done@emacsbugs.donarmstrong.com Cc: juri@jurta.org Reply-to: Eli Zaretskii Message-id: References: <011f01c992e9$854a3cc0$c2b22382@us.oracle.com> <000f01c99516$f20a9a10$0200a8c0@us.oracle.com> <874oymnvx3.fsf@jurta.org> <001601c99528$b5b2e380$0200a8c0@us.oracle.com> <87bpsudt0z.fsf@jurta.org> <001a01c9953c$c2119b80$0200a8c0@us.oracle.com> <877i3iccew.fsf@jurta.org> <001c01c99543$49c16b90$0200a8c0@us.oracle.com> <87ljry6nk7.fsf@jurta.org> <009a01c9961a$b2105260$0200a8c0@us.oracle.com> > From: "Drew Adams" > Date: Mon, 23 Feb 2009 16:56:14 -0800 > Cc: 2397@emacsbugs.donarmstrong.com > > > >> Could you also try running grep from Bash (not from Emacs) > > >> with options "--color=always" and "--color=auto" and see whether > > >> it outputs highlighting sequences for both cases in a standalone > > >> shell? > > > > > > Yes, both produce the highlighting. > > > It is apparently only in Emacs that --color=auto does not work. > > > > Weird. Maybe a Windows guru could explain the difference. > > I think it's an Emacs guru that's needed (perhaps with some Windows, Cygwin, or > GNU bash knowledge). I think this has nothing to do with either Cygwin or Bash. Drew, could you please verify that the same problem happens for you in "emacs -Q" without loading cygwin-mount.el and setup-cygwin.el? AFAICT, this problem happens because Emacs on Windows invokes subsidiary programs through a pipe, and that pipe fails the `isatty' test in Grep. So "--color=auto" can never work on MS-Windows when Grep is invoked by Emacs. I ``fixed'' this by going back, on DOS/Windows only, to the "--color=always" way we used before Juri installed his 2007-11-23 changes. It's true that this will reinstate the original problem with multiple grep invocations in a pipe (on Windows and DOS only), but I don't see how can that use-case be solved, and having a single instance of grep in the command is by far more frequent usage. Here's the change I installed. Drew, could you please see if it works for you as well? 2009-02-28 Eli Zaretskii * progmodes/grep.el (grep-process-setup) [windows-nt msdos]: Use "--color=always". Index: lisp/progmodes/grep.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/progmodes/grep.el,v retrieving revision 1.99 retrieving revision 1.100 diff -u -r1.99 -r1.100 --- lisp/progmodes/grep.el 25 Jan 2009 00:54:53 -0000 1.99 +++ lisp/progmodes/grep.el 28 Feb 2009 17:24:29 -0000 1.100 @@ -407,7 +407,11 @@ ;; `--color=auto' emits escape sequences on a tty rather than on a pipe, ;; thus allowing to use multiple grep filters on the command line ;; and to output escape sequences only on the final grep output - (setenv "GREP_OPTIONS" (concat (getenv "GREP_OPTIONS") " --color=auto")) + (setenv "GREP_OPTIONS" + (concat (getenv "GREP_OPTIONS") + ;; Windows and DOS pipes fail `isatty' detection in Grep. + " --color=" (if (memq system-type '(windows-nt ms-dos)) + "always" "auto"))) ;; GREP_COLOR is used in GNU grep 2.5.1, but deprecated in later versions (setenv "GREP_COLOR" "01;31") ;; GREP_COLORS is used in GNU grep 2.5.2 and later versions ------------=_1235843403-3672-0--