From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2388: marked as done (23.0.90; wrong-type-argument in vc-dir) Date: Wed, 15 Apr 2009 00:40:04 +0000 Message-ID: References: <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu> <87zlgi1p9f.fsf@tnei.co.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1239756004-16950-0" X-Trace: ger.gmane.org 1239756275 1430 80.91.229.12 (15 Apr 2009 00:44:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 15 Apr 2009 00:44:35 +0000 (UTC) To: Dan Nicolaescu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 15 02:45:54 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LttFz-0004h1-1U for geb-bug-gnu-emacs@m.gmane.org; Wed, 15 Apr 2009 02:45:40 +0200 Original-Received: from localhost ([127.0.0.1]:45391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LttEa-0001dE-Au for geb-bug-gnu-emacs@m.gmane.org; Tue, 14 Apr 2009 20:44:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LttEM-0001Zb-Nu for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:43:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LttEI-0001ZC-AW for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:43:58 -0400 Original-Received: from [199.232.76.173] (port=43798 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LttEH-0001Z2-O1 for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:43:53 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36658) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LttEG-00033l-Uk for bug-gnu-emacs@gnu.org; Tue, 14 Apr 2009 20:43:53 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3F0hoW1018113; Tue, 14 Apr 2009 17:43:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3F0e4GW017053; Tue, 14 Apr 2009 17:40:04 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2388 X-Emacs-PR-Package: emacs,vc-dir X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27190 Archived-At: This is a multi-part message in MIME format... ------------=_1239756004-16950-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Tue, 14 Apr 2009 17:30:16 -0700 (PDT) with message-id <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu> and subject line Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir has caused the Emacs bug report #2388, regarding 23.0.90; wrong-type-argument in vc-dir to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2388: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2388 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1239756004-16950-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 19 Feb 2009 14:21:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1JELVO1003428 for ; Thu, 19 Feb 2009 06:21:33 -0800 Received: from mx10.gnu.org ([199.232.76.166]:38854) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1La9kI-0006XE-KE for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 09:19:23 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1La9mH-0006Xw-Tl for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 09:21:30 -0500 Received: from tnei.co.uk ([83.170.102.119]:37840 helo=mail.tnei-mail.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1La9mH-0006Xa-J6 for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 09:21:25 -0500 Received: from mangw.ipsa-power.com ([83.138.33.114] helo=robert-laptop.tnei.co.uk) by mail.tnei-mail.com with esmtp (Exim 4.63) (envelope-from ) id 1La9ob-0000xp-UV for emacs-pretest-bug@gnu.org; Thu, 19 Feb 2009 14:23:50 +0000 Date: Thu, 19 Feb 2009 14:21:16 +0000 Message-Id: <87zlgi1p9f.fsf@tnei.co.uk> From: robert To: emacs-pretest-bug@gnu.org X-SA-Exim-Connect-IP: 83.138.33.114 X-SA-Exim-Mail-From: robert.marshall@tnei.co.uk Subject: 23.0.90; wrong-type-argument in vc-dir X-SA-Exim-Version: 4.2.1 (built Tue, 09 Jan 2007 17:23:22 +0000) X-SA-Exim-Scanned: Yes (on mail.tnei-mail.com) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) If I run vc-dir in a svn controlled directory called 'Test Networks' (with the internal space but not the quotes!), I get a wrong-type-argument error, with the following traceback - Debugger entered--Lisp error: (wrong-type-argument arrayp nil) ewoc-data(nil) vc-dir-node-directory(nil) when I don't have debug-on-error set to t the *vc-dir* process never completes. In GNU Emacs 23.0.90.4 (i686-pc-linux-gnu, GTK+ Version 2.14.4) of 2009-02-16 on robert-laptop Windowing system distributor `The X.Org Foundation', version 11.0.10502000 Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: VC dir Minor modes in effect: diff-auto-refine-mode: t desktop-save-mode: t shell-dirtrack-mode: t recentf-mode: t show-paren-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t ------------=_1239756004-16950-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2388-done) by emacsbugs.donarmstrong.com; 15 Apr 2009 00:30:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3F0UaD0015672 for <2388-done@emacsbugs.donarmstrong.com>; Tue, 14 Apr 2009 17:30:37 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n3F0UHn2014971; Tue, 14 Apr 2009 17:30:17 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n3F0UGFT009182; Tue, 14 Apr 2009 17:30:16 -0700 (PDT) Date: Tue, 14 Apr 2009 17:30:16 -0700 (PDT) Message-Id: <200904150030.n3F0UGFT009182@godzilla.ics.uci.edu> From: Dan Nicolaescu To: 2388-done@emacsbugs.donarmstrong.com Cc: robert marshall Subject: Re: bug#2388: 23.0.90; wrong-type-argument in vc-dir References: <87zlgi1p9f.fsf@tnei.co.uk> <200902201612.n1KGCFvg006453@rodan.ics.uci.edu> <49A2B431.6030302@tnei.co.uk> <18851.37147.636647.611430@kahikatea.snap.net.nz> <18862.21659.153250.510667@snap.net.nz> <49B6361C.8050702@tnei.co.uk> <200903102111.n2ALB1OM029132@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: <200903102111.n2ALB1OM029132@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Tue, 10 Mar 2009 14:11:01 -0700 (PDT)") Lines: 90 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n3F0UHn2014971 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.363, required 5, autolearn=disabled, ALL_TRUSTED -1.44, TW_SV 0.08) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Dan Nicolaescu writes: > robert marshall writes: > > > Nick Roberts wrote: > > > Nick Roberts writes: > > > > > > I can't reproduce this. > > > > > > Can you please post step by step recipe of how you get this, starting > > > > > > with emacs -Q. > > > The output of > > > svn -u status > > > > > > in that directory might be helpful too. > > > > > > > > I can't reproduce this either now :-( > > > > > I have seen this sometimes when files have needed > > > merging/updating. I don't > > > > think it happened earlier because with SVN emacs didn't consult the remote > > > > repository by default: > > > > > > I still see this. Here's a recent backtrace: > > > > > > Debugger entered--Lisp error: (wrong-type-argument arrayp nil) > > > ewoc-data(nil) > > > (let ((data ...)) (or (vc-dir-fileinfo->directory data) > > > (file-name-directory ...))) > > > vc-dir-node-directory(nil) > > > (let* ((rd ...) (prev-node ...) (prev-dir ...)) (unless > > > (string-equal entrydir prev-dir) (ewoc-enter-before vc-ewoc node > > > ...))) > > > (cond ((string-lessp nodedir entrydir) (setq node ...)) > > > ((string-equal nodedir entrydir) (let ... ...)) (t (let* ... ...) > > > (ewoc-enter-before vc-ewoc node ...) (setq entries ... entry ...))) > > > (let* ((entryfile ...) (entrydir ...) (nodedir ...)) (cond > > > (... ...) (... ...) (t ... ... ...))) > > > (while (and entry node) (let* (... ... ...) (cond ... ... ...))) > > > (let ((entry ...) (node ...) (dotname ...)) (unless node > > > (ewoc-enter-last vc-ewoc ...) (setq node ...)) (while (and entry > > > node) (let* ... ...)) (unless (or node noinsert) (let ... ...))) > > > (save-current-buffer (set-buffer buffer) (setq entries (sort > > > entries ...)) (let (... ... ...) (unless node ... ...) (while > > > ... ...) (unless ... ...))) > > > (with-current-buffer buffer (setq entries (sort entries ...)) (let > > > (... ... ...) (unless node ... ...) (while ... ...) (unless > > > ... ...))) > > > vc-dir-update((("." needs-update) ("mydir" needs-update) > > > ("pom.xml" needs-update) ("mydir1/mydir2/myfile" needs-update) ... > > > > > > which fails because node, i.e (ewoc-nth vc-ewoc 0), is nil. > > > > > > > > I'm seeing this, today, the status gives me > > > > svn -u status > > * 7243 tests/compare.py > > * 7243 tests/harm.py > > * 7243 tests/setup-win.py > > * 7243 ipsa.i > > * 7243 Makefile > > * 7243 IscNetComponent.cpp > > * 7243 IscNetComparator.h > > * 7243 IpsaComparator.cpp > > * 7243 IscNetComponent.h > > * 7243 IscNetComparator.cpp > > * IscCompareData.h > > ? ipsa_wrap.cpp > > M * 7243 IscInterface.cpp > > ? ipsa.py > > * IscCompareData.cpp > > * 7243 Scripting.vcproj > > * 7243 . > ^^^^^^^^^^^^^^^^^^^^^^^^ > This might be the cause of the problem. Can you please try thing > patch: > > > Index: vc-svn.el > =================================================================== > RCS file: /cvsroot/emacs/emacs/lisp/vc-svn.el,v > retrieving revision 1.112 > diff -u -3 -p -u -p -r1.112 vc-svn.el > --- vc-svn.el 10 Feb 2009 05:59:14 -0000 1.112 > +++ vc-svn.el 10 Mar 2009 20:49:23 -0000 > @@ -176,7 +176,7 @@ want to force an empty list of arguments > ;; FIXME are there other possible combinations? > (cond ((eq state 'edited) (setq state 'needs-merge)) > ((not state) (setq state 'needs-update)))) > - (when state > + (when (and state (not (string= "." filename))) > (setq result (cons (list filename state) result))))) > (funcall callback result))) After doing "svn update -rSOME_OLDER_VERSION" it seems that "." can appear in the "svn status" output. So I applied this patch. ------------=_1239756004-16950-0--