From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2357: marked as done (imenu-add-menubar-index fails in Objective-C mode) Date: Wed, 18 Feb 2009 09:30:06 +0000 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1234949406-22212-2" X-Trace: ger.gmane.org 1234950541 14826 80.91.229.12 (18 Feb 2009 09:49:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Feb 2009 09:49:01 +0000 (UTC) To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 18 10:50:16 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LZj4C-00030j-Ma for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2009 10:50:09 +0100 Original-Received: from localhost ([127.0.0.1]:34312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZj2s-0002jP-Cl for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2009 04:48:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LZj2o-0002iU-Ds for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 04:48:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LZj2n-0002i7-LN for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 04:48:41 -0500 Original-Received: from [199.232.76.173] (port=36117 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LZj2n-0002i4-Il for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 04:48:41 -0500 Original-Received: from mx20.gnu.org ([199.232.41.8]:24079) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LZj2n-0005Jj-16 for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 04:48:41 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LZj2m-00011K-2M for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2009 04:48:40 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1I9hZSd026192; Wed, 18 Feb 2009 01:43:36 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1I9U6FV022264; Wed, 18 Feb 2009 01:30:06 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2357 X-Emacs-PR-Package: emacs,cc-mode X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25403 Archived-At: This is a multi-part message in MIME format... ------------=_1234949406-22212-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Wed, 18 Feb 2009 10:24:08 +0100 with message-id and subject line Re: bug#2357: imenu-add-menubar-index fails in Objective-C= mode has caused the Emacs bug report #1638, regarding imenu-add-menubar-index fails in Objective-C mode to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 1638: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1638 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1234949406-22212-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 17 Feb 2009 12:22:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=FOURLA,FVGT_m_MULTI_ODD,GMAIL, HAS_PACKAGE autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1HCMMDB022267 for ; Tue, 17 Feb 2009 04:22:24 -0800 Received: by ug-out-1314.google.com with SMTP id u2so183138uge.14 for ; Tue, 17 Feb 2009 04:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=gagkWOoSsRQn2SJgG+fhvclnK8cf2ohYqgzbjDSypR4=; b=uhQ3ZiKpZNRiMFA6e0h+zINFI2uCqsS+8wVGM8B8uo6MvvAqWMFPAmwYNGc7ccnhRU oMj9had+rt0q01sfQl6Rn0c7DUqYipQrZF0kqounvr3mLFyJ/PkzToGjbj0rO8xHj+sG BSbwj8JL2NXU+5ONVop25JMl2+f34GRfUa0BQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=JtTA+8HS1yxmGEbBNu6Tq8mCM+UqVGpptNT3+QkhNIpp6rUAPzdgw/3aysCFLfAG9J /vDW0HG5aHpywLUS8tHYgCaGCCIDbLL4cMe/GJJF0KTbW/pqLghybffDHmoZApb7BBY8 QiNXpVl+kWcMZuNKGq7I+pvToefov0xr3FiqM= MIME-Version: 1.0 Received: by 10.210.129.19 with SMTP id b19mr210573ebd.190.1234873341908; Tue, 17 Feb 2009 04:22:21 -0800 (PST) Date: Tue, 17 Feb 2009 13:22:21 +0100 Message-ID: Subject: imenu-add-menubar-index fails in Objective-C mode From: Juanma Barranquero To: Emacs Bug Tracker Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Package: emacs,cc-mode [This part is a bugfix] emacs -Q --visit nsfns.m --f imenu-add-menubar-index =3D> Error in menu-bar-update-hook: (invalid-function imenu-progress-messa= ge) The reason is that progmodes/cc-menus.el does (cc-bytecomp-defun imenu-progress-message) to avoid loading imenu.el, and then uses `imenu-progress-message' in Objective-C specific code (cc-imenu-objc-function). But it is a macro, so it fails. I think the best way to fix it is just removing the cc-bytecomp-defun and all calls to imenu-progress-message from cc-menus.el. That macro has been defined as a no-op since 2004-10-27 and I don't think it is worth jumping around hoops just to make cc-menus.el successfully define something that goes unused. [This part is not a bugfix, so not needed now] Additionally, there are useless calls to `imenu-progress-message' in imenu.el, erc/erc-imenu.el and net/smtp-mode.el. For the latter two, removing the macro calls would also remove the need to require imenu. Juanma 2009-02-17 Juanma Barranquero * progmodes/cc-menus.el (imenu-progress-message): Remove (bogus and useless) cc-bytecomp-defun. (cc-imenu-objc-function): Don't call `imenu-progress-message'. Don't let-bind unused variable `stupid'. Index: lisp/progmodes/cc-menus.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/progmodes/cc-menus.el,v retrieving revision 1.42 diff -u -2 -r1.42 cc-menus.el --- lisp/progmodes/cc-menus.el 17 Feb 2009 10:59:14 -0000 1.42 +++ lisp/progmodes/cc-menus.el 17 Feb 2009 11:51:30 -0000 @@ -48,5 +48,4 @@ (cc-bytecomp-defvar imenu-generic-expression) (cc-bytecomp-defvar imenu-create-index-function) -(cc-bytecomp-defun imenu-progress-message) =0C @@ -317,5 +316,4 @@ (classcount 0) toplist - stupid str str2 @@ -331,8 +329,6 @@ 'buffer-substring))) (goto-char (point-max)) - (imenu-progress-message stupid 0) ;; (while (re-search-backward cc-imenu-objc-generic-expression nil t) - (imenu-progress-message stupid) (setq langnum (if (match-beginning OBJC) OBJC @@ -386,5 +382,4 @@ methodlist nil)))) ;; - (imenu-progress-message stupid 100) (if (eq (car toplist) nil) (setq toplist (cdr toplist))) ------------=_1234949406-22212-2 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1638-done) by emacsbugs.donarmstrong.com; 18 Feb 2009 09:24:18 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1I9OE6v020644 for <1638-done@emacsbugs.donarmstrong.com>; Wed, 18 Feb 2009 01:24:15 -0800 Received: by ewy3 with SMTP id 3so2799621ewy.1 for <1638-done@emacsbugs.donarmstrong.com>; Wed, 18 Feb 2009 01:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=EQT1m8gmMvu7U7RraJvdovfDUKO+JGE8+xyL90YpFuE=; b=pDUDLFzhOyqQQpeBjXh7ydYr4wC+TwNNH8iq5y+bps33ohzOaWFJtbM9qM5vhdTb3D 9UNV89APd0D/YKMXbOxQhazgsudbtGb5vyv4yAiPF52CraLCYuVIeEsmA7mvzBx0Qw95 FfpsUZ2hyQSm3kjox69N8OakHyow3uDHhGYqs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=jDIGVeRrFSs5VkS4PRBLMHFkJ1xxiaPKU6rQbsxNC2GC+LU4WeNoqf795XpaDisF9P IJ7KBi5jJJgo4ui/4qtPrB751W79gv2ZWbqYJnUAZ2gGWrHkrrdOOBP87KLwIjEw5hlS XmlX8F3/vOgeqQNMdhPfb6h8C3vYnAOt4WLB4= MIME-Version: 1.0 Received: by 10.210.60.3 with SMTP id i3mr1319929eba.27.1234949048510; Wed, 18 Feb 2009 01:24:08 -0800 (PST) In-Reply-To: References: Date: Wed, 18 Feb 2009 10:24:08 +0100 Message-ID: Subject: Re: bug#2357: imenu-add-menubar-index fails in Objective-C mode From: Juanma Barranquero To: Stefan Monnier Cc: 1638-done@emacsbugs.donarmstrong.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Wed, Feb 18, 2009 at 03:57, Stefan Monnier wrote: > Removing uses of cc-bytecomp-* is always a reason for rejoycing. Ok, installed. Juanma ------------=_1234949406-22212-2--