From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2352: marked as done (23.0.90; Vertical window border on OS X) Date: Fri, 06 Mar 2009 15:40:05 +0000 Message-ID: References: <20090217035156.GI48993@awe.local> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1236354005-19732-0" X-Trace: ger.gmane.org 1236355336 1519 80.91.229.12 (6 Mar 2009 16:02:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 6 Mar 2009 16:02:16 +0000 (UTC) To: Adrian Robert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 06 17:03:28 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LfcVx-0002Nz-HA for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Mar 2009 17:03:12 +0100 Original-Received: from localhost ([127.0.0.1]:58031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfcUb-0003A4-RO for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Mar 2009 11:01:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LfcDE-0004rm-Cn for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2009 10:43:48 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LfcDA-0004pF-UL for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2009 10:43:47 -0500 Original-Received: from [199.232.76.173] (port=40087 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfcDA-0004p0-L2 for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2009 10:43:44 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43816) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LfcD9-0002dH-Sc for bug-gnu-emacs@gnu.org; Fri, 06 Mar 2009 10:43:44 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n26Fhdc3020943; Fri, 6 Mar 2009 07:43:41 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n26Fe5MS019936; Fri, 6 Mar 2009 07:40:05 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2352 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26046 Archived-At: This is a multi-part message in MIME format... ------------=_1236354005-19732-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Fri, 6 Mar 2009 17:32:33 +0200 with message-id and subject line Re: 23.0.90; Vertical window border on OS X has caused the Emacs bug report #2352, regarding 23.0.90; Vertical window border on OS X to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2352: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2352 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1236354005-19732-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 17 Feb 2009 03:52:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=FOURLA,IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1H3q39A024844 for ; Mon, 16 Feb 2009 19:52:05 -0800 Received: from mx10.gnu.org ([199.232.76.166]:47322) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LZGy6-0004Iu-H6 for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:49:58 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LZH05-0000jU-SP for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:52:03 -0500 Received: from qw-out-1920.google.com ([74.125.92.149]:11541) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LZH05-0000jM-Fr for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:52:01 -0500 Received: by qw-out-1920.google.com with SMTP id 4so631530qwk.24 for ; Mon, 16 Feb 2009 19:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=u20arzYQDeLr8Kn6xg80LTETzYJ1Gz/u2+BlO2SkK7E=; b=wrPs8C7vZlOr4i5s36+Z+qBsCimohYVJnn76NenilEqynIDMS6o3dByXQ+TcirOkNl YwAiCSxVacm9Dm4cirVbtUjYS843uwa7Pp8moNHpzUo0+ReQ/bgMkTUYkQ/GNxSQNQ0I L6dQ6DWq/GeNUMregemKOydLd6c/KW7Fqxck4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=Q4F5tuaYpzkYM4w/jJOtbzegwiA4MrMk/cPixv7yvmxvNkoipD939yybz2dUnouaMS ShhX2QAgr8EO+EAFYWEjxEusV4A9IStXoij9hh1zS0e/yjGzpAQc4ZahqvvuWqeMHFsK 6wK1/AuFMK8zm/mMx/jt6zeymoZGNa4D2AiJY= Received: by 10.224.28.144 with SMTP id m16mr2292408qac.86.1234842720211; Mon, 16 Feb 2009 19:52:00 -0800 (PST) Received: from localhost (dhcp0403.vpm.resnet.group.upenn.edu [165.123.165.237]) by mx.google.com with ESMTPS id 7sm11828839ywo.57.2009.02.16.19.51.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Feb 2009 19:51:59 -0800 (PST) Date: Mon, 16 Feb 2009 22:51:56 -0500 From: Aaron Ecay To: emacs-pretest-bug@gnu.org Subject: 23.0.90; Vertical window border on OS X Message-ID: <20090217035156.GI48993@awe.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: On the OS X (and presumably GNUstep) port, the drawing of a vertical border between two frames does not work. This currently uses the NSDrawGroove function from the Cocoa/GNUstep API. According to http://preview.tinyurl.com/c2flh9 (apologies for the shortening, the link goes to some Apple API documentation and the URL is gargantuan), the function NSDrawGroove "Draws a gray-filled rectangle with a groove border". This would not be desirable behavior in any case, as making the divider gray disregards the setting of the vertical-border face. And in any event, it appears to be a no-op on OS X.5 (Leopard) -- after doing a C-x 3, there is no vertical frame border apparent against either a dark or a white background. The function to use, IMHO, is NSRectFill; substituting this fn makes the border drawing happen. NSRectFill was used in Emacs 22 (`emacs22' branch in the git repo, src/nsterm.m line 2466). The patch below fixes this behavior. It also restores another bit of v.22 status quo, namely making the vertical window divider one pixel in width, instead of the current two. ####### BEGIN PATCH ####### diff --git a/src/nsterm.m b/src/nsterm.m index b674eda..c2ebf9f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -2454,7 +2454,7 @@ ns_draw_vertical_window_border (struct window *w, int x, int y0, int y1) { struct frame *f = XFRAME (WINDOW_FRAME (w)); struct face *face; - NSRect r = NSMakeRect (x, y0, 2, y1-y0); + NSRect r = NSMakeRect (x, y0, 1, y1-y0); NSTRACE (ns_draw_vertical_window_border); @@ -2463,7 +2463,7 @@ ns_draw_vertical_window_border (struct window *w, int x, int y0, int y1) [ns_lookup_indexed_color(face->foreground, f) set]; ns_focus (f, &r, 1); - NSDrawGroove (r, r); + NSRectFill(r); ns_unfocus (f); } ####### END PATCH ####### If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /opt/src/emacs/nextstep/Emacs.app/Contents/Resources/etc/DEBUG for instructions. In GNU Emacs 23.0.90.7 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-02-15 on dhcp0403.vpm.resnet.group.upenn.edu Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t paredit-mode: t auto-insert-mode: t desktop-save-mode: t mac-print-mode: t shell-dirtrack-mode: t show-paren-mode: t global-auto-complete-mode: t auto-complete-mode: t display-battery-mode: t icomplete-mode: t savehist-mode: t recentf-mode: t partial-completion-mode: t display-time-mode: t ns-extended-platform-support-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-r C-h C-g C-e # SPC T O D O : SPC f u n c t i o n SPC t o SPC e d i t SPC i n SPC t e r m i n a l SPC ( e ) C-x C-s C-h f r e p o r t - e m C-h v u s e r - m a s h i s h u u q h n n n n n n n s C-e C-e M-; T O O D : SPC D O : SPC m o v C-M-x C-x 3 C-x 0 C-x < M-x r e p o r t Recent messages: Mark saved where search started byte-code: End of buffer [3 times] byte-code: Beginning of buffer [3 times] Saving file /Users/aecay/home/.zshrc... Wrote /Users/aecay/home/.zshrc Type "q" to quit. [2 times] Entering debugger... Back to top level. Mark set ------------=_1236354005-19732-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2352-done) by emacsbugs.donarmstrong.com; 6 Mar 2009 15:31:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n26FVrOJ018359 for <2352-done@emacsbugs.donarmstrong.com>; Fri, 6 Mar 2009 07:31:55 -0800 Received: by nf-out-0910.google.com with SMTP id d3so55710nfc.31 for <2352-done@emacsbugs.donarmstrong.com>; Fri, 06 Mar 2009 07:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:content-type :message-id:cc:content-transfer-encoding:from:subject:date:to :x-mailer; bh=PmanUDgJQeVJK75UByHO/VYQVqT3vbJ6fJsSClgmxpk=; b=jbEHI55kpgoYfkSb7C8d6EDw930brlQ7A1IqzJ5BH+kCJE68Zo5BkNd74NmBKPVMfi g6a4aTqLlPFJSNe4/JqHQIo+A8Y1Sn8DUHkEvtjK39f0wa21FgzTYlBiq+zhmZClmtE5 SbUdSI7u5cmCRBBP1ksUINV3h3fwtrGvd+Jd0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; b=b+fUN71PVF3nkDXEr1WSCIkCNGy9146n2yTF+k1stDklJXziwitOBUg5DfzjcpqhjJ zE2GxJPWN/in2utWN7hbRsBaGb1bczH44pRsiWELYAQu+brPuHLmOxGJHlUZ9Lh3Vn09 6COFBHHNyJuNK+JVX6v1/FvHIkY/EmUVd/NvI= Received: by 10.216.1.202 with SMTP id 52mr1288226wed.15.1236353513075; Fri, 06 Mar 2009 07:31:53 -0800 (PST) Received: from ?88.194.195.100? (gprs-prointernet-ffc3c200-100.dhcp.inet.fi [88.194.195.100]) by mx.google.com with ESMTPS id 5sm2485200nfv.21.2009.03.06.07.31.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 06 Mar 2009 07:31:52 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Cc: Aaron Ecay Content-Transfer-Encoding: 7bit From: Adrian Robert Subject: Re: 23.0.90; Vertical window border on OS X Date: Fri, 6 Mar 2009 17:32:33 +0200 To: 2352-done@emacsbugs.donarmstrong.com X-Mailer: Apple Mail (2.753.1) Thanks, I've applied this patch and am closing the report. ------------=_1236354005-19732-0--