flyspell functions don't initialize aspell dicts

flyspell functions don't initialize aspell dicts

[Nathaniel Cunningham]

[-- Attachment #1: Type: text/plain, Size: 689 bytes --]

Greetings,
I've found that (flyspell-buffer) doesn't go through the same dictionary
initialization steps as (ispell-buffer).  Specifically, the flyspell
functions (flyspell-word) and (flyspell-large-region) don't call
(ispell-maybe-find-aspell-dictionaries), they way (ispell-region) and
(flyspell-mode) do.  The result: user's aspell setup (if present) doesn't
get to inform `ispell-dictionary-alist', unless e.g. (ispell-buffer) or
(flyspell-mode) is called first.

I believe simply adding (ispell-maybe-find-aspell-dictionaries) near the top
of `flyspell-word' and `flyspell-large-region' definitions, as it already is
for `flyspell-mode-on', will take care of this.

Cheers,
Nathaniel

[-- Attachment #2: Type: text/html, Size: 759 bytes --]

Re: flyspell functions don't initialize aspell dicts

[Agustin Martin]

On Mon, May 12, 2008 at 05:27:46PM -0500, Nathaniel Cunningham wrote:
> Greetings,
> I've found that (flyspell-buffer) doesn't go through the same dictionary
> initialization steps as (ispell-buffer).  Specifically, the flyspell
> functions (flyspell-word) and (flyspell-large-region) don't call
> (ispell-maybe-find-aspell-dictionaries), they way (ispell-region) and
> (flyspell-mode) do.  The result: user's aspell setup (if present) doesn't
> get to inform `ispell-dictionary-alist', unless e.g. (ispell-buffer) or
> (flyspell-mode) is called first.
> 
> I believe simply adding (ispell-maybe-find-aspell-dictionaries) near the top
> of `flyspell-word' and `flyspell-large-region' definitions, as it already is
> for `flyspell-mode-on', will take care of this.

(ispell-maybe-find-aspell-dictionaries) is no longer used in fsf emacs
ispell.el or flyspell.el. It has been recently replaced by a more generic
(ispell-set-spellchecker-params), which is also called from (flyspell-word)
and (flyspell-large-region).

flyspell.el: Revision 1.131
ispell.el: Revision 1.227 

Regards,

-- 
Agustin

bug#232: marked as done (flyspell functions don't initialize aspell dicts)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]


Your message dated Mon, 28 Jul 2008 16:21:39 -0400
with message-id <87y73lrc8c.fsf@stupidchicken.com>
and subject line Re: flyspell functions don't initialize aspell dicts
has caused the Emacs bug report #232,
regarding flyspell functions don't initialize aspell dicts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
232: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=232
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 7240 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 689 bytes --]

Greetings,
I've found that (flyspell-buffer) doesn't go through the same dictionary
initialization steps as (ispell-buffer).  Specifically, the flyspell
functions (flyspell-word) and (flyspell-large-region) don't call
(ispell-maybe-find-aspell-dictionaries), they way (ispell-region) and
(flyspell-mode) do.  The result: user's aspell setup (if present) doesn't
get to inform `ispell-dictionary-alist', unless e.g. (ispell-buffer) or
(flyspell-mode) is called first.

I believe simply adding (ispell-maybe-find-aspell-dictionaries) near the top
of `flyspell-word' and `flyspell-large-region' definitions, as it already is
for `flyspell-mode-on', will take care of this.

Cheers,
Nathaniel

[-- Attachment #2.1.2: Type: text/html, Size: 759 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 1545 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Nathaniel Cunningham" <nathaniel.cunningham@gmail.com>
Cc: 232-done@emacsbugs.donarmstrong.com
Subject: Re: flyspell functions don't initialize aspell dicts
Date: Mon, 28 Jul 2008 16:21:39 -0400
Message-ID: <87y73lrc8c.fsf@stupidchicken.com>

> I've found that (flyspell-buffer) doesn't go through the same
> dictionary initialization steps as (ispell-buffer).  Specifically, the
> flyspell functions (flyspell-word) and (flyspell-large-region) don't
> call (ispell-maybe-find-aspell-dictionaries), they way (ispell-region)
> and (flyspell-mode) do.  The result: user's aspell setup (if present)
> doesn't get to inform `ispell-dictionary-alist', unless
> e.g. (ispell-buffer) or (flyspell-mode) is called first.

This has been fixed in the CVS trunk for a while.  I just checked in a
fix into the Emacs 22 branch.

Thanks.