From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#2077: marked as done (23.0.60; error raised if visit new, empty file foo.jpeg) Date: Tue, 27 Jan 2009 15:55:05 +0000 Message-ID: References: <002101c98096$4932b740$0200a8c0@us.oracle.com> <00c401c98006$0a327d90$c2b22382@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1233071705-25375-0" X-Trace: ger.gmane.org 1233072392 21566 80.91.229.12 (27 Jan 2009 16:06:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 27 Jan 2009 16:06:32 +0000 (UTC) To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 27 17:07:45 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LRqRS-0004nv-5m for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Jan 2009 17:05:56 +0100 Original-Received: from localhost ([127.0.0.1]:46433 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRqQA-00048y-Aq for geb-bug-gnu-emacs@m.gmane.org; Tue, 27 Jan 2009 11:04:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRqPY-0003j7-At for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 11:03:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRqPW-0003h1-Ex for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 11:03:35 -0500 Original-Received: from [199.232.76.173] (port=60099 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRqPV-0003gt-SB for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 11:03:34 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:35771) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRqPU-00055Y-OG for bug-gnu-emacs@gnu.org; Tue, 27 Jan 2009 11:03:33 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RG3TXw027743; Tue, 27 Jan 2009 08:03:30 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0RFt5hQ025453; Tue, 27 Jan 2009 07:55:05 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: closed 2077 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24625 Archived-At: This is a multi-part message in MIME format... ------------=_1233071705-25375-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Tue, 27 Jan 2009 07:45:31 -0800 with message-id <002101c98096$4932b740$0200a8c0@us.oracle.com> and subject line RE: 23.0.60; error raised if visit new, empty file foo.jpeg has caused the Emacs bug report #2077, regarding 23.0.60; error raised if visit new, empty file foo.jpeg to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com immediately.) --=20 2077: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D2077 Emacs Bug Tracking System Contact owner@emacsbugs.donarmstrong.com with problems ------------=_1233071705-25375-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 26 Jan 2009 22:33:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0QMX4OW017173 for ; Mon, 26 Jan 2009 14:33:05 -0800 Received: from mail.gnu.org ([199.232.76.166]:44670 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LRZzK-0006qN-Lv for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 17:31:26 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LRa0s-0000Kj-BH for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 17:33:03 -0500 Received: from acsinet12.oracle.com ([141.146.126.234]:41816) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRa0r-0000KY-Uv for emacs-pretest-bug@gnu.org; Mon, 26 Jan 2009 17:33:02 -0500 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0QMWLcg016344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 26 Jan 2009 22:32:23 GMT Received: from acsmt706.oracle.com (acsmt706.oracle.com [141.146.40.84]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0QMWv2h018372 for ; Mon, 26 Jan 2009 22:32:58 GMT Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 26 Jan 2009 22:32:55 +0000 From: "Drew Adams" To: Subject: 23.0.60; error raised if visit new, empty file foo.jpeg Date: Mon, 26 Jan 2009 14:32:56 -0800 Message-ID: <00c401c98006$0a327d90$c2b22382@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcmABgjrLMYYKec+QdOeWCf2D+A7kQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt706.oracle.com [141.146.40.84] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090209.497E3A19.0138:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) This is similar to bug #2058, but the error raised here is much less bewildering. ;-) emacs -Q C-x C-f foo.jpeg That raises this error: "File mode specification error: (error "Cannot determine image type")" I don't think an error should be raised until the buffer is saved. I could be wrong about that. In any case, the error message should be something more appropriate. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2009-01-04 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' ------------=_1233071705-25375-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 2077-done) by emacsbugs.donarmstrong.com; 27 Jan 2009 15:46:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0RFjtw3023962 for <2077-done@emacsbugs.donarmstrong.com>; Tue, 27 Jan 2009 07:45:56 -0800 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0RFjFIw009966 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 27 Jan 2009 15:45:25 GMT Received: from acsmt703.oracle.com (acsmt703.oracle.com [141.146.40.81]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n0RFjUux007028; Tue, 27 Jan 2009 15:45:32 GMT Received: from dradamslap1 (/24.5.128.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 27 Jan 2009 15:45:30 +0000 From: "Drew Adams" To: "'Chong Yidong'" Cc: <2077-done@emacsbugs.donarmstrong.com> References: <87zlhcol3p.fsf@cyd.mit.edu> Subject: RE: 23.0.60; error raised if visit new, empty file foo.jpeg Date: Tue, 27 Jan 2009 07:45:31 -0800 Message-ID: <002101c98096$4932b740$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-reply-to: <87zlhcol3p.fsf@cyd.mit.edu> Thread-Index: AcmAjyShUf7DlQlMRs+IXCbLlt2YtwAAtMyw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt703.oracle.com [141.146.40.81] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.497F2C1E.0297:SCFSTAT928724,ss=1,fgs=0 > > emacs -Q > > > > C-x C-f foo.jpeg > > > > That raises this error: > > "File mode specification error: (error "Cannot determine > > image type")" > > > > I don't think an error should be raised until the buffer is > > saved. I could be wrong about that. In any case, the error > > message should be something more appropriate. > > The error occurs because Emacs is trying to display the image, and is > unable to do so. Yes, I know. > It has nothing to do with saving the buffer. I see. Will Emacs display an unsaved image file buffer? I was thinking that image mode (or whatever it is) is reserved for existing files. That's why I mentioned saving. There are two possible cases here: (1) a new, empty file buffer and (2) an existing empty file. > Note that image-mode does not assume that the file is in jpeg format > based on the file name alone: it examines the file contents > as well. We could, in principle, replace this error message with a > more generic message, but that would be less helpful for debugging. It should be replaced with a more _specific_ message, saying that (1) the file does not exist or (2) that the file is empty. A user who knows nothing of image mode or images and mistakenly types foo.jpeg instead of foo.jpem (local to his organization) gets an inappropriate message. What s?he should be told is that (1) image mode is used, by default, for *.jpeg (`auto-mode-alist'), and (2) the file does not exist (if new) or is empty (if existing). Another case is what happens if a user visits a non-empty text file named foo.jpeg? Again, the buffer should be put in fundamental mode and an error message raised. The message should say that *.jpeg is associated with image mode, but this is not a well-formed JPEG file. IOW, the not-valid-PDF message must make sense also to a user unfamiliar with images. If you want to give additional info about the invalid JPEG in the case of a normal bad-JPEG file, then consider giving first such a short message, but mention that the user can hit some key for more information. When s?he hits that key, pop up a buffer with the detailed diagnosis for the bad JPEG. See the discussion for bug #2058. ------------=_1233071705-25375-0--