bug#1899: url-cookie-retrieve is not prepared for missing localpart

bug#1899: url-cookie-retrieve is not prepared for missing localpart

[Klaus Straubinger]

In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'


the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) is
not prepared for the case that the parameter localpart could be nil:
(regexp-quote nil) is an error. This is especially problematic since
the corresponding function for setting cookies, url-cookie-store,
defines the parameter localpart as optional.

Test example:
(require 'url-cookie)
(url-cookie-store "test" "42" nil "www.gnu.org")
followed by
(url-cookie-retrieve "www.gnu.org" nil)

-- 
Klaus Straubinger

bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]


Your message dated Wed, 14 Jan 2009 15:48:04 -0500
with message-id <87fxjlvcl7.fsf@cyd.mit.edu>
and subject line Re: url-cookie-retrieve is not prepared for missing localpart
has caused the Emacs bug report #1899,
regarding url-cookie-retrieve is not prepared for missing localpart
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1899: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1899
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 2741 bytes --]

From: Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE>
To: bug-gnu-emacs@gnu.org
Subject: url-cookie-retrieve is not prepared for missing localpart
Date: Wed, 14 Jan 2009 13:43:27 +0100 ()
Message-ID: <uiqoinjm8.fsf@WDFD00185931A.sap.corp>

In GNU Emacs 22.3.1 (i386-mingw-nt5.1.2600) of 2008-09-06 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'


the function url-cookie-retrieve (defined in lisp/url/url-cookie.el) is
not prepared for the case that the parameter localpart could be nil:
(regexp-quote nil) is an error. This is especially problematic since
the corresponding function for setting cookies, url-cookie-store,
defines the parameter localpart as optional.

Test example:
(require 'url-cookie)
(url-cookie-store "test" "42" nil "www.gnu.org")
followed by
(url-cookie-retrieve "www.gnu.org" nil)

-- 
Klaus Straubinger




[-- Attachment #3: Type: message/rfc822, Size: 1441 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Klaus Straubinger <KSNetz@UseNet.ArcorNews.DE>
Cc: 1899-done@emacsbugs.donarmstrong.com
Subject: Re: url-cookie-retrieve is not prepared for missing localpart
Date: Wed, 14 Jan 2009 15:48:04 -0500
Message-ID: <87fxjlvcl7.fsf@cyd.mit.edu>

> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el)
> is not prepared for the case that the parameter localpart could be
> nil: (regexp-quote nil) is an error. This is especially problematic
> since the corresponding function for setting cookies,
> url-cookie-store, defines the parameter localpart as optional.

I've checked in a fix.  Thanks.

bug#1899: marked as done (url-cookie-retrieve is not prepared for missing localpart)

[Klaus Straubinger]

Chong Yidong <cyd@stupidchicken.com> wrote:

>> the function url-cookie-retrieve (defined in lisp/url/url-cookie.el)
>> is not prepared for the case that the parameter localpart could be
>> nil: (regexp-quote nil) is an error. This is especially problematic
>> since the corresponding function for setting cookies,
>> url-cookie-store, defines the parameter localpart as optional.
>
> I've checked in a fix.  Thanks.

Your fix changed the "string-match" to "equal" while keeping the
"regexp-quote". This will not work for all cases where "localpart" is
not empty.

I am afraid that this mail might not be the right way to reopen the bug.
I apologize for any inconvenience this might cause.

-- 
Klaus Straubinger