HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it

HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it

[Arnold Schwaighofer]

Problem:
In current HEAD display-completion-list deletes not only word to be
completed but everything in file before it.

example:
(defun my-complete-test ()
  (interactive)
  (with-output-to-temp-buffer "*Completions*"
    (display-completion-list
       '("test1" "test2" "test345")
       "test")))

and call that function in a buffer on the word "test" (M-x
my-complete-test) with some text preceeding "test". deletes everything
before word "test" instead of just replacing it.

This also happens when using the complete-tag function :(.

My interpretation of the problem :).

minibuffer.el: display-completion-list
 (set (make-local-variable 'completion-base-size) (or (cdr last) 0))
sets completion-base-size to 0
which causes everything to be deleted before the word to be completed.

the problem
seems to be related to completion-setup-function in simple.el checking
for completion-base-size where i believe it should check for
completion-all-completions-with-base-size
is it possible that it should read:

Index: lisp/simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.924
diff -r1.924 simple.el
5527c5527
<       (unless completion-base-size
---
>       (unless completion-all-completions-with-base-size

after applying that patch completion works for me.

bug#163: marked as done (HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]


Your message dated Thu, 14 Aug 2008 20:16:05 -0400
with message-id <87ljyzuo8q.fsf@stupidchicken.com>
and subject line Re: 23.0.60; lisp-complete-symbol erases extra text
has caused the Emacs bug report #163,
regarding HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
163: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=163
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6986 bytes --]

From: "Arnold Schwaighofer" <arnold.schwaighofer@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it
Date: Mon, 28 Apr 2008 14:22:25 +0200
Message-ID: <b8c6f2610804280522o68256194yb99e57eef4c33aee@mail.gmail.com>

Problem:
In current HEAD display-completion-list deletes not only word to be
completed but everything in file before it.

example:
(defun my-complete-test ()
  (interactive)
  (with-output-to-temp-buffer "*Completions*"
    (display-completion-list
       '("test1" "test2" "test345")
       "test")))

and call that function in a buffer on the word "test" (M-x
my-complete-test) with some text preceeding "test". deletes everything
before word "test" instead of just replacing it.

This also happens when using the complete-tag function :(.

My interpretation of the problem :).

minibuffer.el: display-completion-list
 (set (make-local-variable 'completion-base-size) (or (cdr last) 0))
sets completion-base-size to 0
which causes everything to be deleted before the word to be completed.

the problem
seems to be related to completion-setup-function in simple.el checking
for completion-base-size where i believe it should check for
completion-all-completions-with-base-size
is it possible that it should read:

Index: lisp/simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.924
diff -r1.924 simple.el
5527c5527
<       (unless completion-base-size
---
>       (unless completion-all-completions-with-base-size

after applying that patch completion works for me.




[-- Attachment #3: Type: message/rfc822, Size: 1141 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>, "Arnold Schwaighofer" <arnold.schwaighofer@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 591-done@emacsbugs.donarmstrong.com, 163-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; lisp-complete-symbol erases extra text
Date: Thu, 14 Aug 2008 20:16:05 -0400
Message-ID: <87ljyzuo8q.fsf@stupidchicken.com>

I've checked in a fix for the lisp-complete-symbol erasing buffer text
problem.

bug#591: 23.0.60; lisp-complete-symbol erases extra text

[Drew Adams]

emacs -Q
 
In *scratch*, type this, and leave cursor after the final `for':
 
format-decode-buffer
forward-char
 
for
 
Then hit `M-TAB'. Choose one of the completions using mouse-2 in *Completions*.
 
Only the final `for' should be completed, but instead all of the text
in the buffer is replaced by the chosen completion.

This is a regression from Emacs 22.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-06-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 

bug#591: marked as done (23.0.60; lisp-complete-symbol erases extra text)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]


Your message dated Thu, 14 Aug 2008 20:16:05 -0400
with message-id <87ljyzuo8q.fsf@stupidchicken.com>
and subject line Re: 23.0.60; lisp-complete-symbol erases extra text
has caused the Emacs bug report #591,
regarding 23.0.60; lisp-complete-symbol erases extra text
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
591: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=591
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3248 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.60; lisp-complete-symbol erases extra text
Date: Mon, 21 Jul 2008 21:43:27 -0700
Message-ID: <003101c8ebb5$7c107380$0200a8c0@us.oracle.com>

emacs -Q
 
In *scratch*, type this, and leave cursor after the final `for':
 
format-decode-buffer
forward-char
 
for
 
Then hit `M-TAB'. Choose one of the completions using mouse-2 in *Completions*.
 
Only the final `for' should be completed, but instead all of the text
in the buffer is replaced by the chosen completion.

This is a regression from Emacs 22.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-06-29 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 




[-- Attachment #3: Type: message/rfc822, Size: 1165 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>, "Arnold Schwaighofer" <arnold.schwaighofer@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 591-done@emacsbugs.donarmstrong.com, 163-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; lisp-complete-symbol erases extra text
Date: Thu, 14 Aug 2008 20:16:05 -0400
Message-ID: <87ljyzuo8q.fsf@stupidchicken.com>

I've checked in a fix for the lisp-complete-symbol erasing buffer text
problem.