From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#163: marked as done (HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it) Date: Thu, 14 Aug 2008 17:25:05 -0700 Message-ID: References: <87ljyzuo8q.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1218759905-14231-0" X-Trace: ger.gmane.org 1218760075 7263 80.91.229.12 (15 Aug 2008 00:27:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 15 Aug 2008 00:27:55 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 15 02:28:47 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KTnBB-0001MU-Ff for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 Aug 2008 02:28:33 +0200 Original-Received: from localhost ([127.0.0.1]:39556 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTnAE-0006Gu-PD for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Aug 2008 20:27:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTnA9-0006Eu-HR for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2008 20:27:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTnA8-0006Dn-CD for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2008 20:27:28 -0400 Original-Received: from [199.232.76.173] (port=50735 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTnA8-0006Da-8E for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2008 20:27:28 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:39460) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTnA7-0003wt-NV for bug-gnu-emacs@gnu.org; Thu, 14 Aug 2008 20:27:28 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7F0RPdw015568; Thu, 14 Aug 2008 17:27:25 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7F0P5ew014420; Thu, 14 Aug 2008 17:25:05 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 163 X-Emacs-PR-Package: emacs X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19440 Archived-At: This is a multi-part message in MIME format... ------------=_1218759905-14231-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Thu, 14 Aug 2008 20:16:05 -0400 with message-id <87ljyzuo8q.fsf@stupidchicken.com> and subject line Re: 23.0.60; lisp-complete-symbol erases extra text has caused the Emacs bug report #163, regarding HEAD: Bug in simple.el/minibuffer.el causing display-completion-l= ist to delete not only word to be completed but everything in file before it to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 163: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D163 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1218759905-14231-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA,MURPHY_DRUGS_REL8 autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 28 Apr 2008 16:49:34 +0000 Received: from ironport2-out.teksavvy.com (ironport2-out.teksavvy.com [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m3SGnVgW018764 for ; Mon, 28 Apr 2008 09:49:32 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aq4DAFSdFUjO+JghdGdsb2JhbACBU5ANASdTlB2DZw X-IronPort-AV: E=Sophos;i="4.25,717,1199682000"; d="scan'208";a="19539853" Received: from smtp.pppoe.ca (HELO smtp.teksavvy.com) ([65.39.196.238]) by ironport2-out.teksavvy.com with ESMTP; 28 Apr 2008 12:49:25 -0400 Received: from pastel.home ([206.248.152.33]) by smtp.teksavvy.com (Internet Mail Server v1.0) with ESMTP id IUZ75025 for ; Mon, 28 Apr 2008 12:49:25 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5921E80A4; Mon, 28 Apr 2008 12:49:25 -0400 (EDT) Resent-Message-ID: Resent-To: submit@emacsbugs.donarmstrong.com Resent-From: Stefan Monnier Resent-Date: Mon, 28 Apr 2008 12:49:25 -0400 X-Original-To: monnier@iro.umontreal.ca Received: from perlin.iro.umontreal.ca (perlin.iro.umontreal.ca [132.204.24.51]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id 61D542CFAEE for ; Mon, 28 Apr 2008 11:22:40 -0400 (EDT) Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by perlin.iro.umontreal.ca (Postfix) with ESMTP id 5015B14821B for ; Mon, 28 Apr 2008 11:22:32 -0400 (EDT) Received: from localhost ([127.0.0.1]:35919 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqVBX-0002nI-N1 for monnier@iro.umontreal.ca; Mon, 28 Apr 2008 11:22:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JqSNL-0001ib-3D for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JqSNI-0001hk-PL for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:29 -0400 Received: from [199.232.76.173] (port=44502 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JqSNI-0001hY-He for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:28 -0400 Received: from wf-out-1314.google.com ([209.85.200.169]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JqSNI-0006N4-AE for bug-gnu-emacs@gnu.org; Mon, 28 Apr 2008 08:22:28 -0400 Received: by wf-out-1314.google.com with SMTP id 29so4257841wff.24 for ; Mon, 28 Apr 2008 05:22:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; bh=YZdVOqbkyozHmYZBbSCKidJa/jB8K8QKZcrg4Fl52jY=; b=jPnj1X5JICn9EbcQ7mukCaASPn/wG5ihRziONBqesHY1h0Ap5Ngvo7XAYcz30KgMeqoEpjCoo/f2kz0zpS2pQt51C8opU8MacQcA1SdsWS0NSJINAt+uqLzasx7nTtNrNh9Xwdw7BG/b7G0C+qgxg/xLgx2EWgoQOMFHass3dEA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=NpLCdcA/c4k8wlXypOySSP43h7J/DnYVT9Lx5I5LmITpPacPniLbc78MZkso+YTP8rPH3bEqn+3BrqQX+5ygK/h3gQcWhIwzVBdWBpEknJxawxXNEtx2YST0Ik2ssiYNCfyaYwReofe7HBdHY9ITMKkUD9iNET3AIE9wThKelww= Received: by 10.142.201.3 with SMTP id y3mr2000464wff.120.1209385345874; Mon, 28 Apr 2008 05:22:25 -0700 (PDT) Received: by 10.142.97.21 with HTTP; Mon, 28 Apr 2008 05:22:25 -0700 (PDT) Message-ID: Date: Mon, 28 Apr 2008 14:22:25 +0200 From: "Arnold Schwaighofer" To: bug-gnu-emacs@gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-Mailman-Approved-At: Mon, 28 Apr 2008 11:20:10 -0400 Subject: HEAD: Bug in simple.el/minibuffer.el causing display-completion-list to delete not only word to be completed but everything in file before it X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Errors-To: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-1.872, requis 5, BAYES_00 -2.60, RCVD_BY_IP 0.07, RECEIVED_FROM_NOUNK 0.66, SPF_HELO_PASS -0.00, STOCK_S_SYMB 0.00) X-DIRO-MailScanner-From: bug-gnu-emacs-bounces+monnier=iro.umontreal.ca@gnu.org Problem: In current HEAD display-completion-list deletes not only word to be completed but everything in file before it. example: (defun my-complete-test () (interactive) (with-output-to-temp-buffer "*Completions*" (display-completion-list '("test1" "test2" "test345") "test"))) and call that function in a buffer on the word "test" (M-x my-complete-test) with some text preceeding "test". deletes everything before word "test" instead of just replacing it. This also happens when using the complete-tag function :(. My interpretation of the problem :). minibuffer.el: display-completion-list (set (make-local-variable 'completion-base-size) (or (cdr last) 0)) sets completion-base-size to 0 which causes everything to be deleted before the word to be completed. the problem seems to be related to completion-setup-function in simple.el checking for completion-base-size where i believe it should check for completion-all-completions-with-base-size is it possible that it should read: Index: lisp/simple.el =================================================================== RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.924 diff -r1.924 simple.el 5527c5527 < (unless completion-base-size --- > (unless completion-all-completions-with-base-size after applying that patch completion works for me. ------------=_1218759905-14231-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.4 required=4.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 163-done) by emacsbugs.donarmstrong.com; 15 Aug 2008 00:15:33 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7F0FNL2012407; Thu, 14 Aug 2008 17:15:24 -0700 Received: by cyd (Postfix, from userid 1000) id 92A8257E323; Thu, 14 Aug 2008 20:16:05 -0400 (EDT) From: Chong Yidong To: "Drew Adams" , "Arnold Schwaighofer" Cc: Stefan Monnier , 591-done@emacsbugs.donarmstrong.com, 163-done@emacsbugs.donarmstrong.com Subject: Re: 23.0.60; lisp-complete-symbol erases extra text Date: Thu, 14 Aug 2008 20:16:05 -0400 Message-ID: <87ljyzuo8q.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii I've checked in a fix for the lisp-complete-symbol erasing buffer text problem. ------------=_1218759905-14231-0--