bug#1527: marked as done (scroll-bar-mode should use define-minor-mode)

bug#1527: marked as done (scroll-bar-mode should use define-minor-mode)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 928 bytes --]


Your message dated Tue, 24 Feb 2009 17:11:39 +0100
with message-id <f7ccd24b0902240811g51b18f4fr1d317a593bb06367@mail.gmail.com>
and subject line Re: 22.2.50; doc strings: menu-bar-mode scroll-bar-mode tool-bar-mode
has caused the Emacs bug report #1527,
regarding scroll-bar-mode should use define-minor-mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1527: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1527
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4917 bytes --]

From: Stefan Monnier <monnier@iro.umontreal.ca>
To: quiet@emacsbugs.donarmstrong.com
Subject: scroll-bar-mode should use define-minor-mode
Date: Sun, 27 Apr 2008 21:43:24 -0400
Message-ID: <92skown2w0.fsf@fencepost.gnu.org>

Severity: minor

[ resent from
  http://lists.gnu.org/archive/html/emacs-devel/2008-04/msg01951.html ]

>> | (scroll-bar-mode &optional flag)
>> | [...]
>> | With a numeric argument, if the argument is negative,
>> | turn off scroll bars; otherwise, turn on scroll bars.

> Actually, `(scroll-bar-mode 0)' does turn on the mode.

Does it?  Sounds like a bug.  Could someone make it use
define-minor-mode to avoid such inconsistency.


        Stefan



[-- Attachment #3: Type: message/rfc822, Size: 2841 bytes --]

From: Juanma Barranquero <lekktu@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 1527-done@emacsbugs.donarmstrong.com
Subject: Re: 22.2.50; doc strings: menu-bar-mode scroll-bar-mode tool-bar-mode
Date: Tue, 24 Feb 2009 17:11:39 +0100
Message-ID: <f7ccd24b0902240811g51b18f4fr1d317a593bb06367@mail.gmail.com>

On Mon, Apr 28, 2008 at 02:43, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> Actually, `(scroll-bar-mode 0)' does turn on the mode.
>
> Does it?  Sounds like a bug.

Fixed.

> Could someone make it use
> define-minor-mode to avoid such inconsistency.

scroll-bar-mode is not well suited to define-minor-mode, because the
controlling variable is tri-state.

    Juanma