From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1420: marked as done (annotate from log-view displays junk buffer) Date: Mon, 24 Nov 2008 13:30:03 -0800 Message-ID: References: <87k5as6crn.fsf@cyd.mit.edu> <200811241139.mAOBdksX027926@rapture.ingate.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1227562203-21674-0" X-Trace: ger.gmane.org 1227562781 3444 80.91.229.12 (24 Nov 2008 21:39:41 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Nov 2008 21:39:41 +0000 (UTC) To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 24 22:40:43 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L4jAf-0004G8-8D for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Nov 2008 22:40:42 +0100 Original-Received: from localhost ([127.0.0.1]:51591 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4j9V-0000mL-RX for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Nov 2008 16:39:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4j0f-0007PN-Ld for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 16:30:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4j0e-0007Oa-Iy for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 16:30:20 -0500 Original-Received: from [199.232.76.173] (port=58740 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4j0e-0007OT-1H for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 16:30:20 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:43027) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L4j0d-0004lr-J8 for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 16:30:20 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAOLUAuH022262; Mon, 24 Nov 2008 13:30:10 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mAOLU3sD021700; Mon, 24 Nov 2008 13:30:03 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1420 X-Emacs-PR-Package: emacs X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22637 Archived-At: This is a multi-part message in MIME format... ------------=_1227562203-21674-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 24 Nov 2008 16:21:32 -0500 with message-id <87k5as6crn.fsf@cyd.mit.edu> and subject line Re: annotate from log-view displays junk buffer has caused the Emacs bug report #1420, regarding annotate from log-view displays junk buffer to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1420: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1420 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1227562203-21674-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Nov 2008 16:07:11 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAOG76r3002738 for ; Mon, 24 Nov 2008 08:07:08 -0800 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L4dxo-0002ry-Ut for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 11:07:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L4dxn-0002q7-7L for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 11:07:03 -0500 Received: from [199.232.76.173] (port=50544 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L4dlH-0001Ux-Ly for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 10:54:07 -0500 Received: from usagi.ingate.se ([193.180.23.12]:46443) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L4ZnL-0003dC-OK for bug-gnu-emacs@gnu.org; Mon, 24 Nov 2008 06:40:00 -0500 Received: from rapture.ingate.se (rapture.ingate.se [193.180.23.42]) by usagi.ingate.se (8.12.11.20060308/8.12.11) with ESMTP id mAOBdrDu030107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 24 Nov 2008 12:39:55 +0100 Received: from rapture.ingate.se (localhost.localdomain [127.0.0.1]) by rapture.ingate.se (8.13.1/8.12.11) with ESMTP id mAOBdrhU027932; Mon, 24 Nov 2008 12:39:53 +0100 Received: (from ceder@localhost) by rapture.ingate.se (8.13.1/8.13.1/Submit) id mAOBdksX027926; Mon, 24 Nov 2008 12:39:46 +0100 Date: Mon, 24 Nov 2008 12:39:46 +0100 Message-Id: <200811241139.mAOBdksX027926@rapture.ingate.se> From: Per Cederqvist CC: ceder@lysator.liu.se To: bug-gnu-emacs@gnu.org Subject: annotate from log-view displays junk buffer X-Virus-Scanned: ClamAV version 0.94.1, clamav-milter version 0.94.1 on usagi.ingate.se X-Virus-Status: Clean X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (usagi.ingate.se [193.180.23.12]); Mon, 24 Nov 2008 12:39:56 +0100 (CET) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) 1. Open a version-controlled file. (The one I used is maintained by Mercurial, but I don't think that matters.) 2. Bring up the log of revisions with "C-x v l" (vc-print-log). 3. Move to an interesting revision with TAB. 4. Press "a" to annotate that revision (log-view-annotate-version). The annotations are properly inserted in a buffer named "*Annotate slidegtk.py (rev 19)*", but that buffer is not displayed. Instead, an empty buffer named "Annotating... done" is displayed. The cause seems to be that log-view-annotate-version expects vc-annotate to return the buffer. But at least in Emacs 22.3, vc-annotate returns whatever the function message returns. The following patch seems to fix the problem: --- vc.el~ 2008-11-24 12:25:24.857985150 +0100 +++ vc.el 2008-11-24 12:25:46.288999164 +0100 @@ -3223,7 +3223,8 @@ display-mode))) (when current-line (goto-line current-line temp-buffer-name)) - (message "Annotating... done"))) + (message "Annotating... done") + temp-buffer-name)) (defun vc-annotate-prev-version (prefix) "Visit the annotation of the version previous to this one. In GNU Emacs 22.3.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-09-10 on yagi.ingate.se Windowing system distributor `The X.Org Foundation', version 11.0.60802000 configured using `configure '--prefix=/sw/emacs/22.3'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t line-number-mode: t Recent input: C-x C-f s C-x v l a M-x r e p o r t - e m a c s - b u g Recent messages: Loading log-view... Loading easy-mmode...done Loading log-view...done Annotating... Loading help-mode...done Redisplaying annotation...done Annotating... done Loading emacsbug... Loading regexp-opt...done Loading emacsbug...done ------------=_1227562203-21674-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.0 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1420-done) by emacsbugs.donarmstrong.com; 24 Nov 2008 21:21:15 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAOLLCt8020363 for <1420-done@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 13:21:14 -0800 Received: by cyd.mit.edu (Postfix, from userid 1000) id 27FA657E1C8; Mon, 24 Nov 2008 16:21:32 -0500 (EST) From: Chong Yidong To: Per Cederqvist Cc: 1420-done@emacsbugs.donarmstrong.com, ceder@lysator.liu.se Subject: Re: annotate from log-view displays junk buffer Date: Mon, 24 Nov 2008 16:21:32 -0500 Message-ID: <87k5as6crn.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > The cause seems to be that log-view-annotate-version expects > vc-annotate to return the buffer. But at least in Emacs 22.3, > vc-annotate returns whatever the function message returns. The > following patch seems to fix the problem: I fixed this with a change to log-view-annotate-version instead. Thanks for the bug report. ------------=_1227562203-21674-0--