bug#1416: marked as done (23.0.60; define-mail-abbrev adds quotes when it shouldn't)

[don@donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]


Your message dated Tue, 25 Nov 2008 21:50:40 -0500
with message-id <87myfn2oan.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; define-mail-abbrev adds quotes when it shouldn't
has caused the Emacs bug report #1416,
regarding 23.0.60; define-mail-abbrev adds quotes when it shouldn't
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1416: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1416
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5729 bytes --]

From: happy@mcplaksin.org
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; define-mail-abbrev adds quotes when it shouldn't
Date: Sat, 22 Nov 2008 14:09:24 -0500
Message-ID: <ws3ahja87v.fsf@stone.tss.usg.edu>

If you put quotes into an email address, define-mail-abbrev adds a second
set of quotes.  The extra quotes make the email address invalid.  For
example:
(define-mail-abbrev "jojo" "\"Mark A. Plaksin\" <happy@mcplaksin.org>")
"jojo"
(abbrev-expansion "jojo" mail-abbrevs)
"\"\"Mark A. Plaksin\"\" <happy@mcplaksin.org>"

It does the right think if you supply an address that needs quotes added
like this:
(define-mail-abbrev "jojo" "Mark A. Plaksin <happy@mcplaksin.org>")
"jojo"
(abbrev-expansion "jojo" mail-abbrevs)
"\"Mark A. Plaksin\" <happy@mcplaksin.org>"


In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.9)
 of 2008-08-15 on fire, modified by Debian
 (emacs-snapshot package, version 1:20080815-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10400090
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2''

Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  erc-track-mode: t
  erc-spelling-mode: t
  erc-ring-mode: t
  erc-pcomplete-mode: t
  erc-netsplit-mode: t
  erc-match-mode: t
  erc-log-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-autoaway-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-readonly-mode: t
  savehist-mode: t
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  desktop-save-mode: t
  display-time-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  transient-mark-mode: t

Recent input:
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f A . SPC C-e C-j C-n C-e C-j 
C-p C-p C-p C-p C-p C-p C-p C-p C-f C-f C-f C-f C-f 
C-p C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f A . SPC C-e C-j C-k C-e C-j C-k 
C-k C-k C-p C-p C-p C-k C-k C-j C-j C-_ C-_ C-n C-n 
C-n C-n C-k C-k C-k C-x 1 C-p C-p C-p C-p C-p C-@ C-n 
C-n C-n C-n C-n C-n C-n ESC w C-^ RET ESC x r e p o 
r b RET m a i l C-g C-^ C-n C-p RET C-^ C-n C-p C-g 
C-p C-p C-p C-f C-@ C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f ESC q ESC w 
C-^ C-g ESC x b b DEL DEL DEL r e p o r t m DEL 0 DEL 
- e m TAB g DEL b TAB RET C-y a d d s SPC q u o t e 
s SPC w h e n SPC i t SPC h s o u l d DEL DEL DEL DEL 
DEL DEL s h o u l d n ' t RET y C-x 1 C-y C-a C-k C-k 
C-^ C-n RET C-p C-p C-p C-p C-a C-@ C-n C-n C-n C-n 
C-n C-n C-n ESC w C-^ C-n RET C-y C-v C-v ESC < C-n 
C-n C-n C-n C-n C-n C-p C-p C-p C-n C-p C-n C-p C-d 
C-_ C-n C-n C-n C-x k RET ESC x r e p o r b RET

Recent messages:
Mark activated
Mark set [3 times]
Undo! [2 times]
Mark set
Quit [2 times]
Mark set
Quit
Reinitialize buffer, and disconnect it from the visited file? (y or n) 
Mark set [4 times]
Undo!



[-- Attachment #3: Type: message/rfc822, Size: 1147 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: happy@mcplaksin.org
Cc: 1416-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; define-mail-abbrev adds quotes when it shouldn't
Date: Tue, 25 Nov 2008 21:50:40 -0500
Message-ID: <87myfn2oan.fsf@cyd.mit.edu>

> If you put quotes into an email address, define-mail-abbrev adds a
> second set of quotes.  The extra quotes make the email address
> invalid.

I've checked in a fix.  Thanks for the bug report.