From: don@donarmstrong.com (Emacs bug Tracking System)
To: Adrian Robert <arobert@interstitiality.net>
Subject: bug#1414: marked as done (23.0.60; Middle mouse button does not work in Cocoa port)
Date: Mon, 24 Nov 2008 20:25:09 -0800 [thread overview]
Message-ID: <handler.1414.D1048.122758667532110.ackdone@emacsbugs.donarmstrong.com> (raw)
In-Reply-To: A3B8BEA1-884A-40C4-93D9-FE2063DE2B4C@gmail.com
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
Your message dated Mon, 24 Nov 2008 23:14:41 -0500
with message-id <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
and subject line #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
has caused the Emacs bug report #1048,
regarding 23.0.60; Middle mouse button does not work in Cocoa port
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)
--
1048: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1048
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 5800 bytes --]
[-- Attachment #2.1.1: Type: text/plain, Size: 670 bytes --]
Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.
Your bug report will be posted to the emacs-pretest-bug@gnu.org
mailing list.
Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:
Clicking the middle mouse button does not have an effect. The attached
patch fixes this issue.
In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, NS apple-
appkit-824.48)
of 2008-11-21 on Onyx.local
Windowing system distributor `Apple', version
97.112.112.108.101.45.97.112.112.107.105.116.45.56.50.52.46.52.56
configured using `configure '--with-ns''
[-- Attachment #2.1.2: nsterm.patch --]
[-- Type: application/octet-stream, Size: 1692 bytes --]
Index: src/nsterm.m
===================================================================
RCS file: /sources/emacs/emacs/src/nsterm.m,v
retrieving revision 1.35
diff -u -r1.35 nsterm.m
--- src/nsterm.m 15 Nov 2008 05:20:49 -0000 1.35
+++ src/nsterm.m 23 Nov 2008 11:54:29 -0000
@@ -260,9 +260,12 @@
#define EV_UDMODIFIERS(e) \
((([e type] == NSLeftMouseDown) ? down_modifier : 0) \
| (([e type] == NSRightMouseDown) ? down_modifier : 0) \
+ | (([e type] == NSOtherMouseDown) ? down_modifier : 0) \
| (([e type] == NSLeftMouseDragged) ? down_modifier : 0) \
| (([e type] == NSRightMouseDragged) ? down_modifier : 0) \
+ | (([e type] == NSOtherMouseDragged) ? down_modifier : 0) \
| (([e type] == NSLeftMouseUp) ? up_modifier : 0) \
+ | (([e type] == NSOtherMouseUp) ? up_modifier : 0) \
| (([e type] == NSRightMouseUp) ? up_modifier : 0))
#define EV_BUTTON(e) \
@@ -4725,6 +4728,13 @@
}
+- (void)otherMouseDown: (NSEvent *)theEvent
+{
+ NSTRACE (otherMouseDown);
+ [self mouseDown: theEvent];
+}
+
+
- (void)rightMouseUp: (NSEvent *)theEvent
{
NSTRACE (rightMouseUp);
@@ -4732,6 +4742,13 @@
}
+- (void)otherMouseUp: (NSEvent *)theEvent
+{
+ NSTRACE (otherMouseUp);
+ [self mouseDown: theEvent];
+}
+
+
- (void) scrollWheel: (NSEvent *)theEvent
{
NSTRACE (scrollWheel);
@@ -4800,6 +4817,13 @@
}
+- (void)otherMouseDragged: (NSEvent *)e
+{
+ NSTRACE (otherMouseDragged);
+ [self mouseMoved: e];
+}
+
+
- (BOOL)windowShouldClose: (id)sender
{
NSEvent *e =[[self window] currentEvent];
[-- Attachment #3: Type: message/rfc822, Size: 1616 bytes --]
From: Adrian Robert <arobert@interstitiality.net>
To: 1048-done@emacsbugs.donarmstrong.com
Subject: #1048 - 23.0.60; No Mouse 2 (Cocoa Emacs) - Emacs bug report logs
Date: Mon, 24 Nov 2008 23:14:41 -0500
Message-ID: <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
Closing, applied patch from Wolfgang Lux.
prev parent reply other threads:[~2008-11-25 4:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <476D6C3A-F61F-42C5-821C-7929DBB31B13@interstitiality.net>
2008-09-28 7:27 ` bug#1048: 23.0.60; No Mouse 2 (Cocoa Emacs) Nick Roberts
2008-11-25 4:25 ` bug#1048: marked as done (23.0.60; No Mouse 2 (Cocoa Emacs)) Emacs bug Tracking System
2008-11-16 14:35 ` bug#1357: 23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns) Harald Hanche-Olsen
[not found] ` <handler.1357.B.122684613725092.ack@emacsbugs.donarmstrong.com>
2008-11-17 6:42 ` bug#1357: Acknowledgement (23.0.60; Mouse button 2 is not recognized (on Mac; --with-ns)) Harald Hanche-Olsen
2008-11-25 4:25 ` bug#1357: marked as done " Emacs bug Tracking System
2008-11-23 11:56 ` bug#1414: 23.0.60; Middle mouse button does not work in Cocoa port Wolfgang Lux
2008-11-25 4:25 ` Emacs bug Tracking System [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=handler.1414.D1048.122758667532110.ackdone@emacsbugs.donarmstrong.com \
--to=don@donarmstrong.com \
--cc=arobert@interstitiality.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.