bug#1374: 23.0.60; directory-files unexpectedly non-nil

bug#1374: 23.0.60; directory-files unexpectedly non-nil

[Markus Triska]

Let ~/tmp be initially empty, and create these 7 files in it via:

  for i in 0085-ottosson.ps.gz 0091-lindgren.ps.gz    \
           0104-pettersson-carlsson.ps.gz 0108-carlsson.ps.gz   \
           0118-lindgren.ps.gz 1076.pdf apl_slides.pdf; do touch $i; done

As expected,

   (directory-files "~/tmp" nil "nonexistent")

then yields "nil". However, after I evaluate (in emacs -Q) the forms:

   (defun my-log (start end old)
     (write-region (point-min) (point-min) "/tmp/my-log-file.tmp" t 'silent))

   (add-hook 'after-change-functions 'my-log)

the new result of

   (directory-files "~/tmp" nil "nonexistent")

is unexpectedly:

   ("apl_slides.pdf")

using OSX. In Ubuntu Intrepid, the new result is, again unexpectedly:

   ("1076.pdf")

In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-11-05 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

bug#1374: marked as done (23.0.60; directory-files unexpectedly non-nil)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]


Your message dated Sat, 06 Dec 2008 20:02:24 -0500
with message-id <87d4g44x27.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; directory-files unexpectedly non-nil
has caused the Emacs bug report #1374,
regarding 23.0.60; directory-files unexpectedly non-nil
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1374: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1374
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3256 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; directory-files unexpectedly non-nil
Date: Wed, 19 Nov 2008 05:01:09 +0100 (CET)
Message-ID: <20081119040109.AFF45BBF1F9@mt-computer.local>


Let ~/tmp be initially empty, and create these 7 files in it via:

  for i in 0085-ottosson.ps.gz 0091-lindgren.ps.gz    \
           0104-pettersson-carlsson.ps.gz 0108-carlsson.ps.gz   \
           0118-lindgren.ps.gz 1076.pdf apl_slides.pdf; do touch $i; done

As expected,

   (directory-files "~/tmp" nil "nonexistent")

then yields "nil". However, after I evaluate (in emacs -Q) the forms:

   (defun my-log (start end old)
     (write-region (point-min) (point-min) "/tmp/my-log-file.tmp" t 'silent))

   (add-hook 'after-change-functions 'my-log)

the new result of

   (directory-files "~/tmp" nil "nonexistent")

is unexpectedly:

   ("apl_slides.pdf")

using OSX. In Ubuntu Intrepid, the new result is, again unexpectedly:

   ("1076.pdf")

In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-11-05 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t



[-- Attachment #3: Type: message/rfc822, Size: 1316 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Markus Triska <markus.triska@gmx.at>
Cc: 1374-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; directory-files unexpectedly non-nil
Date: Sat, 06 Dec 2008 20:02:24 -0500
Message-ID: <87d4g44x27.fsf@cyd.mit.edu>

This bug arose because the after-change-functions were triggered in the
code conversion work buffer, whereas directory-files assumed that
decoding a file name does not run arbitrary elisp code (otherwise, a
compiled regexp gets corrupted).  I've changed it so that
inhibit-modification-hooks is disabled in the code conversion buffer.

Thanks for the bug report.