bug#1248: 23.0.60; problems with `color' custom type

bug#1248: 23.0.60; problems with `color' custom type

[Drew Adams]

emacs -Q
Eval this: (defcustom foo "Red" "..." :type 'color)
 
M-x set-variable foo RET Blue RET
 
gives error "Value `Blue' does not match type color of foo". Likewise,
if I try BlueViolet.
 
M-x customize-option foo
 
Empty the value field and hit M-TAB. The colors are displayed in a
crazy order, not alphabetically. And there is no color `Blue' in the
list. But you can enter the text `Blue' anyway and choose Set for
Session from the menu. So the completion must be lax, which is
good. 
 
But why does `set-variable' say that `Blue' does not match type
`color'? And it says the same thing for `BlueViolet', which is one of
the names available using completion in Customize.
 
And `set-variable' too should offer completion (enhancement request).


In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 

bug#1248: marked as done (23.0.60; problems with `color' custom type)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 846 bytes --]


Your message dated Sat, 25 Oct 2008 14:36:45 -0400
with message-id <87ej248qte.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; problems with `color' custom type
has caused the Emacs bug report #1248,
regarding 23.0.60; problems with `color' custom type
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1248: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1248
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3510 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.60; problems with `color' custom type
Date: Sat, 25 Oct 2008 08:51:39 -0700
Message-ID: <00b501c936b9$91af6350$0200a8c0@us.oracle.com>

emacs -Q
Eval this: (defcustom foo "Red" "..." :type 'color)
 
M-x set-variable foo RET Blue RET
 
gives error "Value `Blue' does not match type color of foo". Likewise,
if I try BlueViolet.
 
M-x customize-option foo
 
Empty the value field and hit M-TAB. The colors are displayed in a
crazy order, not alphabetically. And there is no color `Blue' in the
list. But you can enter the text `Blue' anyway and choose Set for
Session from the menu. So the completion must be lax, which is
good. 
 
But why does `set-variable' say that `Blue' does not match type
`color'? And it says the same thing for `BlueViolet', which is one of
the names available using completion in Customize.
 
And `set-variable' too should offer completion (enhancement request).


In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 




[-- Attachment #3: Type: message/rfc822, Size: 1465 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 1248-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; problems with `color' custom type
Date: Sat, 25 Oct 2008 14:36:45 -0400
Message-ID: <87ej248qte.fsf@cyd.mit.edu>

> emacs -Q
> Eval this: (defcustom foo "Red" "..." :type 'color)
> 
> M-x set-variable foo RET Blue RET
> 
> gives error "Value `Blue' does not match type color of foo".

You want to do

  M-x set-variable foo RET "Blue" RET

because set-variable reads entries in Lisp form, and foo needs to be a
string.

> Empty the value field and hit M-TAB. The colors are displayed in a
> crazy order, not alphabetically.

They are listed in the same order of list-colors-display.  I've changed
that to make it alphabetical.