From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1239: marked as done (PATCH: Fix corner case of texinfo-insert-quote) Date: Mon, 1 Dec 2008 19:45:04 -0800 Message-ID: References: <4902089E.9030302@garden.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1228189504-26132-0" X-Trace: ger.gmane.org 1228189846 15651 80.91.229.12 (2 Dec 2008 03:50:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Dec 2008 03:50:46 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 02 04:51:49 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L7MIc-0003Yg-U4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Dec 2008 04:51:47 +0100 Original-Received: from localhost ([127.0.0.1]:50016 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7MHS-0005Ta-KL for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Dec 2008 22:50:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L7MHD-0005KH-2u for bug-gnu-emacs@gnu.org; Mon, 01 Dec 2008 22:50:19 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L7MHC-0005Jy-9G for bug-gnu-emacs@gnu.org; Mon, 01 Dec 2008 22:50:18 -0500 Original-Received: from [199.232.76.173] (port=48797 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L7MHC-0005Jp-1K for bug-gnu-emacs@gnu.org; Mon, 01 Dec 2008 22:50:18 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:51017) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L7MH9-0002CJ-5O; Mon, 01 Dec 2008 22:50:15 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB23oCkE028056; Mon, 1 Dec 2008 19:50:13 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id mB23j4qP026235; Mon, 1 Dec 2008 19:45:04 -0800 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1239 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:22829 Archived-At: This is a multi-part message in MIME format... ------------=_1228189504-26132-0 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Your message dated Mon, 01 Dec 2008 22:37:34 -0500 with message-id and subject line Re: bug#1239: PATCH: Fix corner case of texinfo-insert-quo= te has caused the Emacs bug report #1239, regarding PATCH: Fix corner case of texinfo-insert-quote to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1239: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1239 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1228189504-26132-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.0 required=4.0 tests=BAYES_00,GMAIL,MIXEDBDN, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Oct 2008 17:41:15 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9OHfAvs004695 for ; Fri, 24 Oct 2008 10:41:12 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KtQes-0005fS-SM for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:41:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KtQep-0005fF-E2 for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:41:09 -0400 Received: from [199.232.76.173] (port=53404 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KtQep-0005fC-7w for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:41:07 -0400 Received: from host13.natgard1.cust.sover.net ([207.136.219.173]:52137 helo=marigold.garden.org) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KtQeo-000383-Di for bug-gnu-emacs@gnu.org; Fri, 24 Oct 2008 13:41:06 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by marigold.garden.org (Postfix) with ESMTP id 363C5681A9 for ; Fri, 24 Oct 2008 13:41:01 -0400 (EDT) X-Virus-Scanned: amavisd-new at garden.org Received: from marigold.garden.org ([127.0.0.1]) by localhost (marigold.garden.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k1K6wUpOGp3j for ; Fri, 24 Oct 2008 13:40:55 -0400 (EDT) Received: from localhost.localdomain (unknown [192.168.219.109]) by marigold.garden.org (Postfix) with ESMTP id 99522680EE for ; Fri, 24 Oct 2008 13:40:55 -0400 (EDT) Message-ID: <4902089E.9030302@garden.org> Date: Fri, 24 Oct 2008 13:40:46 -0400 From: "Aaron S. Hawley" User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: PATCH: Fix corner case of texinfo-insert-quote Content-Type: multipart/mixed; boundary="------------080408080708000509060700" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) This is a multi-part message in MIME format. --------------080408080708000509060700 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Patch is attached and in-line. It would be nice to have this, in case one tries to do quotation mark manipulation with with-temp-buffer. Thanks for Emacs, /a Index: ChangeLog =================================================================== RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.14668 diff -u -r1.14668 ChangeLog --- ChangeLog 24 Oct 2008 09:39:28 -0000 1.14668 +++ ChangeLog 24 Oct 2008 17:29:37 -0000 @@ -1,3 +1,8 @@ +2008-10-24 Aaron S. Hawley + + * textmodes/texinfo.el (texinfo-insert-quote): Handle corner + case where point is at the beginning of the buffer. + 2008-10-24 Juanma Barranquero * subr.el (locate-user-emacs-file): New function. Index: textmodes/texinfo.el =================================================================== RCS file: /sources/emacs/emacs/lisp/textmodes/texinfo.el,v retrieving revision 1.122 diff -u -r1.122 texinfo.el --- textmodes/texinfo.el 6 May 2008 04:33:13 -0000 1.122 +++ textmodes/texinfo.el 24 Oct 2008 17:29:37 -0000 @@ -682,7 +682,9 @@ (if (or arg (= (preceding-char) ?\\) (save-excursion - (backward-char (length texinfo-open-quote)) + (if (> (point) (length texinfo-open-quote)) + (backward-char (length texinfo-open-quote)) + (goto-char (point-min))) (when (or (looking-at texinfo-open-quote) (looking-at texinfo-close-quote)) (delete-char (length texinfo-open-quote)) @@ -694,7 +696,8 @@ (setq in-env t))))) (self-insert-command (prefix-numeric-value arg)) (insert - (if (memq (char-syntax (preceding-char)) '(?\( ?> ?\s)) + (if (or (bobp) ;; (eq (preceding-char) 0) + (memq (char-syntax (preceding-char)) '(?\( ?> ?\s))) texinfo-open-quote texinfo-close-quote))))) --------------080408080708000509060700 Content-Type: text/plain; name="texinfo.el-bobp.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="texinfo.el-bobp.diff" Index: ChangeLog =================================================================== RCS file: /sources/emacs/emacs/lisp/ChangeLog,v retrieving revision 1.14668 diff -u -r1.14668 ChangeLog --- ChangeLog 24 Oct 2008 09:39:28 -0000 1.14668 +++ ChangeLog 24 Oct 2008 17:29:37 -0000 @@ -1,3 +1,8 @@ +2008-10-24 Aaron S. Hawley + + * textmodes/texinfo.el (texinfo-insert-quote): Handle corner + case where point is at the beginning of the buffer. + 2008-10-24 Juanma Barranquero * subr.el (locate-user-emacs-file): New function. Index: textmodes/texinfo.el =================================================================== RCS file: /sources/emacs/emacs/lisp/textmodes/texinfo.el,v retrieving revision 1.122 diff -u -r1.122 texinfo.el --- textmodes/texinfo.el 6 May 2008 04:33:13 -0000 1.122 +++ textmodes/texinfo.el 24 Oct 2008 17:29:37 -0000 @@ -682,7 +682,9 @@ (if (or arg (= (preceding-char) ?\\) (save-excursion - (backward-char (length texinfo-open-quote)) + (if (> (point) (length texinfo-open-quote)) + (backward-char (length texinfo-open-quote)) + (goto-char (point-min))) (when (or (looking-at texinfo-open-quote) (looking-at texinfo-close-quote)) (delete-char (length texinfo-open-quote)) @@ -694,7 +696,8 @@ (setq in-env t))))) (self-insert-command (prefix-numeric-value arg)) (insert - (if (memq (char-syntax (preceding-char)) '(?\( ?> ?\s)) + (if (or (bobp) ;; (eq (preceding-char) 0) + (memq (char-syntax (preceding-char)) '(?\( ?> ?\s))) texinfo-open-quote texinfo-close-quote))))) --------------080408080708000509060700-- ------------=_1228189504-26132-0 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1239-done) by emacsbugs.donarmstrong.com; 2 Dec 2008 03:38:04 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB23c1fp024803 for <1239-done@emacsbugs.donarmstrong.com>; Mon, 1 Dec 2008 19:38:02 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L7M4s-00009m-Tm; Mon, 01 Dec 2008 22:37:34 -0500 From: Glenn Morris To: 1239-done@emacsbugs.donarmstrong.com Subject: Re: bug#1239: PATCH: Fix corner case of texinfo-insert-quote References: <4902089E.9030302@garden.org> X-Spook: MD2 illuminati Soviet IRA MD4 $400 million in gold X-Ran: 0F~AL,NAiN3=S{$VOu~eJ#/'IbwKpST((S7S-Yx55~uYq[8KaG:YOarjl65J}MiVwEwX3p X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 01 Dec 2008 22:37:34 -0500 In-Reply-To: <4902089E.9030302@garden.org> (Aaron S. Hawley's message of "Fri, 24 Oct 2008 13:40:46 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii OK; installed. 2008-12-02 Aaron S. Hawley * textmodes/texinfo.el (texinfo-insert-quote): Handle corner case where point is at the beginning of the buffer. (Bug#1239) ------------=_1228189504-26132-0--