bug#1198: 23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message

bug#1198: 23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message

[Drew Adams]

emacs -Q
M-x load-library bookmark
M-: (bookmark-jump-noselect "jjkljklj")
 
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-exists-p(nil)
  bookmark-file-or-variation-thereof(nil)
  bookmark-default-handler(nil)
  byte-code...
 
The error occurs because the string argument is not a known
bookmark. The error message should say something like that.
 
When (bookmark-get-bookmark bookmark) returns nil, the handler should
not be applied. Instead, a reasonable message should be displayed.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t
 
Major mode: Debugger
 
Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
 
Recent input:
<help-echo> M-x b o C-g C-g M-: ( b o o k m a r k - 
j u m p - n o s e l e c t SPC " j k j k l j " ) <return> 
q M-x l 0 o a d <backspace> <backspace> <backspace> 
<backspace> o a d - l i b <return> b o o k m a r k 
<return> C-x <escape> <escape> M-p <return> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>
 
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Quit [2 times]
Entering debugger...
Back to top level.
Loading bookmark...done
Entering debugger...

bug#1198: marked as done (23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]


Your message dated Wed, 29 Oct 2008 14:22:55 -0400
with message-id <873aifgt1c.fsf@cyd.mit.edu>
and subject line Re: 23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message
has caused the Emacs bug report #1198,
regarding 23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1198: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1198
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4914 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: 23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message
Date: Fri, 17 Oct 2008 23:45:17 -0700
Message-ID: <003b01c930ed$15a09e40$0200a8c0@us.oracle.com>

emacs -Q
M-x load-library bookmark
M-: (bookmark-jump-noselect "jjkljklj")
 
Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  file-exists-p(nil)
  bookmark-file-or-variation-thereof(nil)
  bookmark-default-handler(nil)
  byte-code...
 
The error occurs because the string argument is not a known
bookmark. The error message should say something like that.
 
When (bookmark-get-bookmark bookmark) returns nil, the handler should
not be applied. Instead, a reasonable message should be displayed.
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-10-03 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t
 
Major mode: Debugger
 
Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
 
Recent input:
<help-echo> M-x b o C-g C-g M-: ( b o o k m a r k - 
j u m p - n o s e l e c t SPC " j k j k l j " ) <return> 
q M-x l 0 o a d <backspace> <backspace> <backspace> 
<backspace> o a d - l i b <return> b o o k m a r k 
<return> C-x <escape> <escape> M-p <return> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>
 
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Quit [2 times]
Entering debugger...
Back to top level.
Loading bookmark...done
Entering debugger...





[-- Attachment #3: Type: message/rfc822, Size: 1042 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 1198-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; (bookmark-jump-noselect "jkjklj") gives bad error message
Date: Wed, 29 Oct 2008 14:22:55 -0400
Message-ID: <873aifgt1c.fsf@cyd.mit.edu>

Thanks, I've checked in a fix.