bug#117: marked as done (23.0.60; messed up frame parameters)

[owner@emacsbugs.donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 875 bytes --]


Your message dated Tue, 30 Dec 2008 23:38:19 +0800
with message-id <495A406B.6090802@gnu.org>
and subject line Re: bug#1724: 23.0.60; fringe appears in spite of specification
has caused the Emacs bug report #117,
regarding 23.0.60; messed up frame parameters
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
117: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=117
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 13616 bytes --]

From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Cc: 
Subject: 23.0.60; messed up frame parameters
Date: Sat, 5 Apr 2008 12:31:02 -0700
Message-ID: <001b01c89753$95b58480$0200a8c0@us.oracle.com>

This is not a complete report from emacs -Q. I don't have the time
for that right now. But this should help. I tried Emacs 23 with my
normal code (not emacs -Q). 
 
Summary: Frame parameters are really messed up.
 
I've included two listings here: (1) the frame parameters from a Dired
buffer in GNU Emacs 22.2.1 (i386-mingw-nt5.1.2600) of 2008-03-26 on
RELEASE and those from the same thing with GNU Emacs 23.0.60.1
(i386-mingw-nt5.1.2600) of 2008-04-04 on LENNART-69DE564. The Emacs 22
listing shows the frame parameters that I want and that my code
specifies. The Emacs 23 parameters are incorrect.
 
Several frame parameters have been changed so that I don't get what I
specified: frame background color, absence/presence of fringe,
etc. These are marked "WRONG" in the Emacs 23 listing.
 
[Actually, the incorrect background color does not appear over the
whole frame. At the end of the buffer/frame, in the empty space after
the last text, the correct background color shows. And as you scroll,
the correct background color flashes over the middle of the frame
momentarily. But the incorrect color (white) returns immediately.]
 
In addition, there are multiple occurrences of parameters - these are
marked "extra" in the listing. Sometimes the values are changed in the
extra occurrences; sometimes the values are the same. Sometimes the an
occurrence with a changed value comes before the occurrence with the
correct value; sometimes it comes after it.
 
In addition, there are new parameters that don't occur in the Emacs
22.2 listing - these are marked "new" in the listing. In some cases,
even these new parameters (which are not provided by my code) are
duplicated.
 
Minor info: Though the right fringe, like the left fringe, has the
incorrect value of 8, visually, the right fringe is twice as wide as
the left fringe - more like 16 than 8. (In any case, I specified 0,
not 8.)
 
Emacs 22.2 Listing of frame-parameters (correct)
------------------------------------------------
(
 (auto-lower)
 (auto-raise)
 (background-color . "LightBlue")
 (background-mode . light)
 (border-color . "black")
 (border-width . 2)
 (buffer-list #<buffer drews-lisp-20>)
 (buffer-predicate)
 (cursor-color . "Red")
 (cursor-type . bar)
 (display . "")
 (display-type . color)
 (explicit-name . t)
 (font . "-outline-Lucida
Console-normal-r-normal-normal-14-105-96-96-c-*-iso8859-1")
 (foreground-color . "Black")
 (height . 57)
 (icon-name)
 (icon-type)
 (internal-border-width . 0)
 (left . 0)
 (left-fringe . 0)
 (line-spacing)
 (menu-bar-lines . 1)
 (minibuffer)
 (modeline . t)
 (mouse-color . "Red")
 (name . "drews-lisp-20")
 (parent-id)
 (right-fringe . 0)
 (screen-gamma)
 (scroll-bar-width . 17)
 (title)
 (tool-bar-lines . 0)
 (top . 0)
 (unsplittable)
 (vertical-scroll-bars . right)
 (visibility . t)
 (width . 49)
 (window-id . "591706")
)
 
Emacs 23 Listing of frame-parameters (incorrect)
------------------------------------------------
 
((parent-id)
 (name . "drews-lisp-20")
 ;; new:
 (font-backend uniscribe gdi)
 ;; extra & WRONG:
 (font . "-outline-courier
new-normal-roman-normal-mono-13-*-*-*-*-*-fontset-startup")
 (border-width . 2)
 (internal-border-width . 0)
 (vertical-scroll-bars . right)
 ;; extra & WRONG:
 (foreground-color . "SystemWindowText")
 ;; extra & WRONG:
 (background-color . "SystemWindow")
 ;; extra & WRONG:
 (mouse-color . "black")
 (cursor-color . "Red")
 (border-color . "black")
 ;; new:
 (screen-gamma)
 (line-spacing)
 ;; extra & WRONG:
 (left-fringe . 8)
 ;; extra & WRONG:
 (right-fringe . 8)
 (menu-bar-lines . 1)
 (tool-bar-lines . 0)
 (buffer-predicate)
 (title)
 (icon-type)
 (auto-raise)
 (auto-lower)
 (cursor-type . bar)
 (scroll-bar-width . 17)
 (visibility . t)
 ;; new:
 (window-system . w32)
 ;; NEW (and false/ineffective):
 (horizontal-scroll-bars . t)
 (display-type . color)
 (background-mode . light)
 ;; new:
 (environment)
 (height . 57)
 (width . 49)
 (modeline . t)
 (minibuffer)
 (unsplittable)
 (buffer-list #<buffer drews-lisp-20>)
 ;; new:
 (buried-buffer-list)
 (left . 0)
 (top . 0)
 (window-id . "984822")
 (icon-name)
 (display . "")
 (explicit-name . t)
 ;; extra:
 (tool-bar-lines . 0)
 ;; extra:
 (menu-bar-lines . 1)
 ;; new:
 (fringe . 0)
 (right-fringe . 0)
 (left-fringe . 0)
 ;; extra:
 (icon-type)
 ;; extra:
 (vertical-scroll-bars . right)
 ;; new:
 (user-position . t)
 ;; extra:
 (minibuffer)
 ;; extra & WRONG:
 (height . 35)
 ;; extra & WRONG:
 (width . 80)
 ;; extra:
 (left . 0)
 ;; extra:
 (top . 0)
 ;; extra:
 (menu-bar-lines . 1)
 ;; extra:
 (cursor-type . bar)
 ;; extra:
 (cursor-color . "Red")
 (mouse-color . "Red")
 (font . "-*-Lucida Console-normal-r-*-*-14-112-96-96-c-*-iso8859-1")
 ;; extra:
 (background-color . "LightBlue")
 ;; extra:
 (foreground-color . "Black")
 ;; extra:
 (tool-bar-lines . 0)
 ;; extra:
 (menu-bar-lines . 1)
 ;; new:
 (reverse)
 ;; extra:
 (user-position . t)
 ;; new:
 (user-size . t)
 ;; extra & WRONG:
 (visibility)
 ;; extra:
 (scroll-bar-width . 17)
 ;; extra:
 (cursor-type . bar)
 ;; extra:
 (auto-lower)
 ;; extra:
 (auto-raise)
 ;; extra:
 (icon-type)
 ;; extra:
 (title)
 ;; extra:
 (buffer-predicate)
 ;; extra:
 (tool-bar-lines . 0)
 ;; extra:
 (menu-bar-lines . 1)
 ;; extra:
 (right-fringe . 0)
 ;; extra:
 (left-fringe . 0)
 ;; extra:
 (line-spacing)
 ;; extra:
 (screen-gamma)
 ;; extra:
 (border-color . "black")
 ;; extra:
 (cursor-color . "Red")
 ;; extra:
 (mouse-color . "Red")
 ;; extra:
 (background-color . "LightBlue")
 ;; extra:
 (foreground-color . "Black")
 ;; extra:
 (vertical-scroll-bars . right)
 ;; extra:
 (internal-border-width . 0)
 ;; extra:
 (border-width . 2)
 ;; extra & (WRONG?):
 (font . "-outline-lucida
console-normal-roman-normal-mono-14-*-*-*-*-*-fontset-startup")
 ;; extra:
 (font-backend uniscribe gdi)
)
 
 
 

In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-04-04 on LENNART-69DE564
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
-fno-crossjumping'
 
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t
 
Major mode: Dired by name
 
Minor modes in effect:
  display-time-mode: t
  savehist-mode: t
  icomplete-mode: t
  tool-bar-pop-up-mode: t
  icicle-mode: t
  minibuffer-indicate-depth-mode: t
  pretty-control-l-mode: t
  delete-selection-mode: t
  tabbar-mode: t
  show-paren-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-compression-mode: t
  size-indication-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
 
Recent input:
<switch-frame> <switch-frame> <help-echo> <help-echo> 
<help-echo> <help-echo> <menu-bar> <help-menu> <se
nd-emacs-bug-report>
 
Recent messages:
Loading delsel...done
Turned OFF automatically telling Customize of outside changes.
Turned ON making cursor a box when Emacs is idle.
Turning ON Icicle mode...done
Loading c:/drews-lisp-20/_drews-customizations.el (source)...
Loading `_drews-customizations.el'...done.
Loading c:/drews-lisp-20/_drews-customizations.el (source)...done
Buffer `*scratch*' is in Lisp Interaction mode.   For info on the mode: `C-h m'.
For information about GNU Emacs and the GNU system, type M-x about-emacs.
Buffer `drews-lisp-20' is in Dired by name mode.   For info on the mode: `h'.






[-- Attachment #3: Type: message/rfc822, Size: 3965 bytes --]

From: Jason Rumney <jasonr@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 1724-done@emacsbugs.donarmstrong.com, 117-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1724: 23.0.60; fringe appears in spite of specification
Date: Tue, 30 Dec 2008 23:38:19 +0800
Message-ID: <495A406B.6090802@gnu.org>

martin rudalics wrote:
> This happens because the relevant code has been commented out in
> x_get_arg:
>
> #ifndef WINDOWSNT /* w32fns.c has not yet been changed to cope with 
> this.  */
>       Lisp_Object tail;
>       XSETCAR (tem, Qnil);
>       /* In case the parameter appears more than once in the alist,
>      clear it out.  */
>       for (tail = alist; CONSP (tail); tail = XCDR (tail))
>     if (CONSP (XCAR (tail))
>         && EQ (XCAR (XCAR (tail)), param))
>       XSETCAR (XCAR (tail), Qnil);
> #endif
>
> I don't know what has to be done in w32fns.c to make this work.

Thanks for finding this. It seems the appropriate change was made to 
w32fns.c on 2008-07-14, from memory it fixed part of the problem Drew 
had reported.

Drew,

I am marking bug#117 as done, since the original bug reported seems to 
be gone now. There are however several other bugs mentioned later in the 
thread, which should have their own bug reports (I know at least some of 
them do, for example bug#119 is mentioned a couple of times, in one case 
referencing the report). If any bugs mentioned there still exist after 
this fix has been applied and do not have an open bug report of their 
own already, please file a separate report for them.