From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: don@donarmstrong.com (Emacs bug Tracking System) Newsgroups: gmane.emacs.bugs Subject: bug#1099: marked as done (23.0.60; Various eshell files need cl at compile time for `assert' ) Date: Wed, 8 Oct 2008 00:50:03 -0700 Message-ID: References: <87bpxy2j31.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----------=_1223452203-15816-0" X-Trace: ger.gmane.org 1223453586 22300 80.91.229.12 (8 Oct 2008 08:13:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Oct 2008 08:13:06 +0000 (UTC) To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 08 10:14:01 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KnUAX-0001bg-9Z for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Oct 2008 10:13:17 +0200 Original-Received: from localhost ([127.0.0.1]:54027 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KnU9S-0003Z9-Qp for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Oct 2008 04:12:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KnU8e-0003Ep-TG for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2008 04:11:20 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KnU8e-0003Dt-2H for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2008 04:11:20 -0400 Original-Received: from [199.232.76.173] (port=48736 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KnU8d-0003Dj-Fw for bug-gnu-emacs@gnu.org; Wed, 08 Oct 2008 04:11:19 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:26916) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KnU8b-0006cY-5w; Wed, 08 Oct 2008 04:11:17 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KnU8a-0007hM-0Y; Wed, 08 Oct 2008 04:11:16 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9889vEp021294; Wed, 8 Oct 2008 01:09:58 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m987o3Qc015877; Wed, 8 Oct 2008 00:50:03 -0700 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: don@donarmstrong.com X-Emacs-PR-Message: closed 1099 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch X-detected-kernel: by mx20.gnu.org: Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:21261 Archived-At: This is a multi-part message in MIME format... ------------=_1223452203-15816-0 Content-Disposition: inline Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Your message dated Wed, 08 Oct 2008 03:42:03 -0400 with message-id and subject line Re: bug#1099: 23.0.60; Various eshell files need cl at com= pile time for `assert' has caused the Emacs bug report #1099, regarding 23.0.60; Various eshell files need cl at compile time for `assert= '=20 to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact don@donarmstrong.com immediately.) --=20 1099: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3D1099 Emacs Bug Tracking System Contact don@donarmstrong.com with problems ------------=_1223452203-15816-0 Content-Type: message/rfc822 Content-Disposition: inline X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.4 required=4.0 tests=AWL,BAYES_00,HAS_PACKAGE, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 6 Oct 2008 09:01:40 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9691Xng029841 for ; Mon, 6 Oct 2008 02:01:34 -0700 Received: from mx10.gnu.org ([199.232.76.166]:55916) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kmlvs-0001Sq-8o for emacs-pretest-bug@gnu.org; Mon, 06 Oct 2008 04:59:12 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kmly6-0005aK-3R for emacs-pretest-bug@gnu.org; Mon, 06 Oct 2008 05:01:31 -0400 Received: from mail.gmx.net ([213.165.64.20]:38049) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Kmly5-0005Xw-9a for emacs-pretest-bug@gnu.org; Mon, 06 Oct 2008 05:01:29 -0400 Received: (qmail invoked by alias); 06 Oct 2008 09:01:24 -0000 Received: from p5486783F.dip.t-dialin.net (EHLO debian) [84.134.120.63] by mail.gmx.net (mp056) with SMTP; 06 Oct 2008 11:01:24 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX19GDm4HE2hGYj+VQaFnle56pHureb4PEdcsoGPnlO VyyTHHpRupc7JY From: Sven Joachim To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Various eshell files need cl at compile time for `assert' Date: Mon, 06 Oct 2008 11:01:22 +0200 Message-ID: <87bpxy2j31.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 X-Y-GMX-Trusted: 0 X-FuHaFi: 0.55 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by rzlab.ucr.edu id m9889vEp021294 Package: emacs Version: 23.0.60 Tags: patch A recent message=B9 on help-gnu-emacs showed eshell failing because `assert' is not defined. There are no less than six eshell files which use this macro without requiring cl at compile time. The following patch takes care of this: --8<---------------cut here---------------start------------->8--- Index: lisp/eshell/em-cmpl.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/eshell/em-cmpl.el,v retrieving revision 1.27 diff -c -r1.27 em-cmpl.el *** lisp/eshell/em-cmpl.el 21 May 2008 03:51:06 -0000 1.27 --- lisp/eshell/em-cmpl.el 6 Oct 2008 08:25:44 -0000 *************** *** 71,76 **** --- 71,77 ---- ;;; Code: =20 (eval-when-compile + (require 'cl) (require 'eshell)) (require 'esh-util) =20 Index: lisp/eshell/em-hist.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/eshell/em-hist.el,v retrieving revision 1.29 diff -c -r1.29 em-hist.el *** lisp/eshell/em-hist.el 21 May 2008 03:51:06 -0000 1.29 --- lisp/eshell/em-hist.el 6 Oct 2008 08:25:44 -0000 *************** *** 55,60 **** --- 55,63 ---- =20 ;;; Code: =20 + (eval-when-compile + (require 'cl)) +=20 (require 'ring) (require 'esh-opt) (require 'em-pred) Index: lisp/eshell/em-ls.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/eshell/em-ls.el,v retrieving revision 1.34 diff -c -r1.34 em-ls.el *** lisp/eshell/em-ls.el 15 Aug 2008 06:55:37 -0000 1.34 --- lisp/eshell/em-ls.el 6 Oct 2008 08:25:44 -0000 *************** *** 27,33 **** =20 ;;; Code: =20 ! (eval-when-compile (require 'eshell)) (require 'esh-util) (require 'esh-opt) =20 --- 27,35 ---- =20 ;;; Code: =20 ! (eval-when-compile ! (require 'cl) ! (require 'eshell)) (require 'esh-util) (require 'esh-opt) =20 Index: lisp/eshell/esh-cmd.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/eshell/esh-cmd.el,v retrieving revision 1.43 diff -c -r1.43 esh-cmd.el *** lisp/eshell/esh-cmd.el 15 Aug 2008 06:55:11 -0000 1.43 --- lisp/eshell/esh-cmd.el 6 Oct 2008 08:25:45 -0000 *************** *** 109,114 **** --- 109,115 ---- (require 'esh-ext) =20 (eval-when-compile + (require 'cl) (require 'pcomplete)) =20 =20 Index: lisp/eshell/esh-ext.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/eshell/esh-ext.el,v retrieving revision 1.29 diff -c -r1.29 esh-ext.el *** lisp/eshell/esh-ext.el 6 May 2008 03:36:20 -0000 1.29 --- lisp/eshell/esh-ext.el 6 Oct 2008 08:25:45 -0000 *************** *** 33,38 **** --- 33,39 ---- (provide 'esh-ext) =20 (eval-when-compile + (require 'cl) (require 'esh-cmd)) (require 'esh-util) =20 Index: lisp/eshell/esh-io.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/eshell/esh-io.el,v retrieving revision 1.23 diff -c -r1.23 esh-io.el *** lisp/eshell/esh-io.el 7 Jun 2008 02:37:13 -0000 1.23 --- lisp/eshell/esh-io.el 6 Oct 2008 08:25:45 -0000 *************** *** 57,63 **** =20 (provide 'esh-io) =20 ! (eval-when-compile (require 'eshell)) =20 (defgroup eshell-io nil "Eshell's I/O management code provides a scheme for treating many --- 57,65 ---- =20 (provide 'esh-io) =20 ! (eval-when-compile ! (require 'cl) ! (require 'eshell)) =20 (defgroup eshell-io nil "Eshell's I/O management code provides a scheme for treating many --8<---------------cut here---------------end--------------->8--- Suggested Changelog entry: --8<---------------cut here---------------start------------->8--- 2008-10-06 Sven Joachim * eshell/em-cmpl.el (require): * eshell/em-hist.el (require): * eshell/em-ls.el (require): * eshell/esh-cmd.el (require): * eshell/esh-ext.el (require): * eshell/esh-io.el (require): Require cl at compile time because `assert' needs it. --8<---------------cut here---------------end--------------->8--- =B9 http://lists.gnu.org/archive/html/help-gnu-emacs/2008-10/msg00120.htm= l ------------=_1223452203-15816-0 Content-Type: message/rfc822 Content-Disposition: inline X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-12.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1099-done) by emacsbugs.donarmstrong.com; 8 Oct 2008 07:44:30 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m987iRIs014596 for <1099-done@emacsbugs.donarmstrong.com>; Wed, 8 Oct 2008 00:44:28 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KnTgJ-0001yQ-Ro; Wed, 08 Oct 2008 03:42:03 -0400 From: Glenn Morris To: 1099-done@emacsbugs.donarmstrong.com Subject: Re: bug#1099: 23.0.60; Various eshell files need cl at compile time for `assert' References: <87bpxy2j31.fsf@gmx.de> X-Spook: Perl-RSA USCODE Albright Cohiba import InfoSec analyzer X-Ran: NwMNex$8P:6WLQS5)*Dd4\^(Y8Rz_P^5q>uAaCqQk;X (Sven Joachim's message of "Mon, 06 Oct 2008 11:01:22 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Sven Joachim wrote: > A recent message=B9 on help-gnu-emacs showed eshell failing because > `assert' is not defined.=20=20 Unreproducible. >There are no less than six eshell files which use this macro without >requiring cl at compile time. The following patch takes care of this: I don't think there is a real problem here, because cl is brought in through other requires, nevertheless for the sake of clarity I have installed your patch. ------------=_1223452203-15816-0--