bug#1075: marked as done (23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color)

[don@donarmstrong.com (Emacs bug Tracking System)]

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]


Your message dated Mon, 24 Nov 2008 23:46:03 -0500
with message-id <0419D148-710C-48C8-9817-2D323CE8C693@gmail.com>
and subject line #1075 - 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color - Emacs bug report logs
has caused the Emacs bug report #1075,
regarding 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1075: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1075
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 4232 bytes --]

From: Lennart Staflin <lenst@lysator.liu.se>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color
Date: Fri, 03 Oct 2008 16:39:07 +0200
Message-ID: <48E62E8B.5010905@lysator.liu.se>


After a crash I with ns_free_indexed_color, and x_clear_image_1 on the
stack. I noticed that x_clear_image_1 calls ns_free_indexed_color with
only one argument, but it takes two arguments. Perhaps that explains a
number of crashes in ns_free_indexed_color.

//Lennart Staflin


In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0)
of 2008-10-03 on sin
Windowing system distributor `Apple', version 49.46.48
configured using `configure '--with-ns' '--enable-maintainer-mode' 
'--without-x' '--with-jpeg' '--with-gif' '--with-png' 'CFLAGS=-g''

Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: en_US.UTF-8
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: nil
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
show-paren-mode: t
auto-insert-mode: t
iswitchb-mode: t
partial-completion-mode: t
recentf-mode: t
cua-mode: t
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
global-auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
abbrev-mode: t

Recent input:
M-x r e p o r t SPC b u g



Recent messages:
Loading /Users/lenst/emacs/lenst-lisp/loaddefs.el (source)...done
Loading /Users/lenst/emacs/lenst-lisp/suck.el (source)...done
Loading ~/emacs/lenst-lisp/lenst...done
Loading /Users/lenst/emacs/lisp/loaddefs.el (source)...done
Loading /Users/lenst/src/emorb/loaddefs.el (source)...done
Loading /Users/lenst/.recentf...done
Cleaning up the recentf list...done (0 removed)
Loading paren...done
Loading /Users/lenst/.emacs-records...done
For information about GNU Emacs and the GNU system, type C-h C-a.




[-- Attachment #3: Type: message/rfc822, Size: 2009 bytes --]

From: Adrian Robert <Adrian.B.Robert@gmail.com>
To: 1075-done@emacsbugs.donarmstrong.com
Subject: #1075 - 23.0.60; [NS] wrong number of arguments in call to ns_free_indexed_color - Emacs bug report logs
Date: Mon, 24 Nov 2008 23:46:03 -0500
Message-ID: <0419D148-710C-48C8-9817-2D323CE8C693@gmail.com>

I am closing this bug.  The call to ns_free_indexed_color() in  
x_clear_image_1() (image.c:1625) had no business being there -- that  
color is not indexed, but a long RGB value derived from  
four_corners_best() or x_alloc_image_color() (which eventually calls  
ns_defined_color() with makeIndex=0).  I checked in a removal as of  
11/24, after closer examination prompted by yet another posting bug  
#1362.  Hopefully this is the end of this!