From: Kevin Rodgers <kevin.d.rodgers@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: bug#4587: Antwort: Re: bug#4587: 23.1; sort-lines and sort-fields always set buffer modified
Date: Thu, 01 Oct 2009 06:25:59 -0600 [thread overview]
Message-ID: <ha274l$hr3$1@ger.gmane.org> (raw)
In-Reply-To: <jwvpr984k97.fsf-monnier+emacsbugreports@gnu.org>
Stefan Monnier wrote:
>>> Yes, that's generally desirable. But in the above cases, given the way
>>> the code currently works, it's fairly inconvenient to do (the code does
>>> modify the buffer, it just so happens that the end text is the same as
>>> the original text), so it doesn't seem worth the trouble.
>
>> Wouldn't it be possible in case of an unmodified buffer to copy the
>> content of the region at the beginning to a temporary buffer, compare it
>> to the result afterwards, and if they match to restore the unmodified
>> status?
>
> I'd indeed expect that to implement the feature you request, the code
> would have to do something like that. Most likely not copying the text
> itself, but instead storing an md5 or somesuch hash of the text.
Not suitable for Emacs, but maybe useful for Roland:
(defadvice sort-lines (around restore-buffer-modified-p activate)
(let* ((buffer-was-modified-p (buffer-modified-p))
(buffer-was-not-modified-md5 (if (not buffer-was-modified-p)
(md5 (current-buffer)))))
ad-do-it
(when (and (not buffer-was-modified-p)
(buffer-modified-p)
(not (equal buffer-was-not-modified-md5 (md5 (current-buffer)))))
(restore-buffer-modified-p buffer-was-modified-p))))
>> I sometimes need to check a list (which isn't small enough to be checked
>> at a glance) after editing it if it is still sorted.
>> Now I write he region before and after sorting it to separate files and
>> compare them, but I wonder if a powerful tool like Emacs must keep such an
>> obvious annoyance like this...
>
> No, it definitely doesn't have to keep such obvious annoyances.
> But it's not very high on the priority list.
--
Kevin Rodgers
Denver, Colorado, USA
next prev parent reply other threads:[~2009-10-01 12:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 16:38 bug#4587: 23.1; sort-lines and sort-fields always set buffer modified Roland.Meier
2009-09-30 4:44 ` Stefan Monnier
2009-09-30 10:00 ` bug#4597: Antwort: " Roland.Meier
2009-09-30 13:51 ` bug#4587: " Stefan Monnier
2009-10-01 12:25 ` Kevin Rodgers [this message]
2009-10-01 14:19 ` Stefan Monnier
2009-10-25 13:41 ` Kevin Rodgers
2009-10-25 15:27 ` Stefan Monnier
2009-09-30 16:56 ` bug#4597: " Magnus Henoch
2022-05-03 19:24 ` bug#4587: " Lars Ingebrigtsen
2022-05-04 7:21 ` Eli Zaretskii
2022-05-04 7:53 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ha274l$hr3$1@ger.gmane.org' \
--to=kevin.d.rodgers@gmail.com \
--cc=4587@emacsbugs.donarmstrong.com \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.