all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kevin Rodgers <kevin.d.rodgers@gmail.com>
To: help-gnu-emacs@gnu.org
Subject: Re: Disabling eldoc-mode during isearch-mode
Date: Wed, 23 Sep 2009 08:58:18 -0600	[thread overview]
Message-ID: <h9dd23$ep1$1@ger.gmane.org> (raw)
In-Reply-To: <1f01d54a-ca4d-415b-af4b-3df4e7152b2c@d4g2000vbm.googlegroups.com>

Nordlöw wrote:
> I'm trying to disable eldoc-mode during isearch-mode to prevent
> flickering caused by their minibuffer-competition.
> 
> I found this
> 
> (defadvice eldoc-display-message-no-interference-p (around not-during-
> isearch)
>   "Prevent eldoc from displaying during isearch."
>   (unless isearch-mode) ad-do-it)
> 
> to do the job but only after having disabled and enabled eldoc-mode
> manually in each buffer that should use this behaviour.

That looks completely wrong: it unconditionally runs the original
definition via ad-do-it, and the (unless isearch-mode) form doesn't
do anything.  Also, the advice is not activated.

(defadvice eldoc-display-message-no-interference-p (around unless-isearch-mode
							   activate)
   "Disable during incremental search."
   (unless isearch-mode
     ad-do-it))

> I also noticed that C-h f eldoc-display-message-no-interference-p only
> says that function is advice once i evaluate it manually after having
> adviced it.
> 
> Does it have something to do byte-compiling?

No, activation.

-- 
Kevin Rodgers
Denver, Colorado, USA





  parent reply	other threads:[~2009-09-23 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23  9:10 Disabling eldoc-mode during isearch-mode Nordlöw
2009-09-23  9:42 ` Lennart Borgman
2009-09-23 14:58 ` Kevin Rodgers [this message]
     [not found] ` <mailman.7337.1253717929.2239.help-gnu-emacs@gnu.org>
2009-09-24 10:18   ` Nordlöw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='h9dd23$ep1$1@ger.gmane.org' \
    --to=kevin.d.rodgers@gmail.com \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.